[Fix] Questbuttons out of questwindow when multiple images are present

[Syreldar 2745]

Hi, I guess I am spending too much time with @ Mitachi.

If you would like a full explanation:

Spoiler

Well, it's simple, really. Every time you call "[INSERT_IMAGE (..)", due to this part of code

		case EVENT_TYPE_INSERT_IMAGE:
		{
			const std::string & imageFile = GetArgumentString("image_name", ScriptCommand.argList);
			const char * title = GetArgument("title", ScriptCommand.argList);
			const char * desc = GetArgument("desc", ScriptCommand.argList);
			int index = atoi(GetArgument("index", ScriptCommand.argList));
			int total = atoi(GetArgument("total", ScriptCommand.argList));

			if (imageFile.empty())
			{
				const char * imageType = GetArgument("image_type", ScriptCommand.argList);
				int iItemIndex = atoi(GetArgument("idx", ScriptCommand.argList));
				PyCallClassMemberFunc(pEventSet->poEventHandler, "OnInsertItemIcon", Py_BuildValue("(sissii)", imageType, iItemIndex, title, desc, index, total));
			}
			else
			{
				PyCallClassMemberFunc(pEventSet->poEventHandler, "OnInsertImage", Py_BuildValue("(ssssii)", imageFile.c_str(), title, title, desc, index, total));
			}
			pEventSet->iAdjustLine += 2;
			break;
		}

specifically, due to the iAdjustLine call, every time an image is inserted within a questwindow via say_item_vnum or say_item_vnum_inline, the script performs what's equivalent to an "[ENTER]" call.

The problem arises when you use say_item_vnum_inline, which is nothing more than multiple say_item_vnums call.

Fix:

This is the hidden content, please

• Sign In
• or
• Sign Up

 

Before and after:

 

Edited September 13, 2025 by Syreldar
Added before & after.