Dragon Soul Drop Item Bug

[Karbust 4737]

Hello

Any idea on how to solve this bug?

 

In case the video isn't enough, after I try to drop a dragon soul gem, I can't do anything else on the window until I close and re-open the client.

 

[PetePeter 36]

It's happen when you using Escape to close the drop window ?

[Karbust 4737]

13 minutes ago, PetePeter said:

It's happen when you using Escape to close the drop window ?

Yes

I added dbg on the RequestDropItem function

    def RequestDropItem(self, answer):
        dbg.LogBox("Got here")
        if not self.itemDropQuestionDialog:
            dbg.LogBox("Got here 2")
            return

        if answer:
            dropType = self.itemDropQuestionDialog.dropType
            dropCount = self.itemDropQuestionDialog.dropCount
            dropNumber = self.itemDropQuestionDialog.dropNumber

            if player.SLOT_TYPE_INVENTORY == dropType or\
                (player.SLOT_TYPE_SKILL_BOOK_INVENTORY == dropType or\
                player.SLOT_TYPE_UPGRADE_ITEMS_INVENTORY == dropType or\
                player.SLOT_TYPE_STONE_INVENTORY == dropType or\
                player.SLOT_TYPE_GIFT_BOX_INVENTORY == dropType or\
                player.SLOT_TYPE_CHANGERS_INVENTORY == dropType and app.ENABLE_SPECIAL_INVENTORY_SYSTEM):

                if dropNumber == player.ITEM_MONEY:
                    net.SendGoldDropPacketNew(dropCount)
                    snd.PlaySound("sound/ui/money.wav")
                else:
                    # PRIVATESHOP_DISABLE_ITEM_DROP
                    self.__SendDropItemPacket(dropNumber, dropCount)
                    # END_OF_PRIVATESHOP_DISABLE_ITEM_DROP
            elif player.SLOT_TYPE_DRAGON_SOUL_INVENTORY == dropType:
                    # PRIVATESHOP_DISABLE_ITEM_DROP
                    self.__SendDropItemPacket(dropNumber, dropCount, player.DRAGON_SOUL_INVENTORY)
                    # END_OF_PRIVATESHOP_DISABLE_ITEM_DROP

        self.itemDropQuestionDialog.Close()
        self.itemDropQuestionDialog = None
        
        dbg.LogBox("Got here 3")

        constInfo.SET_ITEM_DROP_QUESTION_DIALOG_STATUS(0)

It's reaching "Got here" and "Got here 3"

Edited September 19, 2021 by Karbust

[PetePeter 36]

It's a common bug, it's not only happen with Dragon Soul but with any item you will try to drop. The ESC key close the window but don't close the "screen lock" feature.

Try to edit like that :

 

# game.py
# Search def OnKeyDown(self, key):

	def OnKeyDown(self, key):
		if self.interface.wndWeb and self.interface.wndWeb.IsShow():
			return

		constInfo.SET_ITEM_DROP_QUESTION_DIALOG_STATUS(0)

# Replace by


	def OnKeyDown(self, key):
		if self.interface.wndWeb and self.interface.wndWeb.IsShow():
			return

		if key == app.DIK_ESC:
			self.RequestDropItem(False)
			constInfo.SET_ITEM_QUESTION_DIALOG_STATUS(0)

 

[Karbust 4737]

24 minutes ago, PetePeter said:

It's a common bug, it's not only happen with Dragon Soul but with any item you will try to drop. The ESC key close the window but don't close the "screen lock" feature.

Try to edit like that :

 

# game.py
# Search def OnKeyDown(self, key):

	def OnKeyDown(self, key):
		if self.interface.wndWeb and self.interface.wndWeb.IsShow():
			return

		constInfo.SET_ITEM_DROP_QUESTION_DIALOG_STATUS(0)

# Replace by


	def OnKeyDown(self, key):
		if self.interface.wndWeb and self.interface.wndWeb.IsShow():
			return

		if key == app.DIK_ESC:
			self.RequestDropItem(False)
			constInfo.SET_ITEM_QUESTION_DIALOG_STATUS(0)

 

I already have it like this:
 

	def OnKeyDown(self, key):
		if self.interface.wndWeb and self.interface.wndWeb.IsShow():
			return

		if key == app.DIK_ESC:
			self.RequestDropItem(FALSE)
			constInfo.SET_ITEM_DROP_QUESTION_DIALOG_STATUS(0)

		try:
			self.onPressKeyDict[key]()
		except KeyError:
			pass
		except:
			raise

		return TRUE

It happens with ESC and clicking Cancel...

 

EDIT:

Solved. Thanks @PACI

On game.py, on RequestDropItem function, at the end was SET_ITEM_DROP_QUESTION_DIALOG_STATUS, but on uidragonsoul.py it was checking for GET_ITEM_QUESTION_DIALOG_STATUS...

Edited September 19, 2021 by Karbust