Refine item with switch

[Cripplez 40]

Hello

I'm trying to make this refine item only for item_weapon and another refine item for item_armor

I tried something like this but it's not working, the item 71032 should only work for weapon but when i use it on a weapon or another item it says the message of error

Do you know how i can fix this? Thank you

					case USE_TUNING:
					case USE_DETACHMENT:
						{
							LPITEM item2;
							switch (item->GetVnum())
							{
								case 71032:
									if (item2->GetType() != ITEM_WEAPON)
									{
										ChatPacket(CHAT_TYPE_INFO, LC_TEXT("error_refine_only_weapon"));
										return false;
									}
									break;
								case 39022:
									if (item2->GetSubType() != ARMOR_BODY)
									{
										ChatPacket(CHAT_TYPE_INFO, LC_TEXT("error_refine_only_armor"));
										return false;
									}
									break;
							}
                          

							if (!IsValidItemPosition(DestCell) || !(item2 = GetItem(DestCell)))
								return false;

							if (item2->IsExchanging() || item2->IsEquipped()) // @fixme114
								return false;

#ifdef ENABLE_ACCE_SYSTEM
							if (item->GetValue(0) == ACCE_CLEAN_ATTR_VALUE0)
							{
								if (!CleanAcceAttr(item, item2))
									return false;

								return true;
							}
#endif

 

Edited February 29, 2020 by Cripplez

[WeedHex 627]

" but when i use it on a weapon or another item it says the message of error"

 

What error?

[Cripplez 40]

Sorry I mean this message "error_refine_only_weapon" that should say it when I use 71032 on an item that is NOT an ITEM_WEAPON
 

								case 71032:
									if (item2->GetType() != ITEM_WEAPON)
									{
										ChatPacket(CHAT_TYPE_INFO, LC_TEXT("error_refine_only_weapon"));
										return false;
									}

 

[Cripplez 40]

Solved doing this instead:

 

					case USE_TUNING:
					case USE_DETACHMENT:
						{
							LPITEM item2;
                          
							if (!IsValidItemPosition(DestCell) || !(item2 = GetItem(DestCell)))
								return false;

							if (item2->IsExchanging() || item2->IsEquipped()) // @fixme114
								return false;
                          
							switch (item->GetVnum())
							{
								case 71032:
									if (item2->GetType() != ITEM_WEAPON)
									{
										ChatPacket(CHAT_TYPE_INFO, LC_TEXT("error_refine_only_weapon"));
										return false;
									}
									break;
								case 39022:
									if (item2->GetSubType() == ARMOR_BODY)
									{
									}
                                	else
									{
										ChatPacket(CHAT_TYPE_INFO, LC_TEXT("error_refine_only_armor"));
										return false;
									}
									break;
							}

#ifdef ENABLE_ACCE_SYSTEM
							if (item->GetValue(0) == ACCE_CLEAN_ATTR_VALUE0)
							{
								if (!CleanAcceAttr(item, item2))
									return false;

								return true;
							}
#endif