New exploit?!

[Dr3Ame3r 35]

Does anybody knows if some another kind of exploit is here? I solved the messenger one.

I am trying to find the source of the "bug" or the "exploit", why do i say that?

Because, sometimes at the night server don't even crash 1 time, ok.

After people come from school like 2PM server is crashing, 5-10 minutes, 30 minutes pause, then crashing again.
I can add a point where the one with the exploit said, the server will not crash further, he was right.

And today came again and crashed it.

And someone showed me tonight an exploit that crashed every server i wanted, i am wondering if someone knows about this exploit, or if it exists?

I can give you a printscreen from GDB https://metin2.download/picture/VTEQQFmIa2sAswTTuf703TRnJ74G2TMO/.png

Syserr from the channel with the error 
https://metin2.download/picture/n4HWhpX643EzuVy1sC1cp8lfmwYZ9VLQ/.png

Edited September 2, 2022 by Metin2 Dev
Core X - External 2 Internal

[Koray 3321]

 

Game is trying get quest flag result from NULL character pointer, Search in google; "[FIX] quest::PC::GetFlag Crash" and apply it

Edited August 20, 2022 by Metin2 Dev
Core X - External 2 Internal

[Ken 1035]

@Koray

If the system didn't know anything about newmember is pc or not. even If you edit that function, it will be unnecessary.

Best Regards

Ken

Edited August 20, 2022 by Metin2 Dev
Core X - External 2 Internal

[Koray 3321]

True point but your method is for only published exploit, I'm sure have a like similar wrong usages for this flags. So if you want for all general fix you can use my said method.

[Ken 1035]

@Koray

It's not totally fix. It's about code style. If you try to use CQuestManager::GetPCForce for a NPC or monster or pet, Of course you will get a null pointer. It more makes sense to write the codes well.

Best Regards

Ken

[Dr3Ame3r 35]

So it is ok to use koray's method too combined with ken's one?

[ds_aim 263]

2 hours ago, Dr3Ame3r said:

        case GUILD_SUBHEADER_CG_ADD_MEMBER: {
            const DWORD vid = *reinterpret_cast<const DWORD*>(c_pData);
            LPCHARACTER newmember = CHARACTER_MANAGER::instance().Find(vid);

            if (!newmember) {
                ch->ChatPacket(CHAT_TYPE_INFO, LC_TEXT("<길드> 그러한 사람을 찾을 수 없습니다."));
                return SubPacketLen;
            }

            if (!newmember->IsPC())
                return SubPacketLen;

            pGuild->Invite(ch, newmember);
        }

 Use this and it's totaly solved.

[Koray 3321]

This thread or this problem isn't about  "GetPCForce"  usage, He is getting error from GetQuestFlag function mistake and my post for this fix. If you are trust ymir "code style" don't change from GetQuestFlag.

[Dr3Ame3r 35]

Ok, we'll mark this as solved for the moment.

I'll come back with further questions if it will happen in the future.

[Ken 1035]

@Koray

If you can't understand the goal of GetPCForce, don't use the source files. They may miss a few condition but your goal is not totally fix. Your method is just about extra make sure..

Best Regards

Ken

[M.Sorin 342]

//nvm now i see he has solved.