Nirray

[Hidden Content] [Hidden Content] [Hidden Content] "Tabs should be used solely to remain consistent with code that is already indented with tabs." Replace spaces with TABs Line: 401 (two TABs instead of x spaces) Line: 491 (one TAB instead of x spaces)

@pollux Please, Rules update: §2 Topics (2.5) Questions & Answers specific rules Don't modify your thread (or reply to it) to mark it solved, and not explain the solution to the issue. Please use our tag system and vote good/bad answers so everyone can clearly see what matters! You need at least basic knowledge of programming.

Seriously? Change it to TABs XD

You mean dmg hack svside check from clientside .mse file? Or waithack from SendAttackPacket? If waithack - it is still working (hidden for example) Also, because of first check "GetLastAttackTime" there's a input "lag" (you need to attack twice new mob to deal damage [even visible in your gyazo gif with metin stone @Rakancito]) It's more like workaround ? To fix it correctly we should change the CalcMeleeDamage CalcArrowDamage iDam = 0; like char_battle.cpp does with bow if (IS_SPEED_HACK(m_me, pkVictim, dwCurrentTime)) iDam = 0; I didn't want to be rude I also want to fix it and I'm here to help ? input lag: [Hidden Content] dmghack after second hit: [Hidden Content]

/b Hehe :)))))))

locale_*/locale/*/insult.txt in client pack

IDs are working fine so it's something about 'import player' defines for python from c++.

replace whole PyObject* poModule = Py_InitModule("player", s_methods); with: [Hidden Content] And add all new defines from your new added systems (ifdef etc.) [you need to find missing ones from your old PythonPlayerModule] Why -> your client source~python defines are broken. Or workaround if you're to lazy: just change: def __GetTotalAtkText(self): minAtk=player.GetStatus(player.ATT_MIN) maxAtk=player.GetStatus(player.ATT_MAX) atkBonus=player.GetStatus(player.ATT_BONUS) attackerBonus=player.GetStatus(player.ATTACKER_BONUS) if minAtk==maxAtk: return "%d" % (minAtk+atkBonus+attackerBonus) else: return "%d-%d" % (minAtk+atkBonus+attackerBonus, maxAtk+atkBonus+attackerBonus) to: def __GetTotalAtkText(self): minAtk=player.GetStatus(29) maxAtk=player.GetStatus(30) atkBonus=player.GetStatus(95) attackerBonus=player.GetStatus(91) if minAtk==maxAtk: return "%d" % (minAtk+atkBonus+attackerBonus) else: return "%d-%d" % (minAtk+atkBonus+attackerBonus, maxAtk+atkBonus+attackerBonus) (IT'S NOT A FIX, YOUR .cpp part is still wrong.)

Okay, we've found our enemy -> packet.h and PythonPlayerModule.cpp May I see your UserInterface\PythonPlayerModule.cpp? By the way: have you added a wolfman recently?

import chat

metin2dev encoding is bugged [Hidden Content] (@pollux->edit: I forgot about [Hidden Content] XD)

UserInterface/packet.h enum EPointTypes may I see it? also, could you debug your uicharacter for me? May you replace this in uicharacter.py def? def __GetTotalAtkText(self): minAtk=player.GetStatus(player.ATT_MIN) maxAtk=player.GetStatus(player.ATT_MAX) atkBonus=player.GetStatus(player.ATT_BONUS) attackerBonus=player.GetStatus(player.ATTACKER_BONUS) chat.AppendChat(7, "packet.h : min %d max %d bonus %d" % (player.GetStatus(player.ATT_MIN), player.GetStatus(player.ATT_MAX), player.GetStatus(player.ATT_BONUS))) chat.AppendChat(7, "without packet.h : min %d max %d bonus %d" % (player.GetStatus(29), player.GetStatus(30), player.GetStatus(95))) if minAtk==maxAtk: return "%d" % (minAtk+atkBonus+attackerBonus) else: return "%d-%d" % (minAtk+atkBonus+attackerBonus, maxAtk+atkBonus+attackerBonus) my aura gives 625 attack

Check your interfacemodule.py def RefreshCharacter(self): ## Character ĆäŔĚÁöŔÇ ľó±Ľ, Inventory ĆäŔĚÁöŔÇ Ŕü˝Ĺ ±×¸˛ µîŔÇ Refresh self.wndCharacter.RefreshCharacter() self.wndTaskBar.RefreshQuickSlot() and game.py def RefreshCharacter(self): if self.interface: self.interface.RefreshCharacter() any client syserr.txt errors/warnings or is it empty?

Okay, one question - if you re-open character window, does attack update or not?

This attachment is not available. It may have been removed or the person who shared it may not have permission to share it to this location. I need only uicharacter.py then

It might be: mysql skill_proto bug, uicharacter.py bug, serverside player_skill.cpp bug or affect bug Show us those 4 files ?

Maybe it will help you a little bit ? LPCHARACTER CHARACTER_MANAGER::SpawnMob(DWORD dwVnum, long lMapIndex, long x, long y, long z, bool bSpawnMotion, int iRot, bool bShow) and LPCHARACTER CHARACTER_MANAGER::SpawnMobRandomPosition(DWORD dwVnum, long lMapIndex) in char_manager.cpp in source game

Remember to add collision in npc .msm file Group AttachingData00 { AttachingDataType 1 isAttaching 1 AttachingModelIndex 0 AttachingBoneName "BONE_NAME" CollisionType 1 SphereDataCount 1 Group SphereData00 { Radius 100.000000 Position 0.000000 0.000000 0.000000 } }

"The hero we need, but don't deserve" THANKS ?

Hi, I'm trying to add 7/8 skill (not passive). I've done the server source (game + lua, mysql) part. Now I'm fighting with clientside. 7/8th skills just disappear from skill page (they are working if not /skillup ~ only dissapearing). Problem with chat "debug": [Hidden Content] chat.AppendChat(7, str(skillIndex) + " : " + str(slotNumber)) uicharacter.py: ACTIVE_PAGE_SLOT_COUNT = 8 0906 16:02:37356 :: File "game.py", line 602, in RefreshSkill 0906 16:02:37356 :: File "interfaceModule.py", line 558, in RefreshSkill 0906 16:02:37356 :: File "uiCharacter.py", line 888, in RefreshSkill 0906 16:02:37356 :: File "uiCharacter.py", line 814, in __RefreshSkillPage 0906 16:02:37356 :: File "uiCharacter.py", line 1274, in __GetRealSkillSlot 0906 16:02:37357 :: RuntimeError 0906 16:02:37357 :: : 0906 16:02:37357 :: skill.GetSkillType - Failed to find skill by 0 0906 16:02:37357 :: Thanks for help ?

UPDATE2: Fixed: [Hidden Content] Reason: extern const DWORD c_iSkillIndex_Combo from PythonPlayerModule.cpp was with wrong ID (my old edit - error) @VegaS™ thank you for your time!

0903 00:05:25663 :: Combo level: 0 0903 00:05:26868 :: Combo level: 1 0903 00:05:27627 :: Combo level: 2 (/setsk 122 0,1,2) Update: I guess the problem lies somewhere here

Neither of them work: skillup, skill book, setksk 122 1/2, pc.set_skill_level(122, 2) [quest], DISABLE_BY_POINT_UP (on/off) [skill_proto] in clientside Interface - I've already tried ? [Hidden Content] 50304 ID = The Art Of Combo skill book LUA-> "Powodzeniem" = Successful Result: still cannot use it (Debug: skill id: 122 is set to 1 from 0) @VegaS™ It's more like client can't set skill level on combo icon [skill index/skill slot] -> Leadership and Mining works fine and other support-passives too Update: On my old RAW client combo is working like a charm So it's a python bug/client source ? [Hidden Content] Update2: it's not skilldesc.txt, skilltable.txt problem [checked with default Metin2 ones] and uicharacter.py (checked with original one)

Hi DEVs My combo support skill is not working (other support skills are working fine [I mean skill level]). I can set it to 1/2 via command, support skill points or combo skill books - I just cannot turn it on/off from characterwindow (CANNOT_SKILL_NOT_YET_LEARN) - on skill icon there's no skill level (0 (empty), 1/2 [or like on leadership 0-19/m1-10/g1-10/P]) Console command [python] (setcombotype 0/1/2) is working Other players can see my combo [Hidden Content] [Hidden Content] syslog from channel and DB Sep 2 22:11:18 :: COMMAND: Nirray2: setskill Sep 2 22:11:20 :: COMMAND: Nirray2: skillup Sep 2 22:11:20 :: SkillUp: Nirray2 122 0 1[Before:0] type 0 Sep 2 22:11:20 :: COMMAND: Nirray2: skillup Sep 2 22:11:20 :: SkillUp: Nirray2 122 0 2[Before:1] type 0 Sep 2 22:11:20 :: COMMAND: Nirray2: skillup Sep 2 22:11:20 :: SAVE: Nirray2 966460x276822 Sep 2 22:11:20 :: COMMAND: Nirray2: skillup (Which means server side is working and skill index+skill level are set correctly [I can logout character/shutdown server and the combo level is still here]) No clientside syserr. Python part bug? Client source bug? Any ideas? I can't figure it out ? Thanks ?