TMP4

3 hours ago, DrTurk said:

 

Tha hell have you done with the subtypes?

 

B2T:

Upload your item_length.h (from server src) and ItemCSVReader.cpp (from dumpproto) and item_proto.txt/sql

I just copied it from a tutorial It is because at the enum the creator used costume_weapon = x, so that's why the gaps and a lot of people have it like that.

Of course i removed those gaps in my files.

He already uploaded his files and i already gave him the correct arSub28[] but he said it's not working, and i said than it should be not dump_proto's problem.

But yes, maybe his problem in his item_proto.txt. (wrong value3)

You said "the problem occurred when i compile a new dump_proto"

Can you show me the old dump_proto?

Also why did you swap the old for a new?

If you compile with the old just for test, it will work again?

Then your problem is not in dump_proto if that's not work.

I don't think so + your acce is from Marty too probably, but anyway try what i wrote, should work.

So you're using Marty's source, he cleaned it so this should work for you in your dump_proto:

static string arSub28[] = { "COSTUME_BODY", "COSTUME_HAIR", "COSTUME_ACCE", "COSTUME_WEAPON" };

Of course, i did not give it to replace  It was just for example for 2 costume weapon system variation.

Since we still don't see your code, and the order of the costume related systems i can't give exact working code. I'm not a mindreader 

The best way is to post your old working dump_proto's cpp, and your new dump_proto's cpp and we can merge it.

I think if you post the dump_proto's code (ItemCSVReader.cpp) you'll get help for free

You did not got answer in your thread because people tired to ask always "Include your code, we're not mindreaders"

For me it is like:

static string arSub28[] = { "COSTUME_BODY", "COSTUME_HAIR", "NONE", "NONE", "NONE", "NONE", "NONE", "NONE", "NONE", "COSTUME_WEAPON_SWORD", "COSTUME_WEAPON_DAGGER", "COSTUME_WEAPON_BOW", "COSTUME_WEAPON_TWO_HANDED", "COSTUME_WEAPON_BELL", "COSTUME_WEAPON_FAN", "COSTUME_MOUNT", "COSTUME_SASH" };

But it is the non value3 version, i think it's better  But if you use the value 3 version you probably have just one "COSTUME_WEAPON" here like

static string arSub28[] = { "COSTUME_BODY", "COSTUME_HAIR", "NONE", "NONE", "NONE", "NONE", "NONE", "NONE", "NONE", "COSTUME_WEAPON", "COSTUME_MOUNT", "COSTUME_SASH" };

(And check costume_mount, costume_sash, maybe you installed some before so you have to place it before the weapon)

Change this:

if d.getf("spider_dungeon") == 1 and pc.getqf("object") == 0 begin

to this:

if d.getf("spider_dungeon") == 1 and pc.getqf("object") == 0 then

They should, at least in normal inventory i'm sure, but this is special inventory that's why i said "maybe"

Quote

Can we upload old items differently to players' inventory?

You have to write a query for it.(To move the items to an empty slot)

I think it is possible but very very complex. I was never good in writing query so i'm not your man in that, sorry.

Yes, correct.

I hope that was the only bug and you're good.

So basicly your problem was there was 2 or more items in the same slot because of that.

Keep in mind the items what already uses the same slots can still produce the syserrs for you.

Tell the users if they missing some items, leave their first slot line empty and log out for 7min.

Maybe the missing items will appear.

Okey i found it.

			if (item->IsDragonSoul())
				item->AddToCharacter(owner, TItemPos(DRAGON_SOUL_INVENTORY, iEmptyCell));
#ifdef ENABLE_SPECIAL_STORAGE
			else if (item->IsSpecialStorageItem())
				item->AddToCharacter(this, TItemPos(item->GetSpecialWindowType(), iEmptyCell));
#endif
			else
				item->AddToCharacter(owner, TItemPos(INVENTORY, iEmptyCell));

replace the "this" with "owner" (Line 7750, be sure to replace just there!)

You can see there is owner everywhere (normal and dragon soul), it is just a "typo" i think.

Post here, no PM.

I may not able to find the problem anyway since i never used that special inventory.

Then it is really the special inventory's problem.

Either post your cpp file (risking Itachi's anger) and we may fix it , or go back to Itachi with this video explanation.

We need CHARACTER::PickupItem mostly from your char_item.cpp, especially the part under this

else if (!IS_SET(item->GetAntiFlag(), ITEM_ANTIFLAG_GIVE | ITEM_ANTIFLAG_DROP) && GetParty())

*Feel the Turkish*

I'm not, don't worry

I just wanted to point out that i said one of Marty's variable name before (Just a name xD) and you went nuts,

but you ask this guy to expose 2 full cpp file with paid systems.

9 minutes ago, WeedHex said:

show us char_item.cpp and char.cpp

o_O after you gave me hate (due to a misunderstanding) when i said to a guy to use LC_IsNewCIBN instead of g_bChinaIntoxicationCheck (because that is Marty's and he used the kraizy.tgz) i thought you're against such things  He will expose a lot of parts of their non warez system

Anyway i feel like @xDwin kinda ignoring all of my comment so i do not really care for him.

So you already spent hundreds, maybe a thousand euro to your server, i'm really wonder why don't you just hire somebody now 

(No, not me, before you think i just say because of that ) 

Since just stackable items affected as you say, can you check if the unstacking process is okey in the special inventory?

It should be similar to the normal inventory, you can take that as an example. (In CHARACTER::MoveItem)

Maybe you can try to reproduce the problem too. Unstack an item, log out and wait for the flush (default 7min) and log in back.

Also what Denis said above can be the problem's cause too in a very high percent...

Maybe when they unstack the item with move_item it's not register the item as another item.

But i'll honest with you. You'll be better to hire a developer. 

We can write sentences what can be the cause but since you're not very familiar with c++ and problem solving, you don't go far with it.

-We don't have access to your files and server

-Most of us don't have special inventory, especially not Itachi's version

-You cannot post his code to this forum either to show us cause it would be against the rules and he would be angry to you

In the future, run a test server at least on your local machine for you to test out deeply the stuffs before it goes to the live server.

That's the clientside what i uploaded for b2 and c2. (Other maps are available in every basic client, open season1 and season2.eix-epk)

You can make the serverside with World Editor to dump a server_attr.

Hungarian:

39 minutes ago, dako12 said:

Also ken have checkname in the title so not possible to add name with spaces or specials chars anymore but I think it's worth to keep it that way as I don't have as much knowledge in C+ to choose what's best for security (offtopic)

This was a problem what i had to solve when i was a dev at a srv, i removed the checkname function and extended the navicat/player/banword table with the suspecius characters like : ; ' " % @ -- so we were good. Banword check are default in Ken's offshop, it is right under the check_name.

I remember one thing what was not fixed in most server, but maybe Ken later fixed it since you said you have the non-public newer version.

Price change do not have p2p packet so if you change price from other core, the guests will not kick out. There was some nasty player who did post lots of items for 1 yang what cost more, quickly changed channel and he fastly changed the price to higher, and the victims thought they buy items for 1 yang, but they bought for 999.999.999 if the nasty player had luck...

Either make the p2p packet or at price change at offlineshop_manager.cpp write a return if the npc is not available.

But as i say, maybe Ken fixed this later... If so don't judge me please.

As of sash, i don't use LennT version but the official-ish one, but if you check if offline shop is open (as simple shop, safebox, trade etc) you will not have problems with that.

With notepad++ change the file's (the .cpp) encoding to the correct one. Most of the time "ansi" is the needed.

Also since it's an LC_TEXT do the same with your locale_string.txt.

Probably you want to ctrl+a ctr+c the cpp's text and overwrite after changing the encoding, because it will most likely replace the characters with ?? in your cpp, but after you can delete the whole and paste what you ctrl+c before so you will not have ??.

1 minute ago, perfect said:

@TMP4 i know man i dont have syser OMG

up

up

up

up

up

Okey @Denis i gave up 

You doesn't even understand me

You're creating the syserr to check if the count is ok or not.

A syserr can be used for debug too even if you wonder

Edit: Then enable it or use sys_log.