quest crash core / old sura bugs (I PAY!)

[59sos 0]

Hello there, I am glad to find you here again after 3 years since I got out of this game , I wanted to take advantage of this moment and i open a server I lost allmost all contacts of metin2 servers owner and developpers ,  and I have no one to ask for help.

 

i have 1 big problems and 2 bugs who need fixes.. for which I would be willing to pay (paypal)

 

1) A crash core in ch1 /map1 core where is the most players online ...

Spoiler

game core:

https://metin2.download/picture/2ZwoF85Qi3NALPE09GhtrOilsnHg1F1z/.png

 

I collected some syserr and syslog ,  and in syserr i don`t see anything suspect  so this is an example

-------------------------------------------------------------------------

SYSERR: Mar 27 18:02:17 :: Resume: wrong QUEST_WAIT request! : 91799
SYSERR: Mar 27 18:03:26 :: OnClick: OnClick Fail (Vitezomanu->Orph3us) - pc is exchanging
SYSERR: Mar 27 18:04:01 :: pid_init: 
Start of pid: 36188

 

but in the syslog , this errors it`s repeating

--------------------------------------------------------------------

Mar 27 18:03:50 :: reallocating buffer to 8192, current 1024
Mar 27 18:03:50 :: AddAffect  type 215 apply 0 0 flag 28 duration 5
SYSERR: Mar 27 18:04:01 :: pid_init: 
Start of pid: 36188

 

 

 

2) In the Demon Tower the sura characters with weapon skills when he activate the Enchanted Blade receive a big damage from the mob/ mobs.

 

3)Sura weapon skils make LAG at DISPEAL skill . I need the correct bug fixed because the fix from the google make another bugs at cooldown and damage.

 

 

Thx you /  i wait you reply or pm/discord : magic59sos#4702 .

Edited August 25, 2022 by Metin2 Dev
Core X - External 2 Internal

[Syreldar 1821]

1. Post the quest.

2. Post Character::Damage from char_battle.cpp, the snippet after this line:

if (pAttacker->GetPoint(POINT_HIT_HP_RECOVERY) && number(0, 4) > 0) // 80% Č®·ü

3. https://metin2.dev/board/topic/17933-affect-fix-weaponry-suras-dispel-and-healing-power-shamans-heal-lag-bug/ 

[59sos 0]

i like your quick answer , thx you

 

1) I don`t know which quest is ...  from core error i belive  that`s problem from a npc/quest .

2)

Spoiler

// 칠 때마다 HP회복
            if (pAttacker->GetPoint(POINT_HIT_HP_RECOVERY) && number(0, 4) > 0) // 80% 확률
            {
                int i = MIN(dam, iCurHP) * pAttacker->GetPoint(POINT_HIT_HP_RECOVERY) / 100;

                if (i)
                {
                    CreateFly(FLY_HP_SMALL, pAttacker);
                    pAttacker->PointChange(POINT_HP, i);
                }
            }

            // 칠 때마다 SP회복
            if (pAttacker->GetPoint(POINT_HIT_SP_RECOVERY) && number(0, 4) > 0) // 80% 확률
            {
                int i = MIN(dam, iCurHP) * pAttacker->GetPoint(POINT_HIT_SP_RECOVERY) / 100;

                if (i)
                {
                    CreateFly(FLY_SP_SMALL, pAttacker);
                    pAttacker->PointChange(POINT_SP, i);
                }
            }

            // 상대방의 마나를 없앤다.
            if (pAttacker->GetPoint(POINT_MANA_BURN_PCT))
            {
                if (number(1, 100) <= pAttacker->GetPoint(POINT_MANA_BURN_PCT))
                    PointChange(POINT_SP, -50);
            }
        }
    }

3)Sounds good , so your fix are the completion of full fix. Nice!  i try it now.

Edited March 28, 2020 by 59sos

[Syreldar 1821]

5 minutes ago, 59sos said:

i like your quick answer , thx you

 

1) I don`t know which quest is ...  from core error i belive  that`s problem from a npc/quest .

2)

  Hide contents

 

3)Sounds good , so your fix are the completion of full fix. Nice!  i try it now.

1. Well, find it or I can't help you.

2. Change this snippet:

            if (pAttacker->GetPoint(POINT_HIT_HP_RECOVERY) && number(0, 4) > 0) // 80% 확률
            {
                int i = MIN(dam, iCurHP) * pAttacker->GetPoint(POINT_HIT_HP_RECOVERY) / 100;

                if (i)
                {
                    CreateFly(FLY_HP_SMALL, pAttacker);
                    pAttacker->PointChange(POINT_HP, i);
                }
            }

            // 칠 때마다 SP회복
            if (pAttacker->GetPoint(POINT_HIT_SP_RECOVERY) && number(0, 4) > 0) // 80% 확률
            {
                int i = MIN(dam, iCurHP) * pAttacker->GetPoint(POINT_HIT_SP_RECOVERY) / 100;

                if (i)
                {
                    CreateFly(FLY_SP_SMALL, pAttacker);
                    pAttacker->PointChange(POINT_SP, i);
                }
            }

Into this:

			
            if (pAttacker->GetPoint(POINT_HIT_HP_RECOVERY) && number(0, 4) > 0) // 80% E¢ç¡¤u
            {
                int i = (iCurHP >= 0 ? MIN(dam, iCurHP) : dam) * pAttacker->GetPoint(POINT_HIT_HP_RECOVERY) / 100;
                if (i)
                {
                    CreateFly(FLY_HP_SMALL, pAttacker);
                    pAttacker->PointChange(POINT_HP, i);
                }
            }
            if (pAttacker->GetPoint(POINT_HIT_SP_RECOVERY) && number(0, 4) > 0) // 80% E¢ç¡¤u
            {
                int i = (iCurHP >= 0 ? MIN(dam, iCurHP) : dam) * pAttacker->GetPoint(POINT_HIT_SP_RECOVERY) / 100;
                if (i)
                {
                    CreateFly(FLY_SP_SMALL, pAttacker);
                    pAttacker->PointChange(POINT_SP, i);
                }
            }

3. My fix is the only and complete fix for the issue.

Edited March 28, 2020 by Syreldar