Block 2 "Ring" types with the same Vnum

[Veneno 6]

Hello guys I added Ring slots to my system and I searched for a function that blocks 2 rings with the same vnum (id) to be equipped at the same time. I found this:

Spoiler

if (item->GetType() & ITEM_RING)
    {
        if ((GetWear(WEAR_RING1) && GetWear(WEAR_RING1)->IsSameSpecialGroup(item)) || (GetWear(WEAR_RING2) && GetWear(WEAR_RING2)->IsSameSpecialGroup(item)))
        {
            ChatPacket(CHAT_TYPE_INFO, LC_TEXT("You can't put two same items in the same time."));
            return false;
        }
    }

 but this blocks 2 items with the same type (ring) to be equipped at the same time. I don't know C++ so is there anybody who can help me modify this function to work for 2 item vnums and not 2 item types?

[TRBizeps 48]

#push i need this, can anyone help please?

[Fazer 694]

Wrong post.

1 hour ago, arves100 said:

if (item->GetType() & ITEM_RING)
    {
        if ((GetWear(WEAR_RING1) && GetWear(WEAR_RING1)->GetVnum()) || (GetWear(WEAR_RING2) && GetWear(WEAR_RING2)->GetVnum()))
        {
            ChatPacket(CHAT_TYPE_INFO, LC_TEXT("You can't put two same items in the same time."));
            return false;
        }
    }

 

Try with this

this is work i use it too.

[JeeX 37]

Unfortunately isnt working...
Im searching this fix too...

With this Fix -> It blocks 2 Items with the same type - So Slot1: Ring - so i cant give a secound ring in the secound slot, because it is blocked...

 

What we need:

2 Items with same Type (ring)
you can use both rings into slots BUT, it isnt allowed 2 items with the Same item in these slots.
Ring1=CANDY, Ring2=CANDY ----- NO

RIng1=CANDY, Ring2=Ring of Lethal Power ---- YES

Edit:
This is my whole function:
not working.
http://pastebin.com/vQb38aZG

Please help...
thanks
Best Regards.

[JeeX 37]

no it isnt working :/

with this code: it blocks the different rings too (so you cannt equip two rings at the same time - also you cannt equip a secount ring)

but it isnt working to block only the "same vnum" of rings,
i only want to equip 2 ring at the same time, but not the same vnum of the rings.
pls help.

[JeeX 37]

Isnt working - same problem

[JeeX 37]

nope, same problem - it blocks the secound ring...

its okay, that you couldn't test it, im only happy about, that someone will help me!
Thank you for this!

[JeeX 37]

yes
i have in Slot 1: CANDY equipped

i will equip Ring of Lethal Power into Slot2
and if i click on the ring to equip, it displays me " You can't put two same items in the same time. "

So it isnt possible to equip 2 items with type "item_rings"


normally, it should be able to equip 2 rings, but different (ring of lethal... - candy), not the same one (candy - candy)

[JeeX 37]

isnt working - only blocking the second ring.

[Deliris 401]

Try now, should work..

if (item->GetType() == ITEM_RING) 
{
    if (GetWear(WEAR_RING1)->GetVnum() == GetWear(WEAR_RING2)->GetVnum())
        ChatPacket(CHAT_TYPE_INFO, LC_TEXT("You can't put two same items in the same time."));

 return false;
    else return true;
}
 

 

[JeeX 37]

i'll get errors when i'm compile the game-source

char_item.cpp:8215: error: expected primary-expression before 'return'
char_item.cpp:8215: error: expected `;' before 'return'

 

I Try this one:

    if (item->GetType() == ITEM_RING)
    {
        if (GetWear(WEAR_RING1)->GetVnum() == GetWear(WEAR_RING2)->GetVnum())
        {
            ChatPacket(CHAT_TYPE_INFO, LC_TEXT("You can't put two same items in the same time."));
            return false;
        }

    return true;

    }

And this one:
    if (item->GetType() == ITEM_RING)
    {
        if (GetWear(WEAR_RING1)->GetVnum() == GetWear(WEAR_RING2)->GetVnum())
        {
            ChatPacket(CHAT_TYPE_INFO, LC_TEXT("You can't put two same items in the same time."));
            return false;
        }
        else
        {
            return true;
        }
    }

i try this 2 functions, these are compileable and it isnt working too, it blocks the second ring.
Sorry if this code which i tryed isnt correct, but im not soo good in c++ ^^

[JeeX 37]

if (item->GetWearFlag() & WEAR_RING) {
i get compiling errors.

 

wear_ring isnt declarated because its only item_ring as a type in source.
 

[TRBizeps 48]

doesnt work !

[VegaS 1072]

   if (item->GetType() == ITEM_RING)
   {
      LPITEM ring[2] = { GetWear(WEAR_RING1), GetWear(WEAR_RING2) };
      for (int i = 0; i < 2; i++)
      {
         if (ring[i])
         {
            if (ring[i]->GetVnum() == item->GetVnum())
            {
               ChatPacket(CHAT_TYPE_INFO, "You can not equip this item twice!");
               return false;
            }
         }
      }
   }

Not mine.

[JeeX 37]

thanks for help but not working fine.

actually: it Blocks 2 rings - different rings too...

i want that it is blocking the same vnum of ring.

For Example:

Ring1=CANDY, Ring2=CANDY ----- NO

RIng1=CANDY, Ring2=Ring of Lethal Power ---- YES

if anyone can solve my problem / help me; i will give a Paysafecard for free!

[Grzyb 10]

My new fix 100% work:

	if (item->GetType() == ITEM_RING)
	{
		std::vector<LPITEM> FixByMuchomor = { GetWear(WEAR_RING1), GetWear(WEAR_RING2) };
		const int FixByMuchomorSize = FixByMuchomor.size();

		for (int i = 0; i < FixByMuchomorSize; i++)
		{
			if (FixByMuchomor[i])
			{
				if (FixByMuchomor[i]->GetVnum() == item->GetVnum() || FixByMuchomor[i]->GetSubType() == item->GetSubType())
				{
					ChatPacket(CHAT_TYPE_INFO, "Nie możesz założyć tego przedmiotu dwa razy!");
					return false;
				}
			}
		}
	}

 

Edited June 1, 2023 by Grzyb

[ziad 13]

 

did anyone fix this ?  tried this one , oke if u do right click on the item , cant wear nor unwear the item , but if you drag the item into the slot it can be weared twice