Skill Buff Wolfman!

[Cyxer 167]

I have a problem with the wolfman!
The buff skill not add other members of the group.
Only in wolfman!

[Galet 590]

Check your party flag and the position of the party_flag in skill_proto

[Cyxer 167]

skill:h

skill_proto(design table)

skill_proto:

[Galet 590]

Ok, so you failed somewhere in gamesource

[Cyxer 167]

You want to send your skill.h and char_skill.cpp?

[JinHan 273]

check this https://metin2dev.org/board/index.php?/topic/5029-c-party-flag/&page=1 , if you already installed this, check this function  in char_skill.cpp 

FPartyPIDCollector f;

GetParty()->ForEachOnMapMember(f, GetMapIndex());

for (std::vector <DWORD>::iterator it = f.vecPIDs.begin(); it != f.vecPIDs.end(); it++)

{

LPCHARACTER ch = CHARACTER_MANAGER::instance().FindByPID(*it);

if (ch)

ch->ComputeSkill(dwVnum, ch);

}

 

then ,delete if(ch), done.

[Cyxer 167]

4 hours ago, JinHan said:

check this https://metin2dev.org/board/index.php?/topic/5029-c-party-flag/&page=1 , if you already installed this, check this function  in char_skill.cpp 

FPartyPIDCollector f;

GetParty()->ForEachOnMapMember(f, GetMapIndex());

for (std::vector <DWORD>::iterator it = f.vecPIDs.begin(); it != f.vecPIDs.end(); it++)

{

LPCHARACTER ch = CHARACTER_MANAGER::instance().FindByPID(*it);

if (ch)

ch->ComputeSkill(dwVnum, ch);

}

 

then ,delete if(ch), done.

in char_skill.cpp

i have this:

 

    else if (IS_SET(pkSk->dwFlag, SKILL_FLAG_PARTY) && GetParty())
    {
        FPartyPIDCollector f;
        GetParty()->ForEachOnMapMember(f, GetMapIndex());
        for (std::vector <DWORD>::iterator it = f.vecPIDs.begin(); it != f.vecPIDs.end(); it++)
        {
            LPCHARACTER ch = CHARACTER_MANAGER::instance().FindByPID(*it);
            if (ch)
                ch->ComputeSkill(dwVnum, ch);
        }
    }

 

make to this;

Spoiler

    else if (IS_SET(pkSk->dwFlag, SKILL_FLAG_PARTY) && GetParty())
    {
        FPartyPIDCollector f;
        GetParty()->ForEachOnMapMember(f, GetMapIndex());
        for (std::vector <DWORD>::iterator it = f.vecPIDs.begin(); it != f.vecPIDs.end(); it++)
        {
            LPCHARACTER ch = CHARACTER_MANAGER::instance().FindByPID(*it);
            if
                ch->ComputeSkill(dwVnum, ch);
        }
    }

 

 

[Cyxer 167]

i test this:

else if (IS_SET(pkSk->dwFlag, SKILL_FLAG_PARTY) && GetParty())
    {
        FPartyPIDCollector f;
        GetParty()->ForEachOnMapMember(f, GetMapIndex());
        for (std::vector <DWORD>::iterator it = f.vecPIDs.begin(); it != f.vecPIDs.end(); it++)
        {
            LPCHARACTER ch = CHARACTER_MANAGER::instance().FindByPID(*it);
                ch->ComputeSkill(dwVnum, ch);
        }
    }

and the problem not fix!

[Cyxer 167]

up

[z35 231]

char_skill.cpp

    if (IS_SET(pkSk->dwFlag, SKILL_FLAG_SELFONLY))
        ComputeSkill(dwVnum, this);
    else if (IS_SET(pkSk->dwFlag, SKILL_FLAG_PARTY) && !GetParty())ComputeSkill(dwVnum, this);
    else if (IS_SET(pkSk->dwFlag, SKILL_FLAG_PARTY) && GetParty())
    {
        FPartyPIDCollector f;
        GetParty()->ForEachOnMapMember(f, GetMapIndex());
        for (std::vector <DWORD>::iterator it = f.vecPIDs.begin(); it != f.vecPIDs.end(); it++)
        {
            LPCHARACTER ch = CHARACTER_MANAGER::instance().FindByPID(*it);
            ComputeSkill(dwVnum, ch);
        }
    }

[Cyxer 167]

1 minute ago, z35 said:

char_skill.cpp

    if (IS_SET(pkSk->dwFlag, SKILL_FLAG_SELFONLY))
        ComputeSkill(dwVnum, this);
    else if (IS_SET(pkSk->dwFlag, SKILL_FLAG_PARTY) && !GetParty())ComputeSkill(dwVnum, this);
    else if (IS_SET(pkSk->dwFlag, SKILL_FLAG_PARTY) && GetParty())
    {
        FPartyPIDCollector f;
        GetParty()->ForEachOnMapMember(f, GetMapIndex());
        for (std::vector <DWORD>::iterator it = f.vecPIDs.begin(); it != f.vecPIDs.end(); it++)
        {
            LPCHARACTER ch = CHARACTER_MANAGER::instance().FindByPID(*it);
            ComputeSkill(dwVnum, ch);
        }
    }

i check later :)