Prevent hitting private shops

[dreammaker 3]

char_battle.cpp:
bool CHARACTER::Attack(LPCHARACTER pkVictim, BYTE bType)

    if (pkVictim->GetShopOwner())
        return false;

I added this code to prevent hitting private shops.But it doenst work.I can still hit and kill players shops .What is wrong ?

[Cataclismo 88]

GetShopOwner() will return the owner of the current shop opened.

Use this:

if (pkVictim->GetMyShop())
    return false;

 

[dreammaker 3]

GetShopOwner() will return the owner of the current shop opened.

Use this:

if (pkVictim->GetMyShop())
    return false;

 

Thank you very much Cataclismo It really worked.I wish I know C++. It is hard to learn for beginners

[ruiskyo1 1]

Its not about knowing c++ or not, its about knowing the functions and how they work... in 1 weak you learn basic level c++(variables, funtions, etc)

[dreammaker 3]

if (pkVictim->GetMyShop())
    return false;

This code worked but some weird thing happened.It prevents straight hits but doesnt prevent some skills like: warriors dash and sura's remove magic

What can be the problem ? Thanks.

[Cataclismo 88]

Well...

Open battle.cpp and find

bool battle_is_attackable(LPCHARACTER ch, LPCHARACTER victim)

And after

	if (victim->IsDead())
		return false;

Add:

	if (victim->GetMyShop())
		return false;

 

Tell me if that works.

[dreammaker 3]

Thank you very much Cataclismo I tried and It worked like a charm