[GAME]Warnings over warnings

[florinrevine 1]

Hello devs, I'm more than noob in C++ and I try to clean my source code (based mainline_released).

 

If anyone know how to solve some bugs please write here, thanks.

char.cpp:7221: warning: this decimal constant is unsigned only in ISO C90
In file included from char_item.cpp:47:
belt_inventory_helper.h: In static member function 'static BYTE CBeltInventoryHelper::GetBeltGradeByRefineLevel(int)':
belt_inventory_helper.h:28: warning: comparison between signed and unsigned integer expressions
char_item.cpp: In member function 'bool CHARACTER::IsEmptyItemGrid(TItemPos, BYTE, int) const':
char_item.cpp:640: warning: comparison is always false due to limited range of data type
char_item.cpp:666: warning: comparison is always false due to limited range of data type
PetSystem.cpp: In member function 'virtual bool CPetActor::_UpdateFollowAI()':
PetSystem.cpp:246: warning: unused variable 'bDoMoveAlone'
PetSystem.cpp: In member function 'CPetActor* CPetSystem::Summon(DWORD, CItem*, const char*, bool, DWORD)':
PetSystem.cpp:552: warning: unused variable 'petVID'
char_item.cpp: In member function 'bool CHARACTER::UseItemEx(CItem*, TItemPos)':
char_item.cpp:2387: warning: format '%d' expects type 'int', but argument 6 has type 'long int'
char_item.cpp:2391: warning: format '%d' expects type 'int', but argument 6 has type 'long int'
char_item.cpp:2403: warning: format '%d' expects type 'int', but argument 5 has type 'long int'
char_item.cpp:2407: warning: format '%d' expects type 'int', but argument 5 has type 'long int'
char_item.cpp:2434: warning: format '%d' expects type 'int', but argument 6 has type 'long int'
char_item.cpp:2442: warning: format '%d' expects type 'int', but argument 5 has type 'long int'
char_item.cpp:5098: warning: comparison between signed and unsigned integer expressions
char_item.cpp: In member function 'bool CHARACTER::UseItem(TItemPos, TItemPos)':
char_item.cpp:5170: warning: unused variable 'wDestCell'
char_item.cpp:5171: warning: unused variable 'bDestInven'
constants.cpp:183: warning: this decimal constant is unsigned only in ISO C90
constants.cpp:185: warning: this decimal constant is unsigned only in ISO C90
constants.cpp:186: warning: this decimal constant is unsigned only in ISO C90
constants.cpp:187: warning: this decimal constant is unsigned only in ISO C90
constants.cpp:188: warning: this decimal constant is unsigned only in ISO C90
constants.cpp:189: warning: this decimal constant is unsigned only in ISO C90
constants.cpp:314: warning: this decimal constant is unsigned only in ISO C90
constants.cpp:316: warning: this decimal constant is unsigned only in ISO C90
constants.cpp:317: warning: this decimal constant is unsigned only in ISO C90
constants.cpp:318: warning: this decimal constant is unsigned only in ISO C90
constants.cpp:319: warning: this decimal constant is unsigned only in ISO C90
constants.cpp:320: warning: this decimal constant is unsigned only in ISO C90
constants.cpp:445: warning: this decimal constant is unsigned only in ISO C90
constants.cpp:447: warning: this decimal constant is unsigned only in ISO C90
constants.cpp:448: warning: this decimal constant is unsigned only in ISO C90
constants.cpp:449: warning: this decimal constant is unsigned only in ISO C90
constants.cpp:450: warning: this decimal constant is unsigned only in ISO C90
constants.cpp:451: warning: this decimal constant is unsigned only in ISO C90
char_item.cpp: In member function 'bool CHARACTER::EquipItem(CItem*, int)':
char_item.cpp:6130: warning: array subscript has type 'char'
char_item.cpp: In member function 'void CHARACTER::BuffOnAttr_AddBuffsFromItem(CItem*)':
char_item.cpp:6194: warning: comparison between signed and unsigned integer expressions
char_item.cpp: In member function 'void CHARACTER::BuffOnAttr_RemoveBuffsFromItem(CItem*)':
char_item.cpp:6206: warning: comparison between signed and unsigned integer expressions
char_item.cpp: In member function 'bool CHARACTER::CanEquipNow(CItem*, const TItemPos&, const TItemPos&)':
char_item.cpp:7392: warning: unused variable 'itemType'
char_item.cpp:7393: warning: unused variable 'itemSubType'
char.cpp: In member function 'void CHARACTER::PointChange(BYTE, int, bool, bool)':
char.cpp:3092: warning: comparison between signed and unsigned integer expressions
char_item.cpp: In member function 'bool CHARACTER::IsEmptyItemGrid(TItemPos, BYTE, int) const':
char_item.cpp:679: warning: control reaches end of non-void function
char_state.cpp: In member function 'virtual void CHARACTER::StateMove()':
char_state.cpp:901: warning: unused variable 'rider'
cube.cpp: In function 'bool Cube_make(CHARACTER*)':
cube.cpp:544: warning: comparison between signed and unsigned integer expressions
cube.cpp: In function 'void Cube_MakeCubeInformationText()':
cube.cpp:716: warning: unused variable 'npcVNUM'
cube.cpp: In function 'bool Cube_InformationInitialize()':
cube.cpp:783: warning: comparison between signed and unsigned integer expressions
In file included from config.cpp:22:
check_server.h: In static member function 'static bool CheckServer::CheckIp(const char*)':
check_server.h:24: warning: comparison between signed and unsigned integer expressions
config.cpp: In function 'void config_init(const std::string&)':
config.cpp:434: warning: NULL used in arithmetic
config.cpp:458: warning: NULL used in arithmetic
config.cpp:482: warning: NULL used in arithmetic
config.cpp:504: warning: unused variable 'line'
cmd_gm.cpp: In function 'void do_set_stat(CHARACTER*, const char*, int, int)':
cmd_gm.cpp:3997: warning: NULL used in arithmetic
desc_client.cpp: In member function 'void CLIENT_DESC::UpdateChannelStatus(DWORD, bool)':
desc_client.cpp:299: warning: comparison between signed and unsigned integer expressions
char_item.cpp: In member function 'void CHARACTER::BuffOnAttr_ValueChange(BYTE, BYTE, BYTE)':
char_item.cpp:6241: warning: 'pBuff' may be used uninitialized in this function
cmd_gm.cpp: In function 'void do_use_item(CHARACTER*, const char*, int, int)':
cmd_gm.cpp:4419: warning: 'cell' may be used uninitialized in this function
cmd_gm.cpp: In function 'void do_set_stat(CHARACTER*, const char*, int, int)':
cmd_gm.cpp:4039: warning: 'n' may be used uninitialized in this function
cmd_gm.cpp: In function 'void do_mob_ld(CHARACTER*, const char*, int, int)':
cmd_gm.cpp:855: warning: 'x' may be used uninitialized in this function
cmd_gm.cpp:855: warning: 'y' may be used uninitialized in this function
input_auth.cpp: In member function 'int CInputAuth::auth_OpenID(const char*, const char*, char*)':
input_auth.cpp:467: warning: unused variable 'last'
In file included from item.cpp:22:
belt_inventory_helper.h: In static member function 'static BYTE CBeltInventoryHelper::GetBeltGradeByRefineLevel(int)':
belt_inventory_helper.h:28: warning: comparison between signed and unsigned integer expressions
item.h: In constructor 'CItem::CItem(DWORD)':
item.h:286: warning: 'CItem::m_pkRealTimeExpireEvent' will be initialized after
item.h:283: warning:   'LPEVENT CItem::m_pkExpireEvent'
item.cpp:25: warning:   when initialized here
item.cpp: In function 'const bool CanPutIntoRing(CItem*, CItem*)':
item.cpp:1739: warning: unused variable 'vnum'
item.cpp: In member function 'bool CItem::CanPutInto(CItem*)':
item.cpp:1772: warning: comparison between signed and unsigned integer expressions
item.cpp: In member function 'int CItem::GiveMoreTime_Per(float)':
item.cpp:2028: warning: comparison between signed and unsigned integer expressions
item.cpp:2030: warning: comparison between signed and unsigned integer expressions
item.cpp: In member function 'int CItem::GiveMoreTime_Fix(DWORD)':
item.cpp:2052: warning: comparison between signed and unsigned integer expressions
item.cpp: In member function 'int CItem::GetDuration()':
item.cpp:2083: warning: array subscript has type 'char'
input_main.cpp: In member function 'int CInputMain::Chat(CHARACTER*, const char*, size_t)':
input_main.cpp:757: warning: unused variable 'len_global'
item_manager.cpp: In member function 'TItemTable* ITEM_MANAGER::GetTable(DWORD)':
item_manager.cpp:604: warning: comparison between signed and unsigned integer expressions
log.cpp:11: warning: '__escape_hint' defined but not used
questlua.cpp: In member function 'bool quest::FPartyCheckFlagLt::operator()(CHARACTER*)':
questlua.cpp:78: warning: 'returnBool' may be used uninitialized in this function
questlua_npc.cpp: In function 'int quest::npc_get_vid_attack_mul(lua_State*)':
questlua_npc.cpp:293: warning: unused variable 'q'
questlua_npc.cpp: In function 'int quest::npc_set_vid_attack_mul(lua_State*)':
questlua_npc.cpp:309: warning: unused variable 'q'
questlua_npc.cpp: In function 'int quest::npc_get_vid_damage_mul(lua_State*)':
questlua_npc.cpp:324: warning: unused variable 'q'
questlua_npc.cpp: In function 'int quest::npc_set_vid_damage_mul(lua_State*)':
questlua_npc.cpp:340: warning: unused variable 'q'
questnpc.cpp: In member function 'bool quest::NPC::HandleEvent(quest::PC&, int)':
questnpc.cpp:500: warning: unused variable 'pPC'
utils.cpp: In function 'bool WildCaseCmp(const char*, const char*)':
utils.cpp:243: warning: NULL used in arithmetic
utils.cpp:255: warning: NULL used in arithmetic
utils.cpp:269: warning: NULL used in arithmetic
shop.cpp: In member function 'virtual bool CShop::IsSellingItem(DWORD)':
shop.cpp:576: warning: comparison between signed and unsigned integer expressions
In file included from check_server.cpp:1:
check_server.h: In static member function 'static bool CheckServer::CheckIp(const char*)':
check_server.h:24: warning: comparison between signed and unsigned integer expressions
group_text_parse_tree.h: In constructor 'CGroupTextParseTreeLoader::CGroupTextParseTreeLoader()':
group_text_parse_tree.h:93: warning: 'CGroupTextParseTreeLoader::m_dwcurLineIndex' will be initialized after
group_text_parse_tree.h:91: warning:   'CGroupNode* CGroupTextParseTreeLoader::m_pRootGroupNode'
group_text_parse_tree.cpp:5: warning:   when initialized here
group_text_parse_tree.cpp: In member function 'bool CGroupTextParseTreeLoader::LoadGroup(CGroupNode*)':
group_text_parse_tree.cpp:99: warning: comparison between signed and unsigned integer expressions
group_text_parse_tree.cpp: In member function 'bool CGroupNode::GetRow(int, const CGroupNode::CGroupNodeRow**) const':
group_text_parse_tree.cpp:206: warning: comparison between signed and unsigned integer expressions
ClientPackageCryptInfo.h: In constructor 'CClientPackageCryptInfo::CClientPackageCryptInfo()':
ClientPackageCryptInfo.h:50: warning: 'CClientPackageCryptInfo::m_pSerializedCryptKeyStream' will be initialized after
ClientPackageCryptInfo.h:48: warning:   'int CClientPackageCryptInfo::m_nCryptKeyPackageCnt'
ClientPackageCryptInfo.cpp:9: warning:   when initialized here
dragon_soul_table.cpp: In member function 'bool DragonSoulTable::ReadAdditionalApplys()':
dragon_soul_table.cpp:223: warning: comparison between signed and unsigned integer expressions
dragon_soul_table.cpp: In member function 'bool DragonSoulTable::CheckApplyNumSettings()':
dragon_soul_table.cpp:283: warning: comparison between signed and unsigned integer expressions
dragon_soul_table.cpp: In member function 'bool DragonSoulTable::CheckWeightTables()':
dragon_soul_table.cpp:311: warning: comparison between signed and unsigned integer expressions
dragon_soul_table.cpp: In member function 'bool DragonSoulTable::CheckRefineGradeTables()':
dragon_soul_table.cpp:343: warning: comparison between signed and unsigned integer expressions
dragon_soul_table.cpp:372: warning: comparison between signed and unsigned integer expressions
dragon_soul_table.cpp: In member function 'bool DragonSoulTable::CheckRefineStepTables()':
dragon_soul_table.cpp:397: warning: comparison between signed and unsigned integer expressions
dragon_soul_table.cpp:427: warning: comparison between signed and unsigned integer expressions
dragon_soul_table.cpp: In member function 'bool DragonSoulTable::CheckRefineStrengthTables()':
dragon_soul_table.cpp:453: warning: comparison between signed and unsigned integer expressions
dragon_soul_table.cpp: In member function 'bool DragonSoulTable::CheckDragonHeartExtTables()':
dragon_soul_table.cpp:494: warning: comparison between signed and unsigned integer expressions
dragon_soul_table.cpp:513: warning: comparison between signed and unsigned integer expressions
dragon_soul_table.cpp:522: warning: comparison between signed and unsigned integer expressions
dragon_soul_table.cpp: In member function 'bool DragonSoulTable::CheckDragonSoulExtTables()':
dragon_soul_table.cpp:545: warning: comparison between signed and unsigned integer expressions
group_text_parse_tree.h: In member function 'bool CGroupNode::CGroupNodeRow::GetValue(const std::string&, T&) const [with T = std::string]':
dragon_soul_table.cpp:129:   instantiated from here
group_text_parse_tree.h:220: warning: comparison between signed and unsigned integer expressions
group_text_parse_tree.h: In member function 'bool CGroupNode::CGroupNodeRow::GetValue(const std::string&, T&) const [with T = BYTE]':
dragon_soul_table.cpp:134:   instantiated from here
group_text_parse_tree.h:220: warning: comparison between signed and unsigned integer expressions
group_text_parse_tree.h: In member function 'bool CGroupNode::CGroupNodeRow::GetValue(const std::string&, T&) const [with T = int]':
dragon_soul_table.cpp:201:   instantiated from here
group_text_parse_tree.h:220: warning: comparison between signed and unsigned integer expressions
group_text_parse_tree.h: In member function 'bool CGroupNode::CGroupNodeRow::GetValue(const std::string&, T&) const [with T = float]':
dragon_soul_table.cpp:260:   instantiated from here
group_text_parse_tree.h:220: warning: comparison between signed and unsigned integer expressions
group_text_parse_tree.h: In member function 'bool CGroupNode::CGroupNodeRow::GetValue(int, T&) const [with T = float]':
dragon_soul_table.cpp:828:   instantiated from here
group_text_parse_tree.h:228: warning: comparison between signed and unsigned integer expressions
group_text_parse_tree.h: In member function 'bool CGroupNode::CGroupNodeRow::GetValue(int, T&) const [with T = int]':
group_text_parse_tree.h:159:   instantiated from 'bool CGroupNode::GetValue(const std::string&, const std::string&, T&) const [with T = int]'
group_text_parse_tree.h:203:   instantiated from 'bool CGroupNode::GetGroupValue(const std::string&, const std::string&, const std::string&, T&) const [with T = int]'
dragon_soul_table.cpp:612:   instantiated from here
group_text_parse_tree.h:228: warning: comparison between signed and unsigned integer expressions
group_text_parse_tree.h: In member function 'bool CGroupNode::CGroupNodeRow::GetValue(int, T&) const [with T = unsigned int]':
group_text_parse_tree.h:159:   instantiated from 'bool CGroupNode::GetValue(const std::string&, const std::string&, T&) const [with T = unsigned int]'
group_text_parse_tree.h:203:   instantiated from 'bool CGroupNode::GetGroupValue(const std::string&, const std::string&, const std::string&, T&) const [with T = unsigned int]'
dragon_soul_table.cpp:884:   instantiated from here
group_text_parse_tree.h:228: warning: comparison between signed and unsigned integer expressions
buff_on_attributes.cpp: In member function 'void CBuffOnAttributes::ChangeBuffValue(BYTE)':
buff_on_attributes.cpp:113: warning: unused variable 'old_value'
buff_on_attributes.cpp:114: warning: unused variable 'new_value'
char_dragonsoul.cpp: In member function 'bool CHARACTER::DragonSoul_ActivateDeck(int)':
char_dragonsoul.cpp:91: warning: control reaches end of non-void function
DragonSoul.cpp: In function 'int Gamble(std::vector<float, std::allocator<float> >&)':
DragonSoul.cpp:19: warning: comparison between signed and unsigned integer expressions
DragonSoul.cpp:25: warning: comparison between signed and unsigned integer expressions
DragonSoul.cpp: In member function 'bool DSManager::RefreshItemAttributes(CItem*)':
DragonSoul.cpp:203: warning: comparison between signed and unsigned integer expressions
DragonSoul.cpp: In member function 'bool DSManager::PutAttributes(CItem*)':
DragonSoul.cpp:273: warning: comparison between signed and unsigned integer expressions
DragonSoul.cpp: In member function 'bool DSManager::ExtractDragonHeart(CHARACTER*, CItem*, CItem*)':
DragonSoul.cpp:350: warning: unused variable 'sum'
DragonSoul.cpp: In member function 'bool DSManager::PullOut(CHARACTER*, TItemPos, CItem*&, CItem*)':
DragonSoul.cpp:435: warning: unused variable 'dwVnum'
DragonSoul.cpp:469: warning: format '%d' expects type 'int', but argument 3 has type 'double'
DragonSoul.cpp:469: warning: format '%d' expects type 'int', but argument 4 has type 'double'
DragonSoul.cpp: In member function 'bool DSManager::DoRefineGrade(CHARACTER*, TItemPos (&)[15])':
DragonSoul.cpp:555: warning: unused variable 'prob_sum'
DragonSoul.cpp: In member function 'bool DSManager::DoRefineStep(CHARACTER*, TItemPos (&)[15])':
DragonSoul.cpp:763: warning: unused variable 'sum'
item_manager_read_tables.cpp: In member function 'bool ITEM_MANAGER::ReadMonsterDropItemGroup(const char*)':
item_manager_read_tables.cpp:637: warning: unused variable 'pkGroup'
shopEx.cpp: In member function 'virtual int CShopEx::Buy(CHARACTER*, BYTE)':
shopEx.cpp:159: warning: comparison between signed and unsigned integer expressions
shop_manager.cpp: In function 'bool ConvertToShopItemTable(CGroupNode*, TShopTableEx&)':
shop_manager.cpp:473: warning: comparison between signed and unsigned integer expressions
group_text_parse_tree.h: In member function 'bool CGroupNode::CGroupNodeRow::GetValue(int, T&) const [with T = unsigned int]':
group_text_parse_tree.h:175:   instantiated from 'bool CGroupNode::GetValue(const std::string&, int, T&) const [with T = DWORD]'
shop_manager.cpp:381:   instantiated from here
group_text_parse_tree.h:228: warning: comparison between signed and unsigned integer expressions
group_text_parse_tree.h: In member function 'bool CGroupNode::CGroupNodeRow::GetValue(int, T&) const [with T = std::basic_string<char, std::char_traits<char>, std::allocator<char> >]':
group_text_parse_tree.h:175:   instantiated from 'bool CGroupNode::GetValue(const std::string&, int, T&) const [with T = std::string]'
shop_manager.cpp:387:   instantiated from here
group_text_parse_tree.h:228: warning: comparison between signed and unsigned integer expressions
group_text_parse_tree.h: In member function 'bool CGroupNode::CGroupNodeRow::GetValue(int, T&) const [with T = unsigned char]':
group_text_parse_tree.h:136:   instantiated from 'bool CGroupNode::GetValue(size_t, const std::string&, T&) const [with T = BYTE]'
shop_manager.cpp:442:   instantiated from here
group_text_parse_tree.h:228: warning: comparison between signed and unsigned integer expressions
In file included from main.cpp:93:
check_server.h: In static member function 'static bool CheckServer::CheckIp(const char*)':
check_server.h:24: warning: comparison between signed and unsigned integer expressions
item_manager_read_tables.cpp:627: warning: 'pkGroup' may be used uninitialized in this function

[Benhero 23]

To fix it Learn C++.

Than read and unterstand the Error/Warning and Fix it.

 

Greatz

[Night 366]

you can always search on how to fix such errors on google

[JachuPL 308]

unused variable X - delete line with variable X, it's not necessary in code

comparison between... - find that line and change the types of variables to be the same. Remember, if you destroy something it's better to have backup.

for more errors/warnings you have two ways:

1) Learn 2 code. It's really simple, you just have to use your brain

2) google it and see how it works