Character death event

[Lupetto 48]

Is there a way to make a function to do this in quests?
 

when (player_die) begin
   -- Stuff to do when player_die event is triggered
end

lot of people say me to use a timer and to check pc.is_death, but i think this is not a correct solution..

Hope someone can help me

Thanks,

Lup.

[Syron 376]

when kill begin
if npc.is_pc() and npc.empire != pc.empire then

etc etc

 

 

Use npc.is_pc() and npc.empire != pc.empire , so the player that gets killed need to be from another kingdom.

[Lupetto 48]

when kill begin  is triggered when you kill another player.

 

I need to handle my character death

[Syron 376]

Then, use

function dead
pc.get_hp <= 0
end

[Lupetto 48]

already exist a functions called pc.is_death, i have to check it every X seconds with a timer..

I Think working on game source we can make a better solution that trigger "death" event automatically so in quest we can use

 

when die begin
  -- Some stuff
End

[Lupetto 48]

Up

[Zonni 281]

questmanager.cpp

- in bool CQuestManager::Initialize() add

m_mapEventName.insert(TEventNameMap::value_type("dead", QUEST_DEAD_EVENT));

 

- add

void CQuestManager::Dead(unsigned int pc, unsigned int npc)

{

PC * pPC;

 

sys_log(0, "CQuestManager::OnDead QUEST_DEAD_EVENT (pc=%d, npc=%d)", pc, npc);

 

if ((pPC = GetPC(pc)))

{

if (!CheckQuestLoaded(pPC))

return;

m_mapNPC[npc].OnDead(*pPC);

 

if (m_mapNPC[QUEST_NO_NPC].OnDead(*pPC))

return;

}

else

sys_err("QUEST: no such pc id : %d", pc);

}

 

quest.h

[second enum] (add after QUEST_ITEM_INFORMER_EVENT,)

QUEST_DEAD_EVENT,

 

questnpc.h

bool NPC::OnDead(PC & pc)

{

if (m_vnum)

return HandleEvent(pc, QUEST_DEAD_EVENT);

else

return HandleReceiveAllEvent(pc, QUEST_DEAD_EVENT);

}

 

char_battle.cpp

in CHARACTER::Dead add

if(pkKiller && IsPC()) {

pkKiller->SetQuestNPCID(GetVID());

quest::CQuestManager::instance().Dead(GetPlayerID(), pkKiller->GetPlayerID());

}

 

 

sorry for format but it should work if you add missing functions in .h files

 

btw. that's not my work, anyway it's really easy to create events like this.

[Lupetto 48]

Thanks for you help Zonni, i have just a little problem:

The event is triggeret 2 times, i try to explain better:

when dead begin
	syschat("You are death.")
end

I will get the text "You are death" 2 times.

 

Any ideas about?

 

In the code you give to me i dont understand this part : 

m_mapNPC[npc].OnDead(*pPC);
		 
if (m_mapNPC[QUEST_NO_NPC].OnDead(*pPC))
	return;

[Pepineitor 127]

You could do it with npc.get_vid()

quest dead begin
	state start begin
		when kill with npc.is_pc() begin
			local vid = npc.get_vid()
			local old_pc = pc.select(vid)
			if old_pc != 0 then
				chat("You die")
				pc.select(old_pc)
			end
		end
	end
end

[Lupetto 48]

 

You could do it with npc.get_vid()

quest dead begin
	state start begin
		when kill with npc.is_pc() begin
			local vid = npc.get_vid()
			local old_pc = pc.select(vid)
			if old_pc != 0 then
				chat("You die")
				pc.select(old_pc)
			end
		end
	end
end

I Think this is not correct, the quest name is "dead" but you use the kill event..

All writed by Zonni is working good, but there is a bug, that the event "dead" is called two times, maybe is the same bug as "kill" counted twiche, i'll investigate on it and let you know

[Zonni 281]

I just recompiled whole source & quest and this works without any problem ^^

 

btw. i think you should correct your tabs (sorry, i know i give to you badly format of code but i haven't so much time to correct whitespaces)

 

	void CQuestManager::Dead(unsigned int pc, unsigned int npc)
	{
		PC * pPC;

		sys_log(0, "CQuestManager::OnDead QUEST_DEAD_EVENT (pc=%d, npc=%d)", pc, npc);

		if ((pPC = GetPC(pc)))
		{
			if (!CheckQuestLoaded(pPC))
				return;
			m_mapNPC[npc].OnDead(*pPC);

			if (m_mapNPC[QUEST_NO_NPC].OnDead(*pPC))
				return;
		}
		else
			sys_err("QUEST: no such pc id : %d", pc);
	}

should work.

[Lupetto 48]

I just recompiled whole source & quest and this works without any problem ^^

 

btw. i think you should correct your tabs (sorry, i know i give to you badly format of code but i haven't so much time to correct whitespaces)

 

	void CQuestManager::Dead(unsigned int pc, unsigned int npc)
	{
		PC * pPC;

		sys_log(0, "CQuestManager::OnDead QUEST_DEAD_EVENT (pc=%d, npc=%d)", pc, npc);

		if ((pPC = GetPC(pc)))
		{
			if (!CheckQuestLoaded(pPC))
				return;
			m_mapNPC[npc].OnDead(*pPC);

			if (m_mapNPC[QUEST_NO_NPC].OnDead(*pPC))
				return;
		}
		else
			sys_err("QUEST: no such pc id : %d", pc);
	}

should work.

 

 

I have the problem explained with your code and i fixed it using this :

	void CQuestManager::Dead(unsigned int pc, unsigned int npc)
	{
		PC * pPC;
		sys_log(0, "CQuestManager::OnDead QUEST_DEAD_EVENT (pc=%d, npc=%d)", pc, npc);
		if (pPC = GetPC(pc))
		{
			if (!CheckQuestLoaded(pPC))
				return;

			if(npc > 0)
				m_mapNPC[npc].OnDead(*pPC);
			
			if (m_mapNPC[QUEST_NO_NPC].OnDead(*pPC))
				return;
		}
		else
			sys_err("QUEST: no such pc id : %d", pc);
	}

Anyway i really thank you for your reply on a my request and now i have learned something new

Thank 's you again,

Lup.

[Minion 84]

http://metin2dev.org/board/topic/2629-cdead-event/

[berk 1]

i cant find  missing references :/

i think its on questmanager.h  right ?

like this 

void  dead(unsigned int pc, unsigned int npc)