ApplyAddonTo Upgrade

[TheAdmin33 38]

The average damage and skill damage ratios are calculated in this function. I’ve updated the code to make it more up to date. You don’t have to implement this update; it’s just something I did out of boredom and wanted to share. It’s up to you whether you add it or not.

item_addon.cpp;

#include "stdafx.h"
#include "constants.h"
#include "utils.h"
#include "item.h"
#include "item_addon.h"
#include <random>
#include <cmath>

CItemAddonManager::CItemAddonManager()
{
}

CItemAddonManager::~CItemAddonManager()
{
}

void CItemAddonManager::ApplyAddonTo(int iAddonType, LPITEM pItem)
{
    if (!pItem)
    {
        sys_err("ApplyAddonTo: item pointer null");
        return;
    }

    std::random_device rd;
    std::mt19937 gen(rd());

    std::normal_distribution<> gauss_dist(0.0, 5.0);
    int iSkillBonus = MINMAX(-30, static_cast<int>(std::round(gauss_dist(gen))), 30);

    int iNormalHitBonus = 0;

    if (std::abs(iSkillBonus) <= 20)
    {
        std::uniform_int_distribution<> dist_8_8(-8, 8);
        std::uniform_int_distribution<> dist_1_4(1, 4);

        iNormalHitBonus = -2 * iSkillBonus + std::abs(dist_8_8(gen) + dist_8_8(gen)) + dist_1_4(gen);
    }
    else
    {
        std::uniform_int_distribution<> dist_1_5(1, 5);

        iNormalHitBonus = -2 * iSkillBonus + dist_1_5(gen);
    }

    pItem->RemoveAttributeType(APPLY_SKILL_DAMAGE_BONUS);
    pItem->RemoveAttributeType(APPLY_NORMAL_HIT_DAMAGE_BONUS);
    pItem->AddAttribute(APPLY_NORMAL_HIT_DAMAGE_BONUS, iNormalHitBonus);
    pItem->AddAttribute(APPLY_SKILL_DAMAGE_BONUS, iSkillBonus);
}

 

[MariusExygo 1481]

This uniform random has disappointed me over time, the effects were too bad, too much harder, best way is ymir original random, and many successful pservers have been using the ymir random.
Even if the ymir random sometimes give weird tendencies.

For example :
- if you upgrade items and you get successfull upgrades in a row, or getting failed upgrades in a row.
- You turn on the server and Azrael (2598) gives bigger damages at the beginning (for some hours maybe), like giving you insta kill due to different tendencies in the random of the deathblow damage.