Problem after implementation GM Affects

[Raczek136 11]

Hi, after the implementation a GM Affects System (no via name) i have a problem with not matched effects than GM level. 

Actually in all my players (Implementor, God, High and low wizard) i have a one effect for Game Admin (HIGH_WIZARD effect) and (my experiment) GM Prefix.

When i change a effect number in playersettingsmodules.py i have a another effect but prefix is not changed (logical). 

Serverfiles - Martysama v5.8

SVN:

1. https://pastebin.com/ZVzFJ1bt - Char.cpp (void CHARACTER::SetPlayerProto(const TPlayerTable * t))
2. https://pastebin.com/BwVuNNFv - Affect.h

Client:

• https://pastebin.com/GULxSdLL - InstanceBase.h
• https://pastebin.com/nrUttVtZ - InstanceBaseEffect.cpp (void CInstanceBase::__SetAffect and void CInstanceBase::UpdateTextTailLevel(DWORD level)
• https://pastebin.com/AS9qfy3r - InstanceBase.cpp (BOOL CInstanceBase::IsGameMaster())

Does anyone have experience of this and how to resolve it?

 

[Lycawn 1275]

On 8/25/2024 at 7:44 PM, Raczek136 said:

Hi, after the implementation a GM Affects System (no via name) i have a problem with not matched effects than GM level. 

Actually in all my players (Implementor, God, High and low wizard) i have a one effect for Game Admin (HIGH_WIZARD effect) and (my experiment) GM Prefix.

When i change a effect number in playersettingsmodules.py i have a another effect but prefix is not changed (logical). 

Serverfiles - Martysama v5.8

SVN:

1. https://pastebin.com/ZVzFJ1bt - Char.cpp (void CHARACTER::SetPlayerProto(const TPlayerTable * t))
2. https://pastebin.com/BwVuNNFv - Affect.h

Client:

• https://pastebin.com/GULxSdLL - InstanceBase.h
• https://pastebin.com/nrUttVtZ - InstanceBaseEffect.cpp (void CInstanceBase::__SetAffect and void CInstanceBase::UpdateTextTailLevel(DWORD level)
• https://pastebin.com/AS9qfy3r - InstanceBase.cpp (BOOL CInstanceBase::IsGameMaster())

Does anyone have experience of this and how to resolve it?

 

Can you explain your problem again please ?

[Raczek136 11]

Hello @ Lycawn thank you for your reply.

Before the steps I took, I used this: 

1. I added in source affect:

AFFECT_YMIR_IMPLEMENTOR
AFFECT_YMIR_HIGH_WIZARD
AFFECT_YMIR_GOD
AFFECT_YMIR_LOW_WIZARD

1. In the client source I modified the IsGameMaster function by adding these affects.
2. I added in the UpdateTextTailLevel function a modification adding prefixes relative to the affections.

The effect of this is that I have AFFECT_YMIR_HIGH_WIZARD on every affect under a specific number, and I don't have the variety I ultimately wanted to have. 

On the other functions (I have separate characters per specific GM Level the same effect is there, on this character I have IMPLEMENTOR).  here is a screenshot: 

Above you have a pastebin links to functions in svn and bin.

 

[Lycawn 1275]

3 hours ago, Raczek136 said:

Hello @ Lycawn thank you for your reply.

Before the steps I took, I used this: 

1. I added in source affect:

AFFECT_YMIR_IMPLEMENTOR
AFFECT_YMIR_HIGH_WIZARD
AFFECT_YMIR_GOD
AFFECT_YMIR_LOW_WIZARD

1. In the client source I modified the IsGameMaster function by adding these affects.
2. I added in the UpdateTextTailLevel function a modification adding prefixes relative to the affections.

The effect of this is that I have AFFECT_YMIR_HIGH_WIZARD on every affect under a specific number, and I don't have the variety I ultimately wanted to have. 

On the other functions (I have separate characters per specific GM Level the same effect is there, on this character I have IMPLEMENTOR).  here is a screenshot: 

Above you have a pastebin links to functions in svn and bin.

 

Maybe you would want to try something like this 
 

 

[Raczek136 11]

@ Lycawn I tried, but affects in this resource not working - it is same effect without my edit with prefix

I thing it is a problem with numbers of affects but i don't know. 

Edited August 30, 2024 by Raczek136

[Lycawn 1275]

39 minutes ago, Raczek136 said:

@ Lycawn I tried, but affects in this resource not working - it is same effect without my edit with prefix

I thing it is a problem with numbers of affects but i don't know. 

Try this with a different Effect not ridack's

[Raczek136 11]

Sorry, I didn't add it!
I didn't use Ridack's effects, just these: 

https://metin2.dev/topic/32286-free-team-ranks-by-ashikaarts/

The problem is also that on affect_implementor for the example there should be a prefix [W] not [AG], [AG] should be on AFFECT_HIGH_WIZARD

So I think it's not an effects issue just more something on affect.h or InstanceBaseEffect.cpp, just can't figure out the cause.

Edited August 30, 2024 by Raczek136

[Psycho 215]

 

I had to make a lot of changes to make them visible, check the python file carefully and make sure that the client source is the same as the server source based on the number of affects.