If close the refine window, cannot open it again

[Ulthar 2790]

Hello!

Spoiler

I litteraly want to cry. Im about to give up my project, i cannot do anything about it.

I need your help, guys. When i want to upgrade an item, but i close the refine window, i cannot move items, cannot drop/destroy/sell those items. After relog, i can do anything. It happens only with refine window.
If i want to refine, and i refine the item, i can refine it again. but its only happening when i CLOSE the window.
What did i do before this problem apperas? I really dont know. Only 3 systems touching to the refine system.
1.: extra refine system (tested while removed, same problem)
2.: slot marking system (tested while removed, same problem)
3.: fast refine system (tested while removed, same problem)
Removed all the 3 systems at the same time and still same problem.
(Nothing else touching the refine system)
Here is a gif about the problem:
If you want to see it, add me on discord. I can show it on discord too.
 

Spoiler

https://metin2.download/video/6Pj5i2yBQOIUb31EqLU9tDzU3OL78NZ5/.mp4

Sadly, there is no syserr.

Edited September 4, 2022 by Metin2 Dev
Core X - External 2 Internal

[Amun 1816]

Can you check if it sends the packets to the server after each action(delete an item, throw it, open and close the refine window, refine an item)? Also check the packets you get back after trying that.

You can't drop items while refining, so the client probably doesn't let the server know you've closed the window.

Edit: here's a pic with the server's packets, just in case:

root/uiRefine

	def Accept(self):
		net.SendRefinePacket(self.targetItemPos, self.type)
		self.Close()

	def CancelRefine(self):
		net.SendRefinePacket(255, 255)
		self.Close()

	def OnPressEscapeKey(self):
		self.CancelRefine()
		return True

Which in turn is sent by the client and handled in input_main.cpp

void CInputMain::Refine(LPCHARACTER ch, const char* c_pData)
{
	// [...]

	if (p->type == 255)
	{
		// DoRefine Cancel
		ch->ClearRefineMode();
		return;
	}

	// [...]
}

char_item.cpp

void CHARACTER::SetRefineMode(int iAdditionalCell)
{
	m_iRefineAdditionalCell = iAdditionalCell;
	m_bUnderRefine = true;
}

void CHARACTER::ClearRefineMode()
{
	m_bUnderRefine = false;
	SetRefineNPC(NULL);
}

 

Good Luck

Edited September 2, 2022 by Amun
extra details

[Ulthar 2790]

21 minutes ago, Amun said:

Can you check if it sends the packets to the server after each action(delete an item, throw it, open and close the refine window, refine an item)? Also check the packets you get back after trying that.

You can't drop items while refining, so the client probably doesn't let the server know you've closed the window.

Yea, but sadly, idont know how can i do debug on server in windows  so this is sad... but yea, u are right. server think im still refining.

[Amun 1816]

4 minutes ago, Ulthar said:

Yea, but sadly, idont know how can i do debug on server in windows  so this is sad... but yea, u are right. server think im still refining.

You don't have to debug the server, just check the client's packets. Mine might be slightly different from yours, but you got the point. Who knows, maybe it's just a python problem and you forgot to send the "refine end" packet.

Anyhow, you have everything you need in there.

[Ulthar 2790]

2 hours ago, Amun said:

root/uiRefine

	def Accept(self):
		net.SendRefinePacket(self.targetItemPos, self.type)
		self.Close()

	def CancelRefine(self):
		net.SendRefinePacket(255, 255)
		self.Close()

	def OnPressEscapeKey(self):
		self.CancelRefine()
		return True

This is part where i had the problem. Im just stoopid af. Just too stoopid for everything. Plus im blind too.
The problem was this:

Before:

	def CancelRefine(self):
		net.SendRefinePacket(255, 255)
		if app.ENABLE_REFINE_RENEWAL:
			constInfo.AUTO_REFINE_TYPE = 0
			constInfo.AUTO_REFINE_DATA = {
				"ITEM" : [-1, -1],
				"NPC" : [0, -1, -1, 0]
			}
		self.Close()

After:
 

	def CancelRefine(self):
		#net.SendRefinePacket(255, 255)
		net.SendRefinePacket(255, 255, 0, 0, 0, 0)
		if app.ENABLE_REFINE_RENEWAL:
			constInfo.AUTO_REFINE_TYPE = 0
			constInfo.AUTO_REFINE_DATA = {
				"ITEM" : [-1, -1],
				"NPC" : [0, -1, -1, 0]
			}
		self.Close()

 

Edited September 2, 2022 by Ulthar