Frozen

1 hour ago, WhoIsNice said:

I discovered another strange error, apparently when I have 1 and 2 full inventory and some items in other inventories, when I log out and log in again, the symbol appears in items, and it seems more strange is that appears on items in all inventories less than second, I don't know if I'm the only one ...

Before logging out, had tested in put the second full inventory as well, the difference is that I removed the symbols of the items in the first inventory and left on the symbol in the second inventory, when I log in, the second inventory didn't show the symbols in the items but the first appeared

P.s: I don't want you to take this the wrong way, I'm just testing various forms of case any errors

Regards!

 

EDIT: And tested now also left 2 items in the first inventory and I did log out with the second inventory, when I log in, the items in the first inventory appear again with the symbol

Didn't understand, can you show a video or a gif?

25 minutes ago, skill178 said:

Help no se ve el "New"

The syssr seems fine...

You have to put PyCallClassMember..... in the end of the function (out of the if statements)

1 hour ago, WhoIsNice said:

Good Job Frozen, the fix works!

P.S : Ainda bem que és Português, haja algum Português ajudar a comunidade como deve de ser..

One more like!

Thanks!

P.S: Obrigado pelo apoio

16 minutes ago, Cyber36 said:

He helped me and solved the bug in my client too!

Recommend that guy. <3

Thank you very much

#Update(Bug Fix)

6 minutes ago, Cyber36 said:

Here: 

It seems correct, i tested and it works. Give me your skype i will try to see whats wrong.

Just now, Cyber36 said:

I tried the fix, but when you do that item in the 2./3./4. inventory page, it gets that "New" Tag again :/

show me a print of your overInitem function

#EDIT

Bug in second inventory solution:

Search for:

def OverInItem(self, overSlotPos):

add under:

slotPos = overSlotPos

replace with this in the end of the function:

if overSlotPos in constInfo.NEWITEMS:
	            self.wndItem.EnableCoverButton(slotPos)    
	            constInfo.NEWITEMS.remove(overSlotPos)

8 minutes ago, miguelmig said:

Well, it's quite common for python systems to use constinfo.py to store data, but that usually causes to things to stop working when a player has multiple clients open, since it appears that the constinfo data is shared between clients, or so it was in the old clients, but I'm pretty sure that it will still happen, give it a try

Thats incorrect, every time you open client, it gets the constInfo varables and they are set in the client you are in. So you can open as many clients as you want it will have the default constInfo variables and not the ones in the other client open. Every time you set a variable in constInfo is like you are defining in your code, so the storage work like a variable not has a file.

I dont know if you understand, sorry for my bad english,

54 minutes ago, WhoIsNice said:

Great job! Thank you for sharing

I tested and i found a weird bug, when you have more than 2 inventory's, it seems a little bug, because when you move to another slot appear the icon saying "new" again and when you put the mouse under the item the "new" dont disappear, you need to open another inventory and open again the inventory were you have the item and then disappear "new" ...

Sorry for my bad english!

 

You have my like for sharing

Oh i didnt notice that! Thanks for detecting that bug i will see what i can do.

Kind Regards 

7 minutes ago, miguelmig said:

This will work terribly if a player decides to open 2 clients on the same machine at the same time

What?? Why you say that?

14 minutes ago, icewolf said:

itemCount = shop.GetOfflineShopItemCount(i)

 

if you help me i will share it with you 

ok i will try 

AlexxD

Check if you have import shop in the file.

If you do have, there are files or code missing in client source.

Post here line 962 of uiOfflineShop.py

5 minutes ago, Sonitex said:

Amazing, thanks.

5 minutes ago, galet said:

Nice dude ! Carry on

Thanks

Just now, enzi said:

Good Job  Thanks

No problem

Hello, im here today releasing my version of slot effect system. Is not the same as the official looks like but in the future i will update this to look the same.

Screenshot to see how it looks like.

Everything in this system was made by me.

Tutorial:

Go to UserInterface > PythonPlayer.cpp

Search for :

void CPythonPlayer::SetItemData(TItemPos Cell, const TItemData & c_rkItemInst)

Add in  the end of the funcion:

PyCallClassMemberFunc(m_ppyGameWindow, "OnNewItem", Py_BuildValue("(i)", Cell.cell));

Compile It.

Go to root > constInfo.py

Add this somewhere:

NEWITEMS = []

Save it.

Go to root > game.py

Add this function:

def OnNewItem(self, cell):
	if not cell in constInfo.NEWITEMS:
		constInfo.NEWITEMS.append(cell)

Save It.

Go to root > uiinventory.py

Search for :

def RefreshBagSlotWindow(self):

Add this before this: (if 0 == itemCount:) :

if itemCount == 0 and slotNumber in constInfo.NEWITEMS:
	constInfo.NEWITEMS.remove(slotNumber)

Add this under this: (setItemVNum(i, itemVnum, itemCount)) :

self.wndItem.EnableCoverButton(i)        
 if slotNumber in constInfo.NEWITEMS:
	self.wndItem.SetCoverButton(i, "d:/ymir work/ui/game/quest/slot_button_00.sub",\
																		 "d:/ymir work/ui/game/quest/slot_button_00.sub",\
																		"d:/ymir work/ui/game/quest/slot_button_00.sub",\
																		"d:/ymir work/ui/new_icon.tga", FALSE, FALSE)
	 self.wndItem.DisableCoverButton(i)

Search for:

def OverInItem(self, overSlotPos):

 Add under:

slotPos = overSlotPos

Add in the end:

if overSlotPos in constInfo.NEWITEMS:
	self.wndItem.EnableCoverButton(slotPos)    
	constInfo.NEWITEMS.remove(overSlotPos)

Save It.

Finally go to ymirwork/ui and add this file:

Pack root and etc.

Have fun

This may not be the most optimized way to do this system, but at least you have a way. In the future i will post more updates such as a more optimized versions and with official effects.

If you find any bugs please post it.

#UPDATE

self.wndCostume = None

Add under:

self.movedSlot = -1

search for:

itemCount = getItemCount(slotNumber)

 add under:

if self.movedSlot in constInfo.NEWITEMS:
	 constInfo.NEWITEMS.remove(self.movedSlot)

 search for:

def __SendMoveItemPacket(self, srcSlotPos, dstSlotPos, srcItemCount):

self.movedSlot = dstSlotPos

Kind Regards,

Frozen

7 minutes ago, BackPlayer said:

again nothing

this is meaning something important? https://metin2.download/picture/v1Y5Wfk2hX9uO0017M9IYbA7sg2lkDMu/.png

i could upload edit files for your system.

do you have skype?

2 minutes ago, BackPlayer said:

https://metin2.download/picture/yeAL4u3Zr5fKcD5KIjGI97uSO5A4q6cP/.png

You did not defined petLevel, add this after local petName = ...:

local petLevel = 1

and erase bFromFar.

17 minutes ago, BackPlayer said:

yeah may you forgot* add some parts? i will check it again if i do it right. i use quest pet from denis.

Should i create a table or something like this?

You just need to replace your pet.summon function in dennis quest with this one pet.summon(mobnum, petname, level)

Just now, BackPlayer said:

Already 

https://metin2.download/picture/fI1uPSfJZ3J92K6wbHDUgayC2M7X4TPd/.png

 

I tested everything and worked, you sure you compiled?

25 minutes ago, BackPlayer said:

https://metin2.download/picture/NZsx1JUixwoLxg03X2Tcdn8Z1217Ib06/.png just the same

You forgot this part:

if (IsPC() == true && (LC_IsEurope() == true || LC_IsCanada() == true || LC_IsSingapore() == true))

		if ((IsPC() || IsMonster() || IsPet()) == true)
		{
			addPacket.dwLevel = GetLevel();
		}
		else
		{
			addPacket.dwLevel = 0;
		}

10 minutes ago, BackPlayer said:

https://metin2.download/picture/BhJ6gY27s38m7GIugOZRyu1VjkeIQWB6/.png  wait i forgot to use new fuction

i try and  new pet.summon but nothing

After  you put that nothing happened?

13 minutes ago, BackPlayer said:

don't work for me don't show me level pet without error

did you do the client part?

Just now, BackPlayer said:

not worked i will you the source code wait

Ok, sure.

20 minutes ago, BackPlayer said:

you can say after teleport mount again the previoulsy mount, just i don't know the fuction and syntax of lua and if you can prefer C++ fix.

Thanks you for the reply!

You just need to put the mob item vnum(item) and the mount vnum (vnum). 

quest mount_bug begin
	state start begin
		when item.use begin
			local mountNum = {
			[item] = vnum
			}
			if pc.is_mount() then pc.setqf("mount", 0)
			else pc.setqf("mount", mountNum[item.get_vnum()]) end
		end
		when login with pc.getqf("mount") > 0 begin
			pc.mount(pc.getqf("mount"), 60*60*24*60) --time set for 60 days
		end
	end
end

For the second problem try using one of this quests:

quest mount_bug begin
	state start begin
		when login with pc.is_mount() begin
			pc.unmount()
			pc.mount(vnum)
		end
	end
end
quest mount_bug begin
	state start begin
		when item.use begin
			if pc.is_mount() then pc.setqf("is_mount", 0)
			else pc.setqf("is_mount", 1) end
		end
		when login with pc.getqf("is_mount") == 1 begin
			pc.unmount()
			pc.mount(vnum)
		end
	end
end

Im not sure if the first quest will work , because i dont know if when the player teleports he still has the is_mount() information so try both quests.

Dont forget to change the item and the vnum in the quest.