r00t3r

46 minutes ago, Mali61 said:

You think?

I don't understand you. Do you really find a bug? or...

Yes, I tested, I don't know if it's just me, can you test it on black magic? Like if you used the fireball and die, when you come back the ball will be seen next to you even if it is not active.

I think is an problem with TOGLE skills :-? like sura, can you test ?

24 minutes ago, tierrilopes said:

Couldnt try to reproduce it here even with a macro pressing skill buttons

I think your best lucky is to compare some sources where it doesnt happen to some where it happens, not sure what could be the issue there.

Did you tried it on localhost instead of live server to exclude a delay issue?

11 minutes ago, WeedHex said:

I think it is.

For me it is a waste of time, at the moment I will ignore this problem .. I will look for a solution in the near future if there will be ..
Until then, thank you all for your contribution.
Good luck to everyone!

Just now, TMP4 said:

I think we need the mythbusters 

:)) thas true, but metin2 version :))

Request to close topic  

Thank you all for trying to fix, i will try to see where is the problem in future

Just now, ZyuX said:

Locale_string is server side. Anyway, thank you for reply.

Check again

1 hour ago, TMP4 said:

I think you should log in to a 3rd server and try reproduce there. I suggest ddmt2.net since that's a pure base 40k server, the owner don't do any development.

Then you must realise it's not a common bug. I swear i tried several time there and at my test server too.

 

If you realise that, you would realise one more thing: nobody can help you without access to your file. I don't say to publish it, just saying that's why you are not getting help.

bump 

16 hours ago, FlasH said:

just press download and the video will play in browser

https://metin2.download/picture/r3F9504x09DVmF8K988YXgTtGTP6KMUj/.gif 

 

see debug log when the BINARY_NEW_AddAffect 20 0 0 4 come but after Remove Affect 20 0 come with a delay thats remove the effect of 2 th skill so i think thats the problem.

 

PythonNetworkStreamPhaseGame.cpp

 

BINARY_NEW_AddAffect

bool CPythonNetworkStream::RecvAffectAddPacket() { TPacketGCAffectAdd kAffectAdd; if (!Recv(sizeof(kAffectAdd), &kAffectAdd)) return false; TPacketAffectElement & rkElement = kAffectAdd.elem; if (rkElement.bPointIdxApplyOn == POINT_ENERGY) { CPythonPlayer::instance().SetStatus (POINT_ENERGY_END_TIME, CPythonApplication::Instance().GetServerTimeStamp() + rkElement.lDuration); __RefreshStatus(); } PyCallClassMemberFunc(m_apoPhaseWnd[PHASE_WINDOW_GAME], "BINARY_NEW_AddAffect", Py_BuildValue("(iiii)", rkElement.dwType, rkElement.bPointIdxApplyOn, rkElement.lApplyValue, rkElement.lDuration)); CPythonPlayer::instance().AddAffect(rkElement.dwType, kAffectAdd.elem); //martysama source come without this line return true; }

bool CPythonNetworkStream::RecvAffectAddPacket()
{
	TPacketGCAffectAdd kAffectAdd;
	if (!Recv(sizeof(kAffectAdd), &kAffectAdd))
		return false;

	TPacketAffectElement & rkElement = kAffectAdd.elem;
	if (rkElement.bPointIdxApplyOn == POINT_ENERGY)
	{
		CPythonPlayer::instance().SetStatus (POINT_ENERGY_END_TIME, CPythonApplication::Instance().GetServerTimeStamp() + rkElement.lDuration);
		__RefreshStatus();
	}
	PyCallClassMemberFunc(m_apoPhaseWnd[PHASE_WINDOW_GAME], "BINARY_NEW_AddAffect", Py_BuildValue("(iiii)", rkElement.dwType, rkElement.bPointIdxApplyOn, rkElement.lApplyValue, rkElement.lDuration));

	CPythonPlayer::instance().AddAffect(rkElement.dwType, kAffectAdd.elem); //martysama source come without this line

	return true;
}

BINARY_NEW_RemoveAffect

bool CPythonNetworkStream::RecvAffectRemovePacket() { TPacketGCAffectRemove kAffectRemove; if (!Recv(sizeof(kAffectRemove), &kAffectRemove)) return false; PyCallClassMemberFunc(m_apoPhaseWnd[PHASE_WINDOW_GAME], "BINARY_NEW_RemoveAffect", Py_BuildValue("(ii)", kAffectRemove.dwType, kAffectRemove.bApplyOn)); CPythonPlayer::instance().RemoveAffect(kAffectRemove.dwType, kAffectRemove.bApplyOn); //martysama source come without this line return true; }

bool CPythonNetworkStream::RecvAffectRemovePacket()
{
	TPacketGCAffectRemove kAffectRemove;
	if (!Recv(sizeof(kAffectRemove), &kAffectRemove))
		return false;

	PyCallClassMemberFunc(m_apoPhaseWnd[PHASE_WINDOW_GAME], "BINARY_NEW_RemoveAffect", Py_BuildValue("(ii)", kAffectRemove.dwType, kAffectRemove.bApplyOn));

	CPythonPlayer::instance().RemoveAffect(kAffectRemove.dwType, kAffectRemove.bApplyOn); //martysama source come without this line

	return true;
}

 

Tested and the result is same.. visual is present

1 hour ago, DrTurk said:

https://metin2.download/picture/r3F9504x09DVmF8K988YXgTtGTP6KMUj/.gif

https://metin2.download/picture/lrkVzfFOWe7I2gw1jxSfgE0QihTVQEcb/.gif

So you ignored both videos?

Just look at my video, i talked to @Anix on facebook and have the problem too after posted the video

Try to dont make any moves and spam the skills  

4 hours ago, FlasH said:

"also present on all servers" thats literally a NO, there are many who already showed they didnt have this problem me either.

  Hide contents

https://metin2.download/picture/0wqR058wY0g8t2guKYjf1lZ3SHWs39SK/.gif

i can say just to check the animation with dragon. maybe that animation into a conflict with skill animation and can be a visual bug.

 

This bug is just on warrior on body skills  try it

23 minutes ago, TMP4 said:

That's why the bigger names says make backups

Then you would know when it came, and what did you install, modify after etc.

I think is not a problem from any sistem.. i think is an problem with animations or i dont know, this strange visual bug is also present on all servers

32 minutes ago, WeedHex said:

Don't have it lol

Try to make it faster, like spam click on icon skills

Thanks, Sincerly,
r00t3r

Acum 18 minute, V0lvox a spus:

Syserr on Debug Binary ?

i have the same problem, is stucked on inventory, on costumewindows is working, when put mouse in inventory is stucket

is c++11 ? bcz i got some errors

Acum 19 minute, Rakancito a spus:

I can attack Metin Stone in my Test Server.

Evidence: https://metin2.download/picture/xyA9B4PIX13HYQEf6P8ak85UE5Kp04D7/.gif

You need to add a condition to verify if the attacker is PC and not NPC...

 

 

Can you give to me ?

Tested on live server, and you can`t attack metin stone

La 26.09.2019 la 1:05, VegaS™ a spus:

There's no check for victim pointer.

// Replace:
if (pkVictim->GetParty())
// With:
if (pkVictim && pkVictim->GetParty())

 

Thx Vegas, is ok now !

after tests is doing crash core, but i don`t know why

Now is ok, update the github for all

https://metin2.download/picture/fBM615G2UIa9VOFd3W4w1chTWo4U1VbH/.png

pkAttacker->

642 =             ch->ChatPacket(CHAT_TYPE_INFO, "Melee Attack: %d", get_dword_time() - ch->GetLastAttackTime());

Test before update  -> https://metin2.download/picture/3RDcqWNnSQHTb0DHMdEd865G3JVPKQc1/.png

https://metin2cms.cf/tools/#nav-text