Jump to content

Legend

Banned
  • Posts

    150
  • Joined

  • Last visited

  • Days Won

    5
  • Feedback

    0%

Posts posted by Legend

  1. 15 minutes ago, ѕeмa™ said:

    Well your gift look the same as aeldra, so... you could code a new one or "steal" it and sell it, who knows...

    And yes, other people maybe want to buy it because they dont know how to get it for free

    Anyway, i wont keep going with this, good luck both of you.

    A lot of things look the same this don't mean is the same code, whatever.

  2. 3 hours ago, attila1995 said:

    It`s not a good idea, bcs this modification uses mysql query request in every checking time.

    So if anybody attacks the server by send guild comment by spam bot , the mysql server will get so mutch request and that will causes slowdown on the mysql server, and that can make some problem during server running, for example the login will be very slow and etc.

    I don`t recommend this.

    There are another better ways to fix this problem.

    A pulse is also good idea then, but the first solution is the same when u click delete without a message exists in the guild window, is the same request, so there is a lot ways to attack somehow :)

     

  3. Hey,

     

    I shared a check for you, i think is the best way to block the attacks from the guild comments, because someone can make a bot and write a lot of comments in our guild_comment table.

    This is the best solution for me, because anyways nobody can see more than 12 comments in the comment guild window, and if someone write a new comment a comment will hide,

    so looks much more better to can write maximum 12 comments, and delete one for can write another.

     

    guild.cpp

    Spoiler

    In AddComment function under:

        if (str.length() > GUILD_COMMENT_MAX_LEN)
            return;

    Add this:

    // AddComment - Attack Fix
        char szQuery[1024];
        snprintf(szQuery, sizeof(szQuery), "SELECT COUNT(*) FROM guild_comment WHERE guild_id = %d", m_data.guild_id);
        std::unique_ptr<SQLMsg> commentCount(DBManager::instance().DirectQuery(szQuery));

        MYSQL_ROW GetResult = mysql_fetch_row(commentCount->Get()->pSQLResult);

        BYTE Comments = 0;

        str_to_number(Comments, GetResult[0]);

        if (Comments >= GUILD_COMMENT_LIMIT)
        {
            ch->ChatPacket(CHAT_TYPE_INFO, "You have reach the limit of 12 comments. Delete a comment for continue.");
            return;
        }
        // End

    guild.h

    Spoiler

    Search for:

        GUILD_CREATE_ITEM_VNUM            = 70101,

     

    Add bellow:

    // AddComment - Limit
        GUILD_COMMENT_LIMIT                = 12,

     

    Good Luck.

     

  4. And why to put this pulse, players can't see anyways the new messages and the old one is just hide if u reach the limit of 12 rows at guild window, better to make a check to can add only 12 messages and delete one for write another one.

  5. Hey, today i had tried to update my skill proto with the official one, but i saw some tables is missing in the skilltable.txt from official and some new clean tables is added.

     

    Missing tables: szMasterBonusPoly & szGrandMasterAddSPCostPoly & bLevelLimit i think so.

     

    Is here anyone who knows what's going on with the skill_proto official?

    I'm search for a solution or someone to explain me what's have changed.

×
×
  • Create New...

Important Information

Terms of Use / Privacy Policy / Guidelines / We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.