Amun

// char.h
	void				ClearStone();

// Replace with
	void				ClearStone(LPCHARACTER pkKiller = nullptr);



// char.cpp
void CHARACTER::ClearStone()

// Replace with this
void CHARACTER::ClearStone(LPCHARACTER pkKiller)
{
	if (!m_set_pkChrSpawnedBy.empty())
	{
		// Kill all monsters I spawned.
		FuncDeadSpawnedByStone f(pkKiller);
		std::for_each(m_set_pkChrSpawnedBy.begin(), m_set_pkChrSpawnedBy.end(), f);
		m_set_pkChrSpawnedBy.clear();
	}

	if (!m_pkChrStone)
		return;

	m_pkChrStone->m_set_pkChrSpawnedBy.erase(this);
	m_pkChrStone = nullptr;
}


// Find this struct and replace it
struct FuncDeadSpawnedByStone
{
private:
	LPCHARACTER m_pkKiller;

public:
	FuncDeadSpawnedByStone(LPCHARACTER pkKiller) : m_pkKiller(pkKiller)
    {}

	void operator () (LPCHARACTER ch)
	{
		ch->Dead(m_pkKiller);
		ch->SetStone(nullptr);
	}
};


// char_battle.cpp
		if (IsStone())
			ClearStone();

// replace with
		if (IsStone())
			ClearStone(pkKiller);

I didn't even try to compile it. Lemme know if it works

if (get_dword_time() - ch->GetLastAttackTime() < 5000)
	return;

I assume you don't want them blocked on the horse, so just block the riding.

Global search in game for ch->StartRiding(); and do your magic wherever you want. You may want to change that 5k with a global variable.

1 hour ago, Sonitex said:

Make sure the packet is being sent/recognized in the correct phase. 

Le us know if he sent the payment for the fix

7 minutes ago, Mali said:

https://metin2.dev/topic/30179-collection-reversed-uiwndmgr-functions/?do=findComment&comment=154337&_rid=14335

Ye, lemme read 200 topics real quick to see if you posted it. xD

Sorry, that was mean.

I meant: Apologies, my lord, I didn't mean to steal your likes. I shall be spanked at once

ResetFrame:
This is used in the 2018 root to reset animations. It's already implemented in the source, but wasn't included in the module.

If anyone needs it:

PythonWindowManagerModule.cpp

PyObject* wndMgrAniResetFrame(PyObject* poSelf, PyObject* poArgs)
{
    UI::CWindow* pWindow;
    if (!PyTuple_GetWindow(poArgs, 0, &pWindow))
        return Py_BuildException();

    if (!pWindow)
        return Py_BuildException();

    ((UI::CAniImageBox*)pWindow)->ResetFrame();

    return Py_BuildNone();
}

{ "ResetFrame",                    wndMgrAniResetFrame,                        METH_VARARGS },

root, ui.py:

# find
class AniImageBox(Window):

# find 
	def SetEndFrameEvent

# add
	def ResetFrame(self):
		wndMgr.ResetFrame(self.hWnd)

On 3/5/2023 at 9:40 AM, mageth said:

0305 10:18:00550 :: Failed to load script file : new_login/LoginWindow.py
0305 10:18:00551 :: 
ui.py(line:2781) LoadScriptFile
system.py(line:192) execfile
system.py(line:163) Run
new_login/LoginWindow.py(line:305) <module>

LoadScriptFile!!!!!!!!!!!!!! - <type 'exceptions.AttributeError'>:'module' object has no attribute 'SALVEAZA_CONT'

0305 10:18:00551 :: ============================================================================================================
0305 10:18:00551 :: Abort!!!!

0305 10:18:00553 :: 
introLogin.py(line:223) __LoadScript
ui.py(line:2798) LoadScriptFile
exception.py(line:36) Abort

LoginWindow.__LoadScript.LoadObject - <type 'exceptions.SystemExit'>:

0305 10:18:00553 :: ============================================================================================================
0305 10:18:00553 :: Abort!!!!

I can't figure out what's wrong pls help

https://docs.python.org/3/tutorial/modules.html

https://bobbyhadz.com/blog/python-attributeerror-module-has-no-attribute

https://www.google.com/search?q=python+module+has+no+attribute

Ah, yes, I see what you mean. It does, indeed, freeze when keeping the button pressed and then clicking the window.

Also, yeah, I went through all of those forum topics/stackoverflow questions/docs.. It's been a while, but I remember there were many things to take into consideration when making the game loop.

I will fix this(button thingy) as well at some point, but I can't promise anything because I won't have a lot of free time for the next month or so.

4 minutes ago, dumita123 said:

What Intel was saying is that if you're holding the left/right click on the bar without moving the mouse at all, the game will still freeze for around 300-500ms.
My post was only related to the context menu (because it was freezing the client while it was opened) so it just removes that option since no one was using it anyway.

Ah, yes, I just noticed now. If you want the transition to be done instantly, keep the thread opened at all times and just let it know when it can and can't call Process, instead of triggering a new future whenever you click the bar. ez

On 2/26/2023 at 10:08 AM, Dr3Ame3r said:

Tested, it works, but, with a slight little problem, after the loading phase ends (the loadingscreen photos disappear) and it should popup your character, it freezes for about 0.7-1s until it shows entities near you(that happens only 1 time for each client)

Yes, and I said that in the readme. If you want to avoid that, load npclist ahead of time and send the entities before the game world is shown. I didn't bother to make that as well because I wanted to keep it simple, so that everyone(or most people) can understand what's going on.

If you consider that to be a big problem and have the knowledge to do what I said earlier, you can do it and post it here, so that everyone can use. Unfortunately, I'm extremely busy at the moment, so I won't be able to work on community stuff for a while.

Cheers!

- Amun

15 hours ago, xXIntelXx said:

This still won't fix the problem when left clicking on the bar (and keeping the left click down, same with the right click). When moving, the player will keep moving in background and the window will also unfreeze, but not when auto attacking and pressing the spacebar, or moving pressing W (basically pressing any button while keeping the menubar clicked fucks it up. I still haven't found a solution for that but I also don't know if it causes to fly bug an enemy character).

Actually, it does. I can use the keyboard normally(move, attack, write) while dragging/keeping the window(left click). I've not thought about fixing the right click as well(for some reason). Also, I was extremely busy, so I've not checked to see if Dumita's change will help in that regard.

These being said, however, you can trigger/close the thread when entering and exiting the context menu. I don't see why you wouldn't be able to use the same solution for the right click as well.

Edit: Just noticed(forgot about it) I also have a video of me moving when dragging the client:

Regards,

Amun

Most likely because it doesn't exist.

Fucking ask Elendos, you donut.

If you bought the files, I'm sure you'll get help from the creators.

If you've not bought the files, fuck off, we don't offer support for leaks.

Made a year ago. Let me know if I missed anything(or if you need a tutorial on how to change it in the source)

Here's the repo:

No need for explanations. I made this a year ago so, if I missed anything, please let me know.

Here's the tut:

Tested on x86 client/server. Fix for x64 server/x86 client coming soon.

If I left something out, feel free to let me know and I'll update the tutorial.

2 hours ago, hachiwari said:

I dont know python, how will function 'move' behave with duplicates? (we know, sometimes ymir added corrected files wiht update)

Don't know, I didn't think that far.

I just made this shit for getting the entire pack ready for packing. I don't make granular updates, I'm just downloading the entire client, pack it, and bye(hence, the script).

Feel free to test/extend it to your needs.

Update: It'll replace the file with the new one.

https://docs.python.org/3/library/shutil.html#shutil.move

Update2: If you want granular updates, just add a function that recursively checks against your current pack folder using exists(path)

Update3: Here, I've done it for you

from os import listdir
from os.path import exists, join, isdir

#CONFIGS
target_folder = "processed_from_raw_pack"
pack_folder = "pack"#check against it recursively to see what's new in the target_folder

f = open("diff.txt", "w")
missing_files = ["MISSING_FILES\n"]
can_add_section_separator = False

def CheckAgainstOldPack(current_path = []):
    global can_add_section_separator

    for file in listdir(join(target_folder, *current_path)):
        current_path.append(file)
        _file_in_old_pack = join(pack_folder, *current_path)

        if isdir(_file_in_old_pack):
            CheckAgainstOldPack(current_path)
            current_path.pop(-1)
            continue

        if not exists(_file_in_old_pack):
            try:# Some files have fucked up names
                print("MISSING ", _file_in_old_pack)
                missing_files.append(_file_in_old_pack+"\n")
                can_add_section_separator = True
            except:
                pass

        current_path.pop(-1)

    if can_add_section_separator:#only add after each section of files, to simbolise different folders
        missing_files.append("\n")
        can_add_section_separator = False

CheckAgainstOldPack()

f.writelines(missing_files)
f.close()

Video:

Edit it to remove the files if you need to. You can also timestamp the diffs and use them to reverse one of your updates as well(if needed), just read the list and remove the file, ez.

Good evening, fellow citizens of the forum,

This is a script that automatically moves and creates folders for the official clients posted in "Official Unpacked Updates", getting them ready for packing.

Video:

Good luck,

- Amun

Update: Lol, I forgot to add the code xD

from os import listdir, mkdir
from os.path import exists, join, isdir
from shutil import move

raw = "raw"
target = "processed"

def MoveFolders():
    if not exists(target):
        mkdir(target)

    for folder in listdir(raw):
        _from = join(raw, folder)

        if not isdir(_from) or folder == "root" or folder == "uiscript":
            print("Skipping {}".format(_from))
            continue

        if folder == "d_" or folder == "ymir work":
            MoveYmirFolders(folder)
            continue

        if folder == "locale" or folder == "locales":#Astro using locales
            MoveLocale(folder)
            continue

        _base = join(target, folder)
        _to = join(_base, folder)

        if not exists(_base):
            mkdir(_base)

        move(_from, _to)
        print("Moved folder {}".format(folder))


def MoveYmirFolders(name):
    if name == "d_":
        ymir = join(raw, name, "ymir work")#astro
    else:
        ymir = join(raw, "ymir work")#p3ng3r

    for folder in listdir(ymir):
        _base = join(target, folder)
        if not exists(_base):
            mkdir(_base)
        
        _work = join(_base, "ymir work")
        if not exists(_work):
            mkdir(_work)

        _from = join(ymir, folder)
        _to = join(_work, folder)

        move(_from, _to)
        print("Moved folder {}".format(folder))


def MoveLocale(locale):
    root = join(raw, locale)

    if locale == "locale":#P3ng3r
        for folder in listdir(root):
            _base = join(target, locale + "_" + folder)
            _from = join(raw, locale, folder)
            _to = join(_base, locale, folder)

            if not exists(_base):
                mkdir(_base)
                mkdir(join(_base, locale))

            move(_from, _to)
            print("Moving locale {}", folder)

    elif locale == "locales":#Astro
        for folder in listdir(root):
            move(join(root, folder), join(target, folder))


__name__ = MoveFolders()

Skip this part, you don't need it anymore. Scroll down.

The game loop freezes when dragging/resizing the window. This is an attempt at fixing that.

We'll open a thread and call "Process()" from there when we receive WM_ENTERSIZEMOVE and then shut it down when receiving WM_EXITSIZEMOVE, continuing our main game loop.

There's also the option of creating a timer when entering WM_ENTERSIZEMOVE, calling "Process()" when receiving WM_TIMER and killing it when receiving WM_EXITSIZEMOVE, but there's quite a big delay till the timer starts and it's also not very reliable, so..

Video:

Code:

Many thanks to @limefor taking the time to test it.

Good luck!

UPDATE: Forget everything I gave you the last time, here's the complete fix:

UPDATE2: Blocked right click as well, thanks @ CORKY

If there's anything else that needs blocking/changing, let me know and I'll update the topic.

// PythonApplication.cpp
// Search m_dwLastIdleTime(0),
// Add m_IsMovingMainWindow(false),

// Search 
#ifndef _DEBUG
	SetEterExceptionHandler();
#endif
  
// Add
	m_InitialMouseMovingPoint = {};

// Search
void CPythonApplication::Loop()
{
  ...
}

// Add before:
void CPythonApplication::SetUserMovingMainWindow(bool flag)
{
	if (flag && !GetCursorPos(&m_InitialMouseMovingPoint))
		return;

	m_IsMovingMainWindow = flag;
}
bool CPythonApplication::IsUserMovingMainWindow() const
{
	return m_IsMovingMainWindow;
}
void CPythonApplication::UpdateMainWindowPosition()
{
	POINT finalPoint{};
	if (GetCursorPos(&finalPoint))
	{
		LONG xDiff = finalPoint.x - m_InitialMouseMovingPoint.x;
		LONG yDiff = finalPoint.y - m_InitialMouseMovingPoint.y;

		RECT r{};
		GetWindowRect(&r);

		SetPosition(r.left + xDiff, r.top + yDiff);
		m_InitialMouseMovingPoint = finalPoint;
	}
}


// Search
void CPythonApplication::Loop()
{
#ifdef PROFILING
	Profiler::Instance().beginSession("session1");
#endif

	while (1)
	{

// Add
		if (IsUserMovingMainWindow())
			UpdateMainWindowPosition();

// Looks like this:
	while (1)
	{
		if (IsUserMovingMainWindow())
			UpdateMainWindowPosition();

		if (IsMessage())
		{
			if (!MessageProcess())
				break;
		}
		else
		{
			if (!Process())
				break;

			m_dwLastIdleTime = ELTimer_GetMSec();
		}
	}

// PythonApplication.h
// Find
void Loop();

// Add
	bool IsUserMovingMainWindow() const;
	void SetUserMovingMainWindow(bool flag);
	void UpdateMainWindowPosition();

// Go to the end and
protected:
	bool m_IsMovingMainWindow;//add this
	POINT m_InitialMouseMovingPoint; // and this
	int m_iCursorNum;

// PythonApplicationProcedure.cpp
// Find
case WM_EXITSIZEMOVE:
{
...
}

// Add
	case WM_NCLBUTTONDOWN:
	{
		switch (wParam)
		{
		case HTMAXBUTTON:
		case HTSYSMENU:
			return 0;
		case HTMINBUTTON:
			ShowWindow(hWnd, SW_MINIMIZE);
			return 0;
		case HTCLOSE:
			RunPressExitKey();
			return 0;
		case HTCAPTION:
			if (!IsUserMovingMainWindow())
				SetUserMovingMainWindow(true);

			return 0;
		}

		break;
	}
	
	case WM_NCLBUTTONUP:
	{
		if (IsUserMovingMainWindow())
			SetUserMovingMainWindow(false);
		
		break;
	}

	case WM_NCRBUTTONDOWN:
	case WM_NCRBUTTONUP:
	case WM_CONTEXTMENU:
		return 0;

13 minutes ago, Speachless said:

It's different than using len() ? for the lenght

No

The fuck did you refactor?

Thanks, Mali!

19 minutes ago, Euzebiusz said:

Can you make a recording of what the situation looks like before adding the code and what the situation looks like after adding the code?

no

Topic/code updated. Apologies for the bump.

This is the first version(made a month ago). No isolation from normal fishing or ON/OFF switch and no key exchange/validation, but it's working.

Let me know if I forgot any assets/pieces of code and I'll update the repo.

Code: 

Little GIF:

Don't message me. If you have problems, post them here.

Good luck!

No need for a description, here's the code:

Q: Is this the best way to do it? Is there a better way?

A: Don't know, don't care. That's how I've done it, get over it.

Q: Any checks you didn't add?

A: There might be some stuff that I missed/forgot about(done it in a rush). If you notice something, let me know and I'll update the code accordingly.

Q: It's not working for me. Support?

A: Only in the topic(when I have time), don't fucking message me.

On 12/5/2022 at 10:28 AM, Olimpion2 said:

Thank you very much friend, it has already helped me 50%, I would like to put the option in the login and selection part too, if you can help me, I really appreciate it.

Don't push it, the dude already gave you everything you asked for/needed. Read the root files, use your brain(if you have any), and do it yourself.

If you can't read/write code at a basic level, you shouldn't be here, and that's a fact.

Start here: https://wiki.python.org/moin/BeginnersGuide/NonProgrammers