[C++] Party

[Zevilke 0]

Hy community,

I'm working on to make party between different empires. 

Now i can make the group, but different empire charaters in the group can hurt each others in the group,

I hope you can suggest me a solution for this.

 

Thanks

[North 1171]

I did this for my server few time ago, you just have to edit pvp.cpp

This:
bool CPVPManager::CanAttack(LPCHARACTER pkChr, LPCHARACTER pkVictim)

[Zevilke 0]

    if (pkVictim->GetParty() && pkVictim->GetParty() == pkChr->GetParty())
    {
        return false;
        // Cannot attack same party on any pvp model
    }
 

i found this condition that place, if i'm right, it should have block hurt others, but the problem still alive. 

[North 1171]

Try this

    if (pkVictim->GetParty() && pkVictim->GetParty() == pkChr->GetParty())
    {

            if (pkChr->GetEmpire() != pkVictim->GetEmpire())    // { return false; }
        return false;
    }

 

[Zevilke 0]

it's not solved my problem. i can still hit each other. :/

[North 1171]

Try just below:   


else
    {
        if (pkVictim->IsKillerMode())
        {

               //original return false;
            return true;
        }

 

By the way you will still attack but wont do any dmg with this

[Zevilke 0]

...

    if (pkVictim->GetParty() && pkVictim->GetParty() == pkChr->GetParty())
    {
        if (pkChr->GetEmpire() != pkVictim->GetEmpire())
                return false;
        // Cannot attack same party on any pvp model
    }
    else
    {
        if (pkVictim->IsKillerMode())
        {
            return true;
        }

        if (pkChr->GetAlignment() < 0 && pkVictim->GetAlignment() >= 0)
        {
            if (g_protectNormalPlayer)
            {
            // ąüąýŔÚ´Â ĆňČ­¸đµĺŔÎ ÂřÇŃ»ç¶÷Ŕ» °ř°ÝÇŇ Ľö ľř´Ů.
            if (PK_MODE_PEACE == pkVictim->GetPKMode())
                return false;
            }
        }

        switch (pkChr->GetPKMode())

...

 

here is the part of my function. Your suggestion was there in the else condition,

[North 1171]

yes, with that you can still attack but wont do any dmg, right?
im going with my reminds im not 100% sure, if it doesnt work still ill lookup better

[Zevilke 0]

i take damage. That's funny  But thanks the replies.

[North 1171]

try this, look for    

if (pkChr->GetEmpire() != pkVictim->GetEmpire())

add ABOVE

if (pkVictim->GetParty() && pkVictim->GetParty() == pkChr->GetParty()) { return false; }

[Zevilke 0]

it's working, i can't take damage for the grouped mate. Is there any solution to avoid the attack? for example if i write a run, it's embrassing when the hit away each others

by the way thanks your help, i'm very glad

 

[North 1171]

16 minutes ago, Zevilke said:

it's working, i can't take damage for the grouped mate. Is there any solution to avoid the attack? for example if i write a run, it's embrassing when the hit away each others

by the way thanks your help, i'm very glad

 

You should modify other parts, if i get into that i will post here, glad you solved

[Denis 1474]

The attack part is at client src so you need to change that too

[Zevilke 0]

can you tell me a little closer information Denis Sensei?

 

[Zevilke 0]

Finally i found it. 

at the client source: InstanceBase.cpp 
find this: bool CInstanceBase::IsAttackableInstance(CInstanceBase& rkInstVictim)

and after     

if (GetVirtualID() == rkInstVictim.GetVirtualID())
        return false;

put this two lines: 

    if (IAbstractPlayer::GetSingleton().IsSamePartyMember(GetVirtualID(), rkInstVictim.GetVirtualID()))
        return false;
 

Hope it will help for all, who want to make the same feature!

[xDiiZeRx 40]

Can you send the feature? The part of the party create too. Please