Guild creatin error

[Kaso 0]

Hey i get following error after creation of a new Guild:

Spoiler

EscapeString: FATAL ERROR!! not enough buffer size (dstSize 25 srcSize 13 src: Teste)

 

The code looks like :

Spoiler

    static char __escape_name[GUILD_NAME_MAX_LEN * 2 + 1];
    DBManager::instance().EscapeString(__escape_name, sizeof(__escape_name), static_cast<const char *>(gcp.name), sizeof(gcp.name));
    std::auto_ptr<SQLMsg> pmsg(DBManager::instance().DirectQuery("SELECT COUNT(*) FROM guild%s WHERE name = '%s'", get_table_postfix(), __escape_name));
    if (pmsg->Get()->uiNumRows > 0)

 

Does anyone got a idea how to fix this error ?

[alondark 68]

yeap, i have too, pls help

[Speachless 1060]

If you use that fix for guild sql inject you have to remove it, it already have    if (!check_name(gcp.name)) that doesn't allow more than A-Z. So the fix isn't necesary. If you are worried about that sql inject, it is just from messenger.

[V0iĐ 127]

dst size: 12*2+1=25

src size: 13*2+1=27

maybe:

sizeof(gcp.name)

replace:

strlen(gcp.name)

 

Oh i forgot:

This """fix""" is a bullshit. Such as Sebastian said.

Edited August 20, 2022 by Metin2 Dev
Core X - External 2 Internal