[C++]Refine

[BackPlayer 55]

I want to remove extra bonus from specific items when they are upgrade.

i try this but not work

 

 

 

[Ken 895]

At first, the item pointer is the old pointer. You have to choose the new one. (pkNewItem)

for (BYTE i = 0; i < ITEM_ATTRIBUTE_MAX_NUM; ++i)
	pkNewItem->SetForceAttribute(i, 0, 0);

You should add this command before add item to character.

Best Regards

Ken

[BackPlayer 55]

cause i don't know if i understand(my english is bad) if i want the 16208 when i upgrade it 16209 to remove extra bonus how i can do it?

[Ken 895]

if (pkNewItem->GetVnum() == 16209)
{
	for (BYTE i = 0; i < ITEM_ATTRIBUTE_MAX_NUM; ++i)
		pkNewItem->SetForceAttribute(i, 0, 0);
}

Best Regards

Ken

[BackPlayer 55]

 

34 minutes ago, Ken said:

if (pkNewItem->GetVnum() == 16209)
{
	for (BYTE i = 0; i < ITEM_ATTRIBUTE_MAX_NUM; ++i)
		pkNewItem->SetForceAttribute(i, 0, 0);
}

Best Regards

Ken

there is a problem this affect all upgrades

[tavi 13]

I try, don't work . Help.

[BackPlayer 55]

Just now, tavi said:

I try, don't work . Help.

char_item.cpp search:

Spoiler

pkNewItem->SetForceAttribute(i, 0, 0);

under paste this:

switch(pkNewItem->GetVnum())
            {
                case 17209: <--- ID of next refine
                {
                    for (BYTE i = 0; i < ITEM_ATTRIBUTE_MAX_NUM; ++i)
                        pkNewItem->SetForceAttribute(i, 0, 0);
                }
                break;
            }

[tavi 13]

1 hour ago, BackPlayer said:

char_item.cpp search:

  Reveal hidden contents

pkNewItem->SetForceAttribute(i, 0, 0);

under paste this:

switch(pkNewItem->GetVnum())
            {
                case 17209: <--- ID of next refine
                {
                    for (BYTE i = 0; i < ITEM_ATTRIBUTE_MAX_NUM; ++i)
                        pkNewItem->SetForceAttribute(i, 0, 0);
                }
                break;
            }

Thanks I will try your metod.

 

My code is:

 

    if (pkNewItem->GetVnum() == 230 )
{
            ITEM_MANAGER::CopyAllAttrTo(item, pkNewItem); // copy the all the bonus on the new item
            LogManager::instance().ItemLog(this, pkNewItem, "REFINE SUCCESS", pkNewItem->GetName());
            // rewrite the bonus 1-5 (0)
            for (BYTE i = 0; i < 5; ++i)
            pkNewItem->SetForceAttribute(i, 0, 0);
	            BYTE bCell = item->GetCell();
	            // DETAIL_REFINE_LOG
            NotifyRefineSuccess(this, item, IsRefineThroughGuild() ? "GUILD" : "POWER");
            DBManager::instance().SendMoneyLog(MONEY_LOG_REFINE, item->GetVnum(), -cost);
            ITEM_MANAGER::instance().RemoveItem(item, "REMOVE (REFINE SUCCESS)");
            // END_OF_DETAIL_REFINE_LOG
	            pkNewItem->AddToCharacter(this, TItemPos(INVENTORY, bCell));
            ITEM_MANAGER::instance().FlushDelayedSave(pkNewItem);
	            sys_log(0, "Refine Success %d", cost);
            pkNewItem->AttrLog();
            //PointChange(POINT_GOLD, -cost);
            sys_log(0, "PayPee %d", cost);
            PayRefineFee(cost);
            sys_log(0, "PayPee End %d", cost);
}
	// on the item who is not in the above list, the bonus remain all.
        else if (pkNewItem)
        {
            ITEM_MANAGER::CopyAllAttrTo(item, pkNewItem);
            LogManager::instance().ItemLog(this, pkNewItem, "REFINE SUCCESS", pkNewItem->GetName());
	            BYTE bCell = item->GetCell();
	            // DETAIL_REFINE_LOG
            NotifyRefineSuccess(this, item, IsRefineThroughGuild() ? "GUILD" : "POWER");
            DBManager::instance().SendMoneyLog(MONEY_LOG_REFINE, item->GetVnum(), -cost);
            ITEM_MANAGER::instance().RemoveItem(item, "REMOVE (REFINE SUCCESS)");
            // END_OF_DETAIL_REFINE_LOG
	            pkNewItem->AddToCharacter(this, TItemPos(INVENTORY, bCell));
            ITEM_MANAGER::instance().FlushDelayedSave(pkNewItem);
	            sys_log(0, "Refine Success %d", cost);
            pkNewItem->AttrLog();
            //PointChange(POINT_GOLD, -cost);
            sys_log(0, "PayPee %d", cost);
            PayRefineFee(cost);
            sys_log(0, "PayPee End %d", cost);
        }

It work fine..

[r00t 122]

Why you call procedure "CopyAllAttrTo" and after you delete all bonus with a for cicle? You can just delete it and you will not have bonus in new items 

[tavi 13]

With that, I delete just 1-5 bonus, and the 6/7 bonus remaing ! I don't want to write a new function exemple: copyrareattrto .. is very simple with that ..