Vanilla

check your Makefile and change your g++ to a compiler that's actually present in the system. g++ is from older systems where gnu cc was the standard compiler. Now we have clang and there you'd use c++ or install a compiler manually. This way you can also install and use gcc but you shouldn't use "g++" as your compiler in your Makefile.

That's actually a quite good idea.
Next vanilla release will have a offline message system based on c++ and txt.
Also mail system incoming. With open source you can just get it from the vanilla sources then. No need to pay 

if you're force closing your server you'll get serious trouble. You'd check that you're doing a so called grace shutdown. Give your server time to sync the dbcache with your database. Otherwise you'll loose items. That's why companies have a larger span of time for their maintenances.

Thank you everyone for the kind feedback.

next build is coming soon. If everything goes as planned we'll hit stable soon.

And no, I don't plan on releasing a bin like I do it with the core. Maybe some day in the future but currently there are no plans.

I'm also onto the problem with compiling under release mode and I think I found it. Next build should work without any problems in release mode

2 hours ago, kieranFMT2 said:

@Vanilla can you please release a compiled version of the core?

I fixed the download link, now you can download the compiled version

@Hik: Please post a backtrace. Otherwise we're unable to help you.

Run config.exe and have a look at "frequency". This is the setting where you can change the fps cap. Note that in the default config it's only possible to switch between 30 and 60. You may change that if you're building your own config. The setting is saved in metin2.cfg where you can change it too

46 minutes ago, Ikh said:

The difference is that you don't build these, but you also don't get to set options, and it's not guaranteed they will work with packages already on the system. That's why there are other commands like pkg upgrade.  There are some special cases like using -march and -mtune ..  Using march can cause problems , if you use march intro game core or db core and not using intro build ports can make a underfined behavior but that's not the case.

The only reason to use ports inseated of package manager is build options.  The packages is a prebuild port, and don't have flags like mtune and march.    Most likely you did something wrong if you had issues, It happens. I use package since years and it works like a charm..

***Note***

Since you use some modern coding standards consider using stdint.h stuffs also..  It is illegal to add functions in the namespace std , so consider removing that namspace.. xD   stl.h can be removed completly.

***Note***

any_function.h can be replaced with std::function / stable_priority_queue.h can be replaced with  std::priority_queue / thecore_memcpy bulshit can be replaced with std::memcpy  / noncpypable.h is useless it can be deleted /  clean constructors or destructors can be replaced with default or delete.

Yep, the exact points you mentioned are the reasons I'd consider building them myself instead of using pkg. Though I don't blame people for using pkg, I write my guides like I'd do it and that's the way it worked. If that's too long for you, feel free to use pkg. But in Freebsd < 9.4 you might not have much fun with it. You need clang to be the compiler except you wish to change the compiler for your m2 source to gcc. Older FreeBSD versions don't have packages prebuilt with clang.

The project is ongoing and yes, code modernization is a part of the plan. Thanks for your feedback, I'll take that into account when preparing the next versions 

Just now, Ikh said:

It really is not necessary for you to write so much.

pkg install clang38
pkg install googletest
pkg install cryptopp
pkg install devil
pkg install mariadb100-client
pkg install gmake

All in one..

pkg install clang38 googletest cryptopp devil mariadb101-client gmake

No need to write a love letter ..   I think the release version 3.8 of clang is enough

Using the pkg system isn't as effective. It's faster but it's not better. You'd compile the ports on your machine. I for myself experienced a lot of trouble especially when installing compilers via pkg. Additionally you don't need everything, just like in devil. And you sure know that we use clang and some ports may or may not use it depending on the system you're using? We don't need to link to gcc-prebuilt packages...

clang-devel should be installed just via ports. It should work in FreeBSD < 10.
c++14 needs the newer clang version. If you're on one of the older compilers like gcc 4.2 it most likely won't work. Also you need devel/libc++ and devel/libcxxrt
To build you then only need security/googletest, security/cryptopp, graphics/devil (only jpg needed, all else is not needed), devel/gmake, devel/makedepend and database/mariadb101-client (or any other mysql client for the lib). These are all the dependencies. I've gathered them together into a list. Note that every additional port should be compiled with clang instead of gcc! You cannot use gcc-compiled libs in a clang-project.

First install:
- lang/clang-devel (you don't need to use the devel-version of clang, you can just install one of the most recent versions)
- devel/libc++
- devel/libcxxrt
- devel/gmake (should already be installed by one of the ports above)
- devel/makedepend

And then add the following to /etc/make.conf:
CC = clang-devel
CPP = clang-cpp-devel
CXX = clang++-devel
CFLAGS += -stdlib=libc++

After that you can start installing the dependencies:
- security/googletest
- security/cryptopp
- graphics/devil (note: Only jpg needed)
- databases/mariadb101-client (no server needed, only the client. You can also use mysql if you wish to, we only need the client lib)

If everything is installed, make sure you rebuild the Depend-File. For this you can just cd into the source directory and remove it. Then you can just execute the following command:
gmake depend

After that you'll have everything you need. You can build the sources.
gmake debug|release|all
Note that you can either choose to compile debug, release or all. You can also use install if you specified a path in your Makefile. This way the created binary will be pushed into a directory once it's finished.

I did not use the BSD-functions. I use c++ standards. Lots of stuff can be handled via std-lib. Since c++11 there's a lot of new features. For example I replaced the boost::unordered_map with std::unordered_map. This also ensures cross-compatibility since you can build libc also on unix-systems.

Also the security issues were SQL injections most of the time. For example the auth-messenger. But it's not limited to sql injections since there also were a few things not coded correctly with which you'd possibly crash the core. Most of them is already public so nothing too new.

@galet

Clientside you can just change the pong like you want to. There's nothing needed, unless you want to change the pong via config files there too (which shouldn't be done). The reason I implement this on the source is for people who just want to change those things on-the-fly and maybe release a updated binary. Or you just want to have the possibilities without messing with the core. It's more simple, the client part should be done too of course but that's not one of those things I'd do. I think I'll write a guide on how to change the encryption, e. g. xtea to AES regarding the client. This way they everyone can implement those things in their own client.

I won't make a big project for the client. But I will do some few things like python 3.6 and I also will release a guide + source download for those things. But nothing like the core^^

Additionally I'm planning on gathering information for the next version of the core. Please share some feedback if you have and tell me what you'd like to see in the next revision. Few things I can already mention:

- Option to switch compression algorithms. You'll be able to switch from lzo to lz4 and backwards by CONFIG
- Option to switch encryption algorithms. You'll be able to switch from xtea to CAST-128 or AES and vice versa (does only work with enhanced security disabled)
- Option to setup pong and other stuff via CONFIG. Of course some stuff does only work with enhanced security disabled.
- Option to enable/disable custom MySQL-functions for passwords (so you can use e. g. salt for better security)
- Ingame Elevation with a standard passphrase (enabled by default!)

The next release focuses on stability and security. The goal is to add more diversity when it comes to encryptions and hardening your server. With custom passphrases and stuff you'll be able to switch to other implementations easily. Also the custom password functions will further protect the passwords even when an attacker gets insight on the database. Of course the core will also be able to use a custom phrase to further lengthen the password and making it more difficult for attackers to retrieve the original strings.

Let me hear your thoughts

EDIT: Btw. I tried to fix every bug that's been made public. But I'm not 100% sure I got everything. That's why I'm asking you kindly to revise the core and see if there's anything unstable before I brand it as a stable one. That's why It's called a BETA

fixed the link for source code

Greetings!

The new beta is finished! I'm proud to present r71480.
This time a few things have changed. And in this revision, we have a lot of new stuff.
In the following I'll provide the download link along with the things I'd love you to test.

*** DISCLAIMER ***
The core is marked as stable. Anyway, I'll make it clear that I'm not responsible if you use this core since I can't give a warranty that I fixed every single security breach that potentially could happen - that's totally impossible. But we all together made the source great and secure so every public issue is fixed by now. You can use it in production environments now. 

So... What's new?

• boot-trigger for quests
  • With this you can execute commands, timers, and all the stuff you'd like to have just on boot-time!
• revisioning of the 'unique class' (+ a ton of posibilities)
  • added the functionality to create unique-groups
  • temp-Variables for quests
• upgraded all libs
• moved completely to the newest clang version
• fixed some big security issues in the source code
• fixed the ingame ban and unban commands
• unified tables and gave them a new way: unify!
• file clean-up
  • revisioned the makefiles
  • gave the source a new, easier structure
• removed all external dependencies
  • just install them by ports.. No external-folder necessary!
  • removed 'boost' dependency (no boost lib needed yay)
• partial implementation of the wolfman (claws etc. are added, needs review)
• And basically everything that has been offered in the earlier versions of the vanilla core. Nothing should be missing.
  And if you miss something, just feel free to tell me!

What needs testing?

There are few things I'd love you to test out:

1. Please check if the core is vulnerable to any security breaches you may know (also the public ones, don't know if I missed something)
2. Please test out the new features! I'd really love to know if the new unique-functions and the boot-trigger does the job.

Explanation to new features:

• Unique with container support
  • Unique has evolved! This time you have a few new possibilities. Don't know what unique is? Here's a short explanation:
    With the unique-questfunctions you can spawn or set mobs, npcs and now even players to have a unique name. This name is
    stored into a unique-container. You can access this container and get all the vid's by their unique name (also called: the key)
    So for example you can spawn a boss with a key. Later on you can check if this specific mob has been killed or not. Or you can
    set his hp on-the-fly. There's basically no limits!
  • And now with the revised system you'll have even more options. The new unique system works with containers. By default there are
    two containers reserved: __DEFAULT__ and __CHARACTER__. The first one is for all the basic stuff. And the second one is reserved for players. Now, as you may have noticed, there's a default one which means that the container-stuff is optional. If you just use the unique functions without specifying a container, it'll just use the default stuff. But you CAN use your own containers just
    as you want to. You can create, delete and list all the containers running. There is a list with all the quest-functions down below.

• boot-trigger
  • This is pretty self-explanatory. With this release you can use "when boot begin" to specify a block of code that will be executed
    once the core has been booted.

• temp-variables
  • With the new temp-variables you can set and remove player-specific variables. They are stored in the core and not written
    to disk or database. So be careful because they might get dropped once the core shutdowns. It's just a quick storage for people
    who want to have something like a cache for quick access.

• new quest functions
  • nil unique.spawn_unique(string key, int vnum, string pos=unused, string container=optional)
  • nil unique.set_unique(string key, int vid, string container=optional)
  • nil unique.purge_unique(string key, string container=optional)
  • nil unique.kill_unique(string key, string container=optional)
  • bool unique.is_unique_dead(string key, string container=optional)
  • int unique.get_hp_perc(string key, string container=optional)
  • nil unique.set_def_grade(string key, int def, string container=optional)
  • nil unique.set_hp(string key, int hp, string container=optional)
  • nil unique.set_max_hp(string key, int maxhp, string container=optional)
  • int unique.get_vid(string key, string container=optional)
  • bool unique.exists(string key, string container=optional)
  • table unique.get_container_list()
    • this prints out all the unique containers
  • table unique.get_container_list(string key)
    • this prints out all the vids in the unique-container "key"
  • nil unique.remove_container(string key)
    • removes a whole container (flushes it when called on standard containers)
  • nil pc.temp_var_set(string key, string value)
  • string pc.temp_var_get(string key)
  • nil pc.temp_var_delete(string key)

Thanks a lot for participating!
If there are any questions, this is the topic related to it. Further releases will be made public here too!
If you'd like to contribute, just post code additions here.
 

Changelog

older changelogs

Download

Useful information: All necessary libs are included. If you're building your own vanilla binary you'll first have to move into every project of the Internal directory and rebuild the libs. The main makefile is not adapted yet, I was too lazy  (ps: Still too lazy!)

• rev 71480
  • see this post:
    • •  
• rev 70220
  • STABLE
    • Core
    • This is the hidden content, please

      • Sign In
      • or
      • Sign Up
    • M2D Storage
•  

Password for the archive is: vanilla
Password for older source archives: vanillamt2

Best Regards
Vanilla

The error in your first post is pretty much the join-statement.

if you use t1.join() then the game will synchronize with the thread meaning it's waiting for the thread to be finished. A thing that will actually never occur since your thread is running into infinity. The precise point where you're using join() is the moment when the game stops executing. Yes, your thread will still run, but the actual game won't because it's always waiting for your thread. At the very moment you're spawning the thread, execution starts. So there's no need for join anyway.

1. warning: `/libexec/ld-elf.so.1': Shared library architecture i386:x86-64 is not                                                                              compatible with target architecture i386.
2. warning: .dynamic section for "/libexec/ld-elf.so.1" is not at the expected addr                                                                             ess (wrong library or version mismatch?)

These lines tell you what's wrong. There is clearly a library mismatch and you'd check that you're using the correct libs for your game core.

please post the quest (only the whole part where the error occurs) so we can help you. Are there any syserrs? And if you have a snippet of your syslog it'd be helpful.

_types.h isn't missing. It's the DEPEND-file that may be messed up a bit. Try to do the following:

mv Depend Depend.bak

gmake dep

This recreates the Depend-file as long as you have devel/makedepend installed. It automagically creates a new Depend-file with the correct path to _types.h

Can't we agree to stop discussing about developers and let him search for the one that's fitting for his needs? This is a service searching thread and unless you don't want to offer your services there's literally no reason to post here. Especially not when it comes to discussing about irrelevant and stupid things.

Development is on halt since rl took over, as many of you may have noticed. I'll continue the developing once I have more time for it. Sorry for the inconvenience, the project of course isn't dead.

41 minutes ago, martysama0134 said:

Non-revisioning the work is always a big flow.

"Send it to me" -> Hypothetically, it shouldn't be a bad idea, but we should consider the reality: There are many resellers/thiefs in here. If you add the stolen code they give you, you will get a lot of problems and also lose your reputation.

Talking about a new lz4, you can simply add it via a different header/magic. You know the difference between MCOZ and EPKD? That's almost everything said.

About the HDD/SSD matter... People could also try RAMDisk if they don't want to spend money on new hardware. If you "upgrade" the game, it will obviously require an "upgrade" of the hardware too. So no need to cry over it.

I know it is but using git and svn could be troublesome if it gets closed. And I won't have a server nor do I want to rely on something for this work. I won't publish any branches but that doesn't mean I won't work with revisions locally

You're right with the send it to me. I'll change that into "Post it into the release topic". This way everyone can see who posted the code and where it came from. Additionally I can give credit to those wo contributed to the project and add a link to their post in my thread. Thank you!

Yep, I already replaced it. It's not that difficult and maybe I'll write a guide to it though everyone will be possible to clearly see it once the project is released.

The major reason for the change from lzo to lz4 is the client, not the server. Of course using a ramdisk or ssd will improve loading times by a lot it doesn't mean everyone will do that. If you're on a laptop chances are that you don't have that many RAM nor an ssd to work with (of course you'd possibly upgrade..). But it's just for the broad masses and getting a faster algorithm is always better as long as it's safe, no matter the circumstances

1.) You're developing for the broad mass of different players. Not everyone has an SSD. Some (like me) are using both SSD and HDD. Also a SSD won't magically fix everything for you since compression/decompression is not only limited to the type of disk you're using.

2.) It's for people who don't want to enable that macro. If you disable it, the server and client will use a combination of lzo and xtea. Also instead of the handshake they'll use the old pong. I never said I'd touch the packet encryption with this macro enabled.

3.) Isn't that a little bit overkill?

Thanks for your suggestions! Yes, something like changing all the new to unique_ptr is a lot of work. I changed a few of them but not all at once. I want to make sure I don't make a mistake there and that's why I think I'll first fix the critical stuff and change them with future updates since the main goal was to create a stable binary. But the suggestion is good, I also had the wish to change at least most of the raw pointers into unique_ptr..

Sound great, Socialized. I'd love to! I'm also planning on developing the config with c++. The one I presented earlier was with c# but I want to move to qt and therefore do it in c++.

Would love to hear your opinion about the other two points.

Also, if anyone has any suggestion, feel free to post them here

1.) Yes. Compression speed is slower than in lz4, but the decompression speed is very fast. Since the package-files are only compressed once (when you put them together to create an epk and eix archive) it's by far faster than with lzo or lz4. Your users will experience faster loading times. Packets will be compressed too but that's not a problem since they're small enough that the slower compression speed doesn't slow down the connection at all.

2.) Me too. And it's also faster than xtea

3.) Some options will be better adjustable than in the old config. There will also be new options, I've shared some screens before but since my HDD crashed I couldn't release the config. But for more options there is some work on the client that needs to be done. I'd for example add v-sync, anti-aliasing or texture filtering. Especially on the graphics side there's a lot we can improve without much effort.

Hello dear dev's,

this thread is created just to suite one specific topic: The vanilla core. I'd like to announce that the new version will be released very soon (this time open source). Meanwhile I'd like you to take part in it! I have some few suggestions that I'd like to commit. But not only this - I want to read your suggestions. What do you think could be part of the new vanilla core versions? The topic is also meant for the future, so when I release the core it's thread is only for troubleshooting and feedback. Features etc. can be discussed here then to give you a better overview about the project.

Also I want to note one small thing: I do not recommend  anyone to use the older vanilla core distributions! This has one simple reason: They're outdated. New security breaches were discovered and they are not fixed in those binaries. If you're using the source you can fix them by yourself. But I recommend you to wait for the new version.

At first I'd like to say that there will be 3 different versions. All have their own codenames and have a different set of features:

- STABLE: This branch is only focused on the main goal of the vanilla core - a core that is smooth, stable and fast along with many, many CONFIG-options to choose from so you can suit the core by yourself. Feature changes will be delayed until they're approved by testing on a different branch. Security fixes will be tested directly and pushed to this branch as soon as possible to ensure a secure experience.

- BETA: This branch is focused on testing feature changes. They could be unstable, but of course the aim is not to be. It's not recommended to use this on production servers, only for testing purposes. New features will be pushed directly to this branch and a core along with it's source code will be released as soon as possible.

- SANDBOX: Yep, I want to create a sandbox. This way I can re-develop features I would've released with my project (damn the HDD crash). In this branch you can suggest features that may not suit everyone. It's mainly for releasing working features and concepts and play a bit with the source.

One side note: I won't use git nor svn. I'll develop locally and upload the core along with it's sources accordingly. Everyone is free to implement their own code and send it to me. After I've reviewed it chances are it'll get into the next vanilla version.

So, there are the first few things I'd like to ask you.

1.) What do you think about the option to have another compression algorithm? (I'll also release the client part along with an archiver). My choice would be lz4hc instead of lzo and I'd like to give you the option to switch between those two compressions. Of course standard would be lzo to ensure compatibility.

2.) What do you think about new ways of encryption when not defining the advanced security macro? Normally this would lead into a pong being sent and xtea being used for encryption. I'd change xtea with something else - my choice would be AES-256.

3.) What would you think about a new client config? Of course it'd be open source.

Let me hear your opinions and please feel free to give me every suggestion you may have.