VegasForPresident

yoo @ Owsap CAN I GET THIS MA BOY

#if defined(ENABLE_TAB_NEXT_TARGET)
		case KEY_NEXT_TARGET:
			SelectNearTarget();
			break;
#endif

IM TALKING ABOUT THE "SelectNearTarget();"   ( Smiley is the best!) 

7 minutes ago, Mali said:

It's not fix, you are using wrong function.

check my last update and tell the result

Still core crash bro..  why i cant use the other one? Everything work good there  

@ Mali It works after i change BYTE to INT .. 

        for (int i = 0; i < MAX_APPLY_NUM; ++i)
        {
            const TItemAttrTable& r = g_map_itemAttr[i];

            if (r.bMaxLevelBySet[iAttributeSet] && !__HasAttr(i))
            {
                avail.push_back(i);
                total += r.dwProb;
            }
        }

Mali i can prove it to u if u dont believe give me your discord addy   its because of byte / int

3 minutes ago, Rakancito said:

std::bad_alloc It's because you have a serious memory allocation problem, maybe you will need say if it happened on the first try or after many try's, but I think that you but i think you need to check all your code or check if you have any missing code snippets.

I haven't had problems, although I arranged some fragments in my own way.

https://metin2.download/picture/klRi93Xd3QFXt1eF0Rj4yJWfQyACU96t/.jpg

 

Everything is implemented correct. I use gcc8 & FreeBSD 13

if i comment 

	static constexpr BYTE aiAttrPercentTable[ITEM_ATTRIBUTE_MAX_LEVEL] = { 0, 10, 40, 35, 15 };
	for (BYTE c = __GetAttributeCount(); c < GetAttributeCount(); c++)
	{
		int iAttrLevelPercent = number(1, 100);
		BYTE i;

		for (i = 0; i < ITEM_ATTRIBUTE_MAX_LEVEL; ++i)
		{
			if (iAttrLevelPercent <= aiAttrPercentTable[i])
				break;

			iAttrLevelPercent -= aiAttrPercentTable[i];
		}

		__PutAttributeWithLevel(i + 1);
	}

in void CItem::GetSelectAttr(TPlayerItemAttribute(&arr)[ITEM_ATTRIBUTE_MAX_NUM])

The core crash is gone but also there is no new attributes on the right side

Edit: I Solved the problem. I Changed: 

		for (BYTE i = 0; i < MAX_APPLY_NUM; ++i)
		{
			const TItemAttrTable& r = g_map_itemAttr[i];

			if (r.bMaxLevelBySet[iAttributeSet] && !__HasAttr(i))
			{
				avail.push_back(i);
				total += r.dwProb;
			}
		}

with

		for (int i = 0; i < MAX_APPLY_NUM; ++i)
		{
			const TItemAttrTable& r = g_map_itemAttr[i];

			if (r.bMaxLevelBySet[iAttributeSet] && !HasAttr(i))
			{
				avail.push_back(i);
				total += r.dwProb;
			}
		}

Thanks for not helping  

@ Mali  terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc

Core crash after taking item on item2 (not even the select attr window is opened) 

 anyone else ? why  

In fact it had nothing to do with mailbox. I solved my problem it was a mistake i made during the implementation of mailbox   

Suggestion: If you read the GM - Mail the GM Icon should go away.  

Just now, Mali said:

hmm

 

I think the problem is at your packets.

oh okay  

Does anyone know why i'm experiencing a kick after each warp? Besides that everything works perfect.

I receive this error in game core: 

SYSERR: Sep 19 18:00:13 :: Analyze: login phase does not handle this packet! header 3
SYSERR: Sep 19 18:00:13 :: Process: UNKNOWN HEADER: 47, LAST HEADER: 3(109), REMAIN BYTES: 11, fd: 22
SYSERR: Sep 19 18:02:37 :: Analyze: login phase does not handle this packet! header 3
SYSERR: Sep 19 18:02:37 :: Process: UNKNOWN HEADER: 47, LAST HEADER: 3(104), REMAIN BYTES: 11, fd: 22
SYSERR: Sep 19 18:05:16 :: Analyze: login phase does not handle this packet! header 3
SYSERR: Sep 19 18:05:16 :: Process: UNKNOWN HEADER: 47, LAST HEADER: 3(100), REMAIN BYTES: 11, fd: 22

@ Mali I KNOW YOUR DOING PARTY AT THE MOMENT BRO BUT IS IT JUST ME ?  WHY I DO GET THIS ERROR  ;( 

Owsap + Mali = Mowsap ? ! ;D 

On 9/16/2021 at 3:06 PM, Owsap said:

He is already giving us a clue of what's coming next, just pay attention to the details and you will notice it.

Its either premium private shop (in my opinion impossible)

glove or 6/7th attribute. xD really hyped  

@ Mali you should do a trailer for upcoming releases xD 

WTF WHAT'S NEXT?? XD

Imagine he drops ENABLE_KEYCHANGE_SYSTEM from gfroot 2k18 too, BANGER then

11 hours ago, Owsap said:

Give this guy an award for sharing what I would call “premium systems” with logical and modern coding while he could be selling it for wasting his time and knowledge of the Metin2 sources, instead he does it for free and adores sharing his work with the community. He has over 70 repositories related to Metin2 systems on his GitHub and you can clearly see from the first repositories to the last that he is evolving his skills from each system he develops. I hope you also apply these skills in the real-world programing if you aren’t already. It’s very rare to see developers that are actually talented and have a lot of experience in the Metin2 sources / environment to actually share their knowledge for free. Big thumbs up to you @Mali and to all the other developers that contribute to the private server community because without them we wouldn’t have half of what we have today.

He is the metin2 dragon god !

I really love you man, i need to change my name in MaliForPresident!!

Sorry @ VegaS™ im really sorry buddy.

Could someone give me an example of a c++ function in char.cpp to get the current experience in % I need this for questlua_pc

5 hours ago, CRiQ said:

curious too! If you managed to do it please add me on discord. CRiQ#6969 . Thanks

I'll answer you with that account, because i have no longer access to the other one, no i didnt. But i deleted this system because a great developer said it isnt good. I'm currently waiting for someones premium private shop i'll buy.