VegaS™

October 2, 2019

On 10/2/2019 at 1:32 AM, dracaryS said:


class QueuePython(object):
	def __init__(self):
		self.eventList=[]
	def __del__(self):
		if len(self.eventList) > 0:
			self.eventList.clear()
	def Process(self):
		if len(self.eventList) > 0:
			for j in xrange(len(self.eventList)):
				if app.GetTime() > self.eventList[j]["time"]:
					i = self.eventList[j]["func"]()
					if i == 0:
						self.eventList[j].clear()
					else:
						self.eventList[j]["time"] = app.GetTime()+i
	def AppendEvent(self,name,func,time):
		self.eventList.append({"name":str(name),"func":__mem_func__(func),"time":int(app.GetTime()+time)})

Thanks for release, the idea isn't bad, but there're some bad things.
I'll show you the problems part and how can be improved, there're just advices, i hope you'll get them.

def __del__(self):
	if len(self.eventList) > 0:
		self.eventList.clear()

If you're using Python 2+ or Python 3.2 and below, you can't use the clear() method (allowed on 3.3+), also as i said in the second message you don't need to check the length of the list, already the clear() method doing that inside and there's no reason to put it to __del__ method, it will be called when the object is garbage collected. if you really want to use in future, something outside of this and want just to check the list if isn't empty, is enough to do it just with if some_list, like a normal boolean, there no need to check the length of the list if you don't use it in your code.

if len(self.eventList) > 0:
	for j in xrange(len(self.eventList)):
		[...]

You don't have to check the list if you already did a numeric range loop or iterator based loop.

Spoiler


self.eventList = []
''' example 1 '''
for i in xrange(len(self.eventList)):
    print (self.eventList[i])
''' example 2 '''
for event in self.eventList:
    print (event)
#<nothing will be printed>

```
app.GetTime() +  time
```

I would say to use app.GetGlobalTimeStamp() instead of app.GetTime(), if you teleport while the event is running, the event function will run after 10 seconds like. While app.GetGlobalTimeStamp() will run after the specific time, because is the server timestamp and is updated on each enter in game.

```
if i == 0:
	self.eventList[j].clear()
```

I would put here an big exclamation, with this you creating 999999999 lines in syserr, what you do here is like:

While Process() function is called in OnUpdate, so, your condition trying to get the returned value from an specific function, what means the next update time or 0 to destroy the event/clear it. Everything's fine until you return 0 and event should be stopped yes? But there is a problem, you clear the specific dictionary of event and still remained in the list [{}], and the Process() function will take your self.eventList with the items included, the empty dictionaries from your events, and of course even if you've [{}, {}, {}], that doesn't mean your list is empty, have 3 items, so, the loop will trying to read an empty dictionary and you'll get key errors in each milisecond. The method which you need is to delete the dictionary itself from the list after the result value from the function is 0, like this:

Spoiler


del self.eventList[j]

_______________________________________

I wrote fast some self extensions, if somebody is interested i'll do another updates in the next days.

You can use unlimited arguments on functions, now is using the apply method which returns the result of a function or class object called with supplied arguments, with the old structure you could use just one argument.
You can lock/unlock an event for being processed, it's like a prevent in some actions, if the event is created and you want to do something, you should lock the event, do some actions then you can unlock it again and the process function will run where remained.
Delete an event instantly and force it to stop the process.
Adding return t.EXIT inside of the running function, will delete the event too.
Functions to check if an event exists or is locked or not.
Check if the function is a method type.
Delete the events with a properly method.
Using app.GetGlobalTimeStamp() now will give you the chance to run the event after teleport where timer remained instantly.

Spoiler


t = ui.Queue()
# ex1
t.AppendEvent(eventName='RUN', eventStartTime=0, eventFunc=self.Run)
# ex2
t.AppendEvent(eventName='RUN', eventStartTime=0, eventFunc=self.Run, eventFuncArgs=player.GetLevel())
# ex3
t.AppendEvent(eventName='RUN', eventStartTime=0, eventFunc=self.Run, eventFuncArgs=(player.GetLevel(), player.GetName()))
# ex4
t.AppendEvent('UPDATE', 0, self.Update, {'data' : (1, True, (14, 12), [5, 1], 'Corsair')})

# Others:
if t.GetEvent('RUN'):
	print ("The event exists.")

if t.GetIsLockedEvent('RUN'):
	print ("The event exists but is locked.")
    
t.LockEvent('RUN')
t.UnlockEvent('RUN')
t.DeleteEvent('RUN')

_______________________________________

The code:

This is the hidden content, please

PS: Don't quote this reply, will be updated.

October 1, 2019

1 hour ago, glosteng4141 said:

IMAGE

Download

(2.4) Content

Don't post commercial stuff others made and/or sell commercial stuff others made.

Spoiler

@kiyagan

October 1, 2019

@ReFresh You used a small extension which i did for you 3 years ago.

Spoiler

If somebody still have this problem, you need to check the key of the dictionary like:

This is the hidden content, please

October 1, 2019

Moved to:

This is the hidden content, please

October 1, 2019

M2 Download Center

This is the hidden content, please

Sign In

or

Sign Up

( Internal )

This is the hidden content, please

Sign In

or

Sign Up

( GitHub )

I added two years ago a small function that allow you to make a struct like C++ for different purposes.

# Example #1

    pack = ui.RegisterStructClass('a b c')(15, {}, [])
    pack.a += 50
    pack.b.update({0: 250})
    pack.c.append(100)
    print (pack.a, pack.b, pack.c)

# Example #2.

    def Transfer(self, p):
		print(p.szName, p.lX, p.lY)

    self.Transfer(ui.RegisterStructClass('szName lX lY')(GetName(), GetX(), GetY()))

# Example #3.

config = ui.RegisterStructClass('width height default_size_dict rank_list text')(450, 300, {'w': 400, 'h': 500}, [1, 2, 3], 'Metin2')

print (
	config.width, config.height, config.text,
	config.default_size_dict.get('w'), config.default_size_dict.get('h'),
	config.rank_list
)

Repository:

This is the hidden content, please

Sign In

or

Sign Up

October 1, 2019

Moved to git.

This is the hidden content, please
- Sign In
- or
- Sign Up

October 1, 2019

Updated v1.1 - Fixed limited string format

October 1, 2019

29 minutes ago, ReFresh said:

Could it look like this?

No, you need to add the condition before inserting the entity.

Spoiler


class CFuncViewInsert
{
	private:
		int dwViewRange;

	public:
		LPENTITY m_me;

		CFuncViewInsert(LPENTITY ent) :
			dwViewRange(VIEW_RANGE + VIEW_BONUS_RANGE),
			m_me(ent)
		{
		}

		void operator () (LPENTITY ent)
		{
			// 오브젝트가 아닌 것은 거리를 계산하여 거리가 멀면 추가하지 않는다.
			if (!ent->IsType(ENTITY_OBJECT))
				if (DISTANCE_APPROX(ent->GetX() - m_me->GetX(), ent->GetY() - m_me->GetY()) > dwViewRange)
					return;
				
#ifdef HIDDEN_OX
			if (ent->IsType(ENTITY_CHARACTER) && m_me->IsType(ENTITY_CHARACTER))
			{
				const LPCHARACTER chMe = static_cast<LPCHARACTER>(m_me);
				const LPCHARACTER chEnt = static_cast<LPCHARACTER>(ent);

				if (chMe->GetMapIndex() == OXEVENT_MAP_INDEX && !chMe->IsGM() && !chEnt->IsGM())
					return;		
			}
#endif
			// 나를 대상에 추가
			m_me->ViewInsert(ent);

			// 둘다 캐릭터면
			if (ent->IsType(ENTITY_CHARACTER) && m_me->IsType(ENTITY_CHARACTER))
			{
				LPCHARACTER chMe = (LPCHARACTER) m_me;
				LPCHARACTER chEnt = (LPCHARACTER) ent;

				// 대상이 NPC면 StateMachine을 킨다.
				if (chMe->IsPC() && !chEnt->IsPC() && !chEnt->IsWarp() && !chEnt->IsGoto())
					chEnt->StartStateMachine();
			}
		}
};

Don't forget:

entity_view.cpp

#include "OXEvent.h"

service.h

#define HIDDEN_OX

September 30, 2019

1 hour ago, Cripplez said:
How exactly i can add a new vnum here? like this?
	if (2493 || 2499 == m_pkMobData->m_table.dwVnum)

http://www.cplusplus.com/doc/tutorial/operators/

	if (m_pkMobData->m_table.dwVnum == 2493 || m_pkMobData->m_table.dwVnum == 2499)

Posted September 28, 2019 · September 28, 2019

31 minutes ago, ReFresh said:
I got some error when I tried to compile source:
source\gamelib\../UserInterface/AbstractPlayer.h(30): error C2061: syntax error : identifier 'TItemPos'

UserInterface/AbstractPlayer.h

Try to include:

#include "GameType.h"

September 28, 2019

The idea isn't so bad, but the code has too many useless lines, here's what you can do to improve it.

	def RefreshPickupFilter(self):
		#Weapon
		if systemSetting.IsPickUpFilterWeapon():
			self.PickUpFilterList[0].Down()
		else:
			self.PickUpFilterList[0].SetUp()
		#Armor
		if systemSetting.IsPickUpFilterArmor():
			self.PickUpFilterList[1].Down()
		else:
			self.PickUpFilterList[1].SetUp()
		#Ear
		if systemSetting.IsPickUpFilterEar():
			self.PickUpFilterList[2].Down()
		else:
			self.PickUpFilterList[2].SetUp()
		#Neck
		if systemSetting.IsPickUpFilterNeck():
			self.PickUpFilterList[3].Down()
		else:
			self.PickUpFilterList[3].SetUp()
		#Foots
		if systemSetting.IsPickUpFilterFoots():
			self.PickUpFilterList[4].Down()
		else:
			self.PickUpFilterList[4].SetUp()		
		#Shield
		if systemSetting.IsPickUpFilterShield():
			self.PickUpFilterList[5].Down()
		else:
			self.PickUpFilterList[5].SetUp()		
		#Book
		if systemSetting.IsPickUpFilterBook():
			self.PickUpFilterList[6].Down()
		else:
			self.PickUpFilterList[6].SetUp()		
		#Stone
		if systemSetting.IsPickUpFilterStone():
			self.PickUpFilterList[7].Down()
		else:
			self.PickUpFilterList[7].SetUp()		
		#Etc
		if systemSetting.IsPickUpFilterEtc():
			self.PickUpFilterList[8].Down()
		else:
			self.PickUpFilterList[8].SetUp()

To:

def RefreshPickupFilter(self):
	checkFilterList = (
		systemSetting.IsPickUpFilterWeapon(), systemSetting.IsPickUpFilterArmor(),
		systemSetting.IsPickUpFilterEar(), systemSetting.IsPickUpFilterNeck(),
		systemSetting.IsPickUpFilterFoots(), systemSetting.IsPickUpFilterShield(),
		systemSetting.IsPickUpFilterBook(), systemSetting.IsPickUpFilterStone(),
		systemSetting.IsPickUpFilterEtc()
	)
	
	for child, flag in zip(self.PickUpFilterList, checkFilterList):
		if flag:
			child.Down()
		else:
			child.SetUp()

			self.PickUpFilterList.append(GetObject("Pick_Up_FilterWeapon"))
			self.PickUpFilterList.append(GetObject("Pick_Up_FilterArmor"))
			self.PickUpFilterList.append(GetObject("Pick_Up_FilterEar"))
			self.PickUpFilterList.append(GetObject("Pick_Up_FilterNeck"))
			self.PickUpFilterList.append(GetObject("Pick_Up_FilterFoots"))
			self.PickUpFilterList.append(GetObject("Pick_Up_FilterShield"))
			self.PickUpFilterList.append(GetObject("Pick_Up_FilterBook"))
			self.PickUpFilterList.append(GetObject("Pick_Up_FilterStone"))
			self.PickUpFilterList.append(GetObject("Pick_Up_FilterEtc"))

To:

for name in ('Weapon','Armor','Ear','Neck','Foots','Shield','Book','Stone','Etc'):
	self.PickUpFilterList.append(GetObject("Pick_Up_Filter{}".format(name)))

		self.PickUpFilterList[0].SetToggleUpEvent(self.__OnClickPickupFilterButtonWeapon) # Weapon
		self.PickUpFilterList[0].SetToggleDownEvent(self.__OnClickPickupFilterButtonWeapon) # Weapon
		self.PickUpFilterList[1].SetToggleUpEvent(self.__OnClickPickupFilterButtonArmor) # Armor
		self.PickUpFilterList[1].SetToggleDownEvent(self.__OnClickPickupFilterButtonArmor) # Armor
		self.PickUpFilterList[2].SetToggleUpEvent(self.__OnClickPickupFilterButtonEar) # Ear
		self.PickUpFilterList[2].SetToggleDownEvent(self.__OnClickPickupFilterButtonEar) # Ear
		self.PickUpFilterList[3].SetToggleUpEvent(self.__OnClickPickupFilterButtonNeck) # Neck
		self.PickUpFilterList[3].SetToggleDownEvent(self.__OnClickPickupFilterButtonNeck) # Neck
		self.PickUpFilterList[4].SetToggleUpEvent(self.__OnClickPickupFilterButtonFoots) # Foots
		self.PickUpFilterList[4].SetToggleDownEvent(self.__OnClickPickupFilterButtonFoots) # Foots
		self.PickUpFilterList[5].SetToggleUpEvent(self.__OnClickPickupFilterButtonShield) # Shield
		self.PickUpFilterList[5].SetToggleDownEvent(self.__OnClickPickupFilterButtonShield) # Shield
		self.PickUpFilterList[6].SetToggleUpEvent(self.__OnClickPickupFilterButtonBook) # Books
		self.PickUpFilterList[6].SetToggleDownEvent(self.__OnClickPickupFilterButtonBook) # Books
		self.PickUpFilterList[7].SetToggleUpEvent(self.__OnClickPickupFilterButtonStone) # Stone
		self.PickUpFilterList[7].SetToggleDownEvent(self.__OnClickPickupFilterButtonStone) # Stone
		self.PickUpFilterList[8].SetToggleUpEvent(self.__OnClickPickupFilterButtonEtc) # Etc
		self.PickUpFilterList[8].SetToggleDownEvent(self.__OnClickPickupFilterButtonEtc) # Etc

To:

eventFuncList = (
	self.__OnClickPickupFilterButtonWeapon, self.__OnClickPickupFilterButtonArmor, self.__OnClickPickupFilterButtonEar,
	self.__OnClickPickupFilterButtonNeck, self.__OnClickPickupFilterButtonFoots, self.__OnClickPickupFilterButtonShield,
	self.__OnClickPickupFilterButtonBook, self.__OnClickPickupFilterButtonStone, self.__OnClickPickupFilterButtonEtc
)

for child, event in zip(self.PickUpFilterList, eventFuncList):
	child.SetToggleUpEvent(event)
	child.SetToggleDownEvent(event)

Buffs to All Party Members · September 25, 2019

1 hour ago, sonyc73 said:

after tests is doing crash core, but i don`t know why

There's no check for victim pointer.

// Replace:
if (pkVictim->GetParty())
// With:
if (pkVictim && pkVictim->GetParty())

September 25, 2019

On 9/23/2019 at 10:29 PM, Rakancito said:


		if (pkAttacker->IsRiding())
		{
			bool bAttacking = (get_dword_time() - pkAttacker->GetLastAttackTime()) < 800;
			if (!bAttacking)
				return BATTLE_NONE;
		}
		else
		{
			bool bAttacking = (get_dword_time() - pkAttacker->GetLastAttackTime()) < 750;
			if (!bAttacking)
				return BATTLE_NONE;
		}

Let's don't kill the source with dozens of useless lines and duplicated.

		const bool bAttacking = (get_dword_time() - pkAttacker->GetLastAttackTime()) < pkAttacker->IsRiding() ? 800 : 700;
		if (!bAttacking)
			return BATTLE_NONE;

September 25, 2019

On 9/25/2019 at 1:50 AM, ManiacRobert said:

Spoiler

		void operator () (LPENTITY ent)
		{
			// 오브젝트가 아닌 것은 거리를 계산하여 거리가 멀면 추가하지 않는다.
			if (!ent->IsType(ENTITY_OBJECT))
				if (DISTANCE_APPROX(ent->GetX() - m_me->GetX(), ent->GetY() - m_me->GetY()) > dwViewRange)
					return;

#ifdef HIDDEN_OX
			if (ent->IsType(ENTITY_CHARACTER) && m_me->IsType(ENTITY_CHARACTER))
			{
					LPCHARACTER chMe = (LPCHARACTER)m_me;
					LPCHARACTER chEnt = (LPCHARACTER)ent;
					if (chMe->IsPC() && chEnt->IsPC() && !chMe->IsGM() && !chEnt->IsGM() && chMe->GetMapIndex() == 113 && chEnt->GetMapIndex() == 113)
						return;		
			}
#endif

Since already is a check for distance, is impossible that the entity to be in another map, so is enough to check if you're in the map.

This is the hidden content, please

September 24, 2019

I didn't tested the bug, but you can try something like this:

Srcs/Server/game/src/questmanager.cpp

This is the hidden content, please

September 23, 2019

Check if passed 10 seconds after the action for:

Safebox, exchange, shop, refine

Check if the window is open:

Exchange, shop, private shop, safebox, cube

How-To-Use: (already a lot of metin2 quests using this)

Spoiler


when 50513.use begin
	if not pc.can_warp() then
		syschat("Wait 10 seconds, you can't make this right now.")
		return
	end
	-----
end

September 23, 2019

std::string g_strEffectName = "d:/ymir work/effect/etc/direction/direction_land.mse";

September 22, 2019

Users:

How-to install the VSIX extension

September 18, 2019

(2.5) Questions & Answers specific rules

Don't modify your thread (or reply to it) to mark it solved, and not explain the solution to the issue.

For those who want this, you can do something like: [Not tested]

This is the hidden content, please

Sign In

or

Sign Up

September 15, 2019

Default:

Shinshoo - 1
Chunjo - 2
Jinno - 3

local sel = select("Chunjo", "Jinno", "Exit")
Chunjo = sel + 1 = 2
Jinno = sel + 1 = 3
Exit = 3 -- return

All what you need is to make the select value + 1.

This is the hidden content, please

Sign In

or

Sign Up

September 15, 2019

I didn't test it, but you can try to do something like this:

This is the hidden content, please

Sign In

or

Sign Up

September 14, 2019

9 hours ago, zeimpekis9 said:

How i modify it, to mob_drop_item etc?

Here you've some hints, good luck.

September 10, 2019

You should use a string format method, instead of convert an integer to string then concatenate two strings for no reason.

This is the hidden content, please

September 7, 2019

Designed by Chaccc

Spoiler

September 6, 2019

@PACI @DevChuckNorris @arves100

Spoiler

Sign In

Forums

Store

Third Party - Providers Directory

Feature Plan

Release Notes

Docs

Events

Posts posted by VegaS™

Important Information