Nebi

DragonSoul.cpp:516:18: warning: the compiler can assume that the address of 'aItemPoses' will never be NULL [-Waddress]



DragonSoul.cpp:516:9: warning: 'nonnull' argument 'aItemPoses' compared to NULL [-Wnonnull-compare]

	if (NULL == aItemPoses)
	{
		return false;
	}

can you help me?

3 hours ago, spectrum said:

it's missing itertype(m_listArena) iter = m_listArena.begin();

on top for (; iter != m_listArena.end(); iter++)

 

 

 

Full function code:

bool CArenaMap::AddArena(DWORD mapIdx, WORD startA_X, WORD startA_Y, WORD startB_X, WORD startB_Y)
{
	itertype(m_listArena) iter = m_listArena.begin();

	for (; iter != m_listArena.end(); iter++)
	{
		if ((CArena*)(*iter)->CheckArea(startA_X, startA_Y, startB_X, startB_Y) == false)
		{
			sys_log(0, "CArenaMap::AddArena - Same Start Position set. stA(%d, %d) stB(%d, %d)", startA_X, startA_Y, startB_X, startB_Y);
			return false;
		}
	}

	m_dwMapIndex = mapIdx;

	CArena *pArena = M2_NEW CArena(startA_X, startA_Y, startB_X, startB_Y);
	m_listArena.push_back(pArena);

	return true;
}

is there anything missing here?

45 minutes ago, spectrum said:

bool CArenaMap::AddArena(DWORD mapIdx, WORD startA_X, WORD startA_Y, WORD startB_X, WORD startB_Y)
{
	itertype(m_listArena) iter = m_listArena.begin();

	for (; iter != m_listArena.end(); iter++)
	{
		if ((CArena*)(*iter)->CheckArea(startA_X, startA_Y, startB_X, startB_Y) == false)
		{
			sys_log(0, "CArenaMap::AddArena - Same Start Position set. stA(%d, %d) stB(%d, %d)", startA_X, startA_Y, startB_X, startB_Y);
			return false;
		}
	}

 

I did not understand.

I'm getting an error when compiling Metin2 gcc11 c++20. Can you help me?

game/src/arena.cpp

ERROR:

arena.cpp: In member function 'bool CArenaMap::AddArena(DWORD, WORD, WORD, WORD, WORD)': arena.cpp:83:89: error: ISO C++ forbids comparison between pointer and integer [-fpermissive] 83 | if ((CArena*)(*iter)->CheckArea(startA_X, startA_Y, startB_X, startB_Y) == false) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~

bool CArenaMap::AddArena(DWORD mapIdx, WORD startA_X, WORD startA_Y, WORD startB_X, WORD startB_Y) { itertype(m_listArena) iter = m_listArena.begin();

for (; iter != m_listArena.end(); iter++)
{
    if ((CArena*)(*iter)->CheckArea(startA_X, startA_Y, startB_X, startB_Y) == false)
    {
        sys_log(0, "CArenaMap::AddArena - Same Start Position set. stA(%d, %d) stB(%d, %d)", startA_X, startA_Y, startB_X, startB_Y);
        return false;
    }
}