Finnael

Thanks guys, glad you like it.

As you might know I was working on a Reworked version of the character window for a long time. I shared some of my progress on Discord and today I am relasing it to public. I am not gonna write any detailed guide here on how to implement it as there is enough information written in the file itself both on how to install and how to configure it. All you need to know is there are two different versions: base version is the first video I shared and the equipment set version is the second video. To implement equipment set version you need to make some changes in the server source. Base version can be implemented without doing any changes in the server source. Hope you all like it!

1 hour ago, ProjectOW2 said:

the fucntion is no work for me. without any syserr.

Try again with updated files, you probably needed this

open input_main.cpp:

#1.) Find:
    case HEADER_CG_FAST_STACK:
        if (!ch->IsObserverMode())
            FastStack(ch, c_pData);
            break;
            
#2.) Add after:
void CInputMain::FastStack(LPCHARACTER ch, const char* c_pData)
{
    TPacketCGFastStack* p = (TPacketCGFastStack*)c_pData;
    

    if (ch)
        ch->FastStack(p->pos);
}

On 11/3/2020 at 11:21 PM, Kafa said:

I have implemented it, but doesnt work and no syserr too

Updated the files, try implementing again. (Forgot to include some files sorry)

https://metin2.download/picture/aHTGO25e99i2dPK6H8c8Qxm5Kv2tth4R/.gif

The system allows you to combine the same items in one click. Might create some lag if you are trying to combine lots of item. Made by me. I hope to see a similar system in big servers. Stay safe.

(Would be cool if someone can implement the system and share the results here. Might have forgot few things )

On 11/1/2020 at 7:15 PM, HITRON said:

		if (iSlot >= 0 && iSlot <= INVENTORY_MAX_NUM && bCount >= 0 && bCount <= g_bItemCountLimit)
		{
			LPITEM item = ch->GetInventoryItem(iSlot);

			if (item)
			{
				BYTE bItemCount = item->GetCount();

				TItemPos ItemCell;

				ItemCell.window_type = INVENTORY;
				ItemCell.cell = item->GetCell();

				for (int i = 0; i < (bItemCount / bCount) - 1; ++i)
				{
					int iEmptySlot = ch->GetEmptyInventory(item->GetSize());

					TItemPos DestItemCell;

					DestItemCell.window_type = INVENTORY;
					DestItemCell.cell = iEmptySlot;

					ch->MoveItem(ItemCell, DestItemCell, bCount);
				}
			}
		}

 

With command that using args - (Item Slot & Split Count)

 

I don't know why you copy the Item, but items that can be Split have no Sockets & Bonus random so the copy seems useless (Is just a move from the count of the item).

Is this your split function? If it is I'd like to see a video of you trying to split all the items by 1 in a completly empty inventory. And yours doesn't do backward searching. Yeah maybe you can further optimize it without copying the socket and attributes, I haven't tried it tbh.

A very fast item split system written by me. A very optimized one. Instead of sending hundered of packets it only sends maybe a dozen max. It is searching algorithm is also better than most split systems. It can do

backward searching.

This system adds new pages for DS inventory. The system is written by me.

Wow this is such a treasure! Thanks for sharing.

Try this: 

Send us your char.h.

Hmm, this is not enough need your char.cpp too.

Thanks for the very detailed guide. Pretty helpful.

If you have this problem like me where RenderTarget renders the lod versions of the models you can do the the following thing to fix it. (You can also simply delete the lod files from your pack but you are gonna have to do it for every class and every armor that class wears. Besides that you can also have huge performance problems. There is a reason why LOD exists.)

Open EterGrnLib/ThingInstance.h

//1.)Find
    void        SetMotionAtEnd();

//2.) Add after:
    void        SetSkipLod(bool value) { m_bSkipLod = value; }
    bool        GetSkipLod() { return m_bSkipLod; }

//3.) Find:
std::map<DWORD, CGraphicThing::TRef*>    m_roMotionThingMap;
//4.) Add after:
bool                                    m_bSkipLod;

Open EterGrnLib/ThingInstance.cpp

//1.) Find:
	m_v3Center = D3DXVECTOR3(0.0f, 0.0f, 0.0f);
//2.) Add after:
	m_bSkipLod = false;

//3.) Find:
	CCamera* pcurCamera = CCameraManager::Instance().GetCurrentCamera();
//4.) Add before:
	if (m_bSkipLod)
		return;

Open EterLib/CRenderTarget.cpp

//1.) Find:
	m_pModel->GetGraphicThingInstancePtr()->ClearAttachingEffect();
//2.) Add before:
	m_pModel->GetGraphicThingInstancePtr()->SetSkipLod(true);

This should be enough to fix the issue. Note that this bug does not happen on every versions of granny. Just try to render a player model with render target and if your character looks like mine then you can apply this to fix it.

So the gr2 files that are saved with this tool will be loaded faster? Is that what you mean with better performance? Thanks for the tool btw.

Hmm, these look fine. From what I can see packet with header 43 is only being send to the client when player sitdowns or stand ups. So the problem should not be related with that if you are not doing anything. Can you show us your UserInterface/PythonNetworkStreamPhaseGame.cpp and UserInterface/PythonNetworkStream.cpp too? And btw which files are you using? Are you sure the client and the server you are using are meant to be used together? If you take your client from one files and your server from another that will cause such issues.

Can you show us your packet.h inside your server source(should be inside game/src/packet.h) and your Packet.h inside your client source(should be inside UserInterface/Packet.h)? 

Not everyone has time to build the file. Just share the build error. It is not so hard to take a screenshot and upload it lol.

Does it happen randomly or are you kicked after doing a specific thing?

Yeah, but not only the color. It just looks too flat imo. Especially compared to the rest of the map.

The atmosphere really looks great on this one. Only the field where guilds fight looks kinda out of place I think.

Aside from the shoes it looks really cool. Nice job. 

If you wanna initialize some class members with default values I think the best way is to use constructors.

So for the SShopItemTable you can do something like this:

    SShopItemTable()
    {
        vnum = 0;
        count = 0;
        pos = TItemPos();
        price = 0;
    }

What this will do is when a new SShopItemTable object is created it will initialize it with these values.

7 hours ago, MEKA said:

Sura Enchanted Blade Skill Problem

 

Skill off: https://metin2.download/picture/Vhkc63uvwbv81VyeibLa9883n307mrZ5/.gif

Skill on: https://metin2.download/picture/ADeFvJq66ipYWB9Y9St6Ojdm7fL9ut0W/.gif

Send us your uitooltip.py.

2 hours ago, Shang said:

 

It isn't. You should be able to do this:

https://metin2.download/picture/Qnb77z7d6E8OLwQru4I3201eaK89kiK8/.gif

That's what this fix offers.

Yeaah, still you can do it all in python I believe. Not saying you should.

6 minutes ago, Syreldar said:

Oh you quoted me on a 2 year old post haha

No, he wrote that for me.

I don't know how but we should be able to fix these bugs without touching the C++ code. Character window system I am working on doesn't have these bugs even though I didn't apply the fixes here. I am just updating the skill slots differently in python than the default character window and I think that fixes the bugs somehow.

Okay, this should be enough to fix the bugs shown in the topic (hopefully)

uicharacter.py

Find:

	            for j in xrange(skill.SKILL_GRADE_COUNT):
	                skillPage.ClearSlot(self.__GetRealSkillSlot(j, i))
	

Replace with:

	            for j in xrange(skill.SKILL_GRADE_COUNT):
	                if j != player.GetSkillGrade(slotIndex):
	                    skillPage.ClearSlot(self.__GetRealSkillSlot(j, i))