CristianDragan

Updated to VS2022 - c++20, no errors, but I've got these warnings.

https://pastebin.com/FthZCgPu

Hi! It works fine for me, but I've got few issues when I add the part for the target system.

item_manager.cpp: https://pastebin.com/gn7rcYjn

item_manager.cpp: In member function 'bool ITEM_MANAGER::CreateDropItemVector(CHARACTER*, CHARACTER*, std::vector<std::pair<int, int>, std::allocator<std::pair<int, int> > >&)':

item_manager.cpp:946: error: 'item' was not declared in this scope

item_manager.cpp:955: error: 'item' was not declared in this scope

item_manager.cpp:961: error: no matching function for call to 'MOB_DROP_MANAGER::MakeDropInfoItems(CHARACTER*&, CHARACTER*&, std::vector<std::pair<int, int>, std::allocator<std::pair<int, int> > >&)'

mob_drop_manager.h:168: note: candidates are: void MOB_DROP_MANAGER::MakeDropInfoItems(CHARACTER*, CHARACTER*, std::vector<CItem*, std::allocator<CItem*> >&)

Thanks!

Syserr it's empty

Tried something, but got the same thing. I can see the name, but it's from another item. And the price that's showing it's 0. I don't remember if it's correctly or not, but it's showing the price on top of the name, description, etc.

Sure, thank you for your time.

uitooltip.py: https://pastebin.com/kbk98TKk

You can see the problem in the video. It's a short one.

I tried something, I could see the name, but the name of another item from inventory, and without the price that I set to it.

Maybe it's from the source... I don't know. I compared the function def OnOverInItem(self, slotIndex) with another ones from another clients and I didn't find something new...

uiprivateshopbuilder.py: https://pastebin.com/zTnQgfLy

2. SysErr (Client/Server) / SysLog (Server)

Empty

3. How to reproduce it?

You can see the problem in the video. It's a short one.

4. Video

Thanks in advance.

ClientManager.cpp: In member function 'void CClientManager::UpdateChannelStatus(TChannelStatus*)':
ClientManager.cpp:4326:30: error: 'TChannelStatus' has no member named 'player_count' it->second.second = pData->player_count;

ClientManager.cpp:4329:80: error: 'TChannelStatus' has no member named 'player_count' m_mChannelStatus.emplace(pData->nPort, std::make_pair(pData>bStatus, pData->player_count));
 

Thanks in advance

EDIT: Solved the errors, but:  and it changes  (1 player logged in)

EDIT2: Solved.

I tried your method few minutes ago, and I get " need more than 1 value to unpack " at " (accountName, accountPassword) = content.split(':') ". Thank you in advance.

Shouldn't be like (accountName, accountPassword) = content.split('Value1', 'Value2'') ?

Mulțumesc frumos! Apreciez!

Thank you!

Somebody?

@VegaS™ Salut! Am o mică problemă cu sistemul. Sper că mă poţi ajuta.

Totul funcţionează, dar dacă nu selectez un cont din listă, şi folosesc butonul de autentificare în loc de enter, primesc https://pastebin.com/raw/XSv9k8Fz în syserr. 

intrologin.py: https://pastebin.com/kKuYbCJd

Hi! I have a small problem. Hope that you can help me.

Everything works, but if I'm not selecting any account from the list and I use the login button instead of enter, I get https://pastebin.com/raw/XSv9k8Fz in syserr.

intrologin.py: https://pastebin.com/kKuYbCJd

Mulţumesc frumos!

Thank you!

Tried with your latest edit, and I get this error when compiling : 

char_item.cpp: In member function 'bool CHARACTER::CanEquipNow(CItem*, const TItemPos&, const TItemPos&)':
char_item.cpp:7768: error: argument of type 'DWORD (CItem::)()const' does not match 'DWORD'

Line 7768:      if (isSpeedShoe(item->GetVnum))

You forgot to add an "(" near Vnum and one at the end  

if (isSpeedShoe(item->GetVnum()))

Now it's working.

Thank you.

Solved. Thank you so much for your time and code

1. Description of the problem / Question :

I installed three pair of speed shoes on my server, and I want to know how to make an restriction when trying to equip a second pair of shoes, with that error message: "You cannot equip this item twice."

I already tried something in item.cpp :

else if (GetType() == ITEM_UNIQUE)
    {
        if (ch->GetWear(SPEED_SHOES))
            return SPEED_SHOES2;
        else
            return SPEED_SHOES;

        else
            return SPEED_SHOES3;
    }

but when I'm trying to compile the source I get:  'SPEED_SHOES1/2/3' was not declared in this scope

I allready added UNIQUE_ITEM_SPEED_SHOES = 72701, UNIQUE_ITEM_SPEED_SHOES2 = 72702, UNIQUE_ITEM_SPEED_SHOES3 = 72703,   in unique_item.h.

Sorry for my bad english.

Thanks, Sincerly,
Cristian

Solved by itself, but I don't know how, because I didn't modified anything since last night 

Thanks anyway.

Yes, I have it on D. 

The map looks good on  laptop, but not on PC

2. SysErr ( Client / Server ) / SysLog ( Server )

EMPTY

3. How to reproduce it ?

-

4. Screenshots ?

On PC: 

On laptop:  

Screenshots are taken at the same time, at the same resolutions *1280x768. Does anyone know a solution? And especially, how is this possible?

Thanks, Sincerly,
[[ Cristian ]]

UP

1. Description of the problem / Question :

It's related with the value of the bonuses.

2. SysErr ( Client / Server ) / SysLog ( Server )

3. How to reproduce it ?

This error is appears in syserr only when I'm moving my mouse over items.

4. Screenshots ?

def SA(text):
    def f(x):
        return text % x
    return f

If I'm leaving it in this way " return text % x", it's alright, no problems with the bonuses, but the error appears in syserr, but if I edit it in this way "return text + "%d" % x" for example, the error disappears, but:

game.py : https://pastebin.com/w9ZFLwz3

uiaffectshower.py : https://pastebin.com/xe9H9n5h

localeinfo.py: https://pastebin.com/VRjvn5Zh

Thanks, Sincerly,
Cristian

I found another small problem:

Solved. I attributed "originals" ID's in item_proto to the elixirs.

 Initially I had put some random IDs on them.

72723

72724

72725

72727

72728

72729

3 hours ago, Nirray said:

Change

%d

%d

to 

%.2f%%

%.2f%%

 

Thanks, it worked.

I found another small problem:

28 minutes ago, Kyo said:

try 

self.AppendTextLine(str(localeInfo.TOOLTIP_AUTO_POTION_REST % (100.0 - ((usedAmount / totalAmount) * 100.0))), self.POSITIVE_COLOR)

self.AppendTextLine(str(localeInfo.TOOLTIP_AUTO_POTION_REST % (100.0 - ((usedAmount / totalAmount) * 100.0))), self.POSITIVE_COLOR)

 

 

Nothing has changed, unfortunately. Thanks for the reply.

29 minutes ago, Kyo said:

try 

self.AppendTextLine(str(localeInfo.TOOLTIP_AUTO_POTION_REST % (100.0 - ((usedAmount / totalAmount) * 100.0))), self.POSITIVE_COLOR)

self.AppendTextLine(str(localeInfo.TOOLTIP_AUTO_POTION_REST % (100.0 - ((usedAmount / totalAmount) * 100.0))), self.POSITIVE_COLOR)

 

 

I solved it like this:

self.AppendTextLine(localeInfo.TOOLTIP_AUTO_POTION_REST + "%d" % (100.00 - ((usedAmount/totalAmount) * 100.00)), self.POSITIVE_COLOR)

Do you or anybody know to make it like on official servers? Like 99,99.

Thanks.

I've installed auto potions, they work, PV and PM regenerates, but I can't see how much % are left in them.

Sorry for my bad english.

Photo: 

syserr: 

0426 01:34:24605 :: Traceback (most recent call last):

0426 01:34:24605 ::   File "ui.py", line 1391, in OnOverInItem

0426 01:34:24605 ::   File "ui.py", line 87, in __call__

0426 01:34:24605 ::   File "ui.py", line 78, in __call__

0426 01:34:24605 ::   File "uiInventory.py", line 588, in OverInItem

0426 01:34:24605 ::   File "uiInventory.py", line 756, in __ShowToolTip

0426 01:34:24606 ::   File "uiToolTip.py", line 526, in SetInventoryItem

0426 01:34:24606 ::   File "uiToolTip.py", line 1083, in AddItemData

0426 01:34:24606 :: TypeError
0426 01:34:24606 :: : 
0426 01:34:24606 :: not all arguments converted during string formatting
0426 01:34:24606 ::

uitooltip.py
            ## ŔÚµżą°ľŕ
            elif constInfo.IS_AUTO_POTION(itemVnum):
                if 0 != metinSlot:
                    ## 0: Č°ĽşČ­, 1: »çżë·®, 2: ĂŃ·®
                    isActivated = int(metinSlot[0])
                    usedAmount = float(metinSlot[1])
                    totalAmount = float(metinSlot[2])
                    
                    if 0 == totalAmount:
                        totalAmount = 1
                    
                    self.AppendSpace(5)

                    if 0 != isActivated:
                        self.AppendTextLine("(%s)" % (localeInfo.TOOLTIP_AUTO_POTION_USING), self.SPECIAL_POSITIVE_COLOR)
                        self.AppendSpace(5)
                        
                    1083 LINE -> self.AppendTextLine(localeInfo.TOOLTIP_AUTO_POTION_REST % (100.0 - ((usedAmount / totalAmount) * 100.0)), self.POSITIVE_COLOR)

Thank you in advance!

#Resolved

Somebody?