fix Target board HP percentage when monster HP is above 21 millions

[Distraught 5687]

I think some of you faced this bug when you had a monster with more then 21 million HP: the gauge showed 0% even when it was on full HP.

It's because when the server calculates the HP percentage is like MINMAX(0, (m_pkChrTarget->GetHP() * 100) / m_pkChrTarget->GetMaxHP(), 100), so 21 million will overflow when it's multiplied by 100.

The fix is really quick and easy:

This is the hidden content, please

• Sign In
• or
• Sign Up

[TAUMP 796]

I dont think so.

Edited October 17, 2022 by Metin2 Dev
Core X - External 2 Internal

[PetePeter 36]

This is enough

 

p.bHPPercent = MINMAX(0, static_cast<int64_t>(static_cast<int64_t>(m_pkChrTarget->GetHP()) * 100) / static_cast<int64_t>(m_pkChrTarget->GetMaxHP()), 100);

 

[TAUMP 796]

10 hours ago, PetePeter said:

This is enough

 

p.bHPPercent = MINMAX(0, static_cast<int64_t>(static_cast<int64_t>(m_pkChrTarget->GetHP()) * 100) / static_cast<int64_t>(m_pkChrTarget->GetMaxHP()), 100);

 

p.bHPPercent = MINMAX(0, ((int64_t)m_pkChrTarget->GetHP() * 100) / m_pkChrTarget->GetMaxHP(), 100);

p.bHPPercent = MINMAX(0, (((int64_t)GetHP()) * 100) / GetMaxHP(), 100);

This is enough, Dear Peter.
 

[Denizeri24 35]

2 hours ago, TAUMP said:

p.bHPPercent = MINMAX(0, ((int64_t)m_pkChrTarget->GetHP() * 100) / m_pkChrTarget->GetMaxHP(), 100);

p.bHPPercent = MINMAX(0, (((int64_t)GetHP()) * 100) / GetMaxHP(), 100);

This is enough, Dear Peter.
 

p.bHPPercent = MINMAX(0, (((int64_t)GetHP()) * 100) / GetMaxHP(), 100);

p.bHPPercent = std::minmax<uint8_t>((GetHP() * 100) / GetMaxHP(), 100).first;

This is enough, Dear TAUMP.

Edited October 18, 2022 by Denizeri24

[Ulthar 2777]

Thank you, its working for me.
Lil tanky doggo
https://metin2.download/picture/bjt2x4wGc6U94iHQ6ACW7sNasMCLYuVM/.png

Edited February 19, 2023 by Metin2 Dev
Core X - External 2 Internal

[Cripplez 40]

Thank you

I think with so much HP there is a bug with mob health regen.

For example i tried a mob with 40kk hp and is health regen works okay, but for example with 400kk or 1kkk hp the health regen is like 1hp every 8 sec instead of millions

 

Is this the correct way to fix this?

in char.cpp search EVENTFUNC(recovery_event)

else if (!ch->IsDoor())
	{
		ch->MonsterLog("HP_REGEN +%d", MAX(1, (ch->GetMaxHP() * ch->GetMobTable().bRegenPercent) / 100));
		ch->PointChange(POINT_HP, MAX(1, (ch->GetMaxHP() * ch->GetMobTable().bRegenPercent) / 100));
	}

change to

else if (!ch->IsDoor())
	{
		ch->MonsterLog("HP_REGEN +%d", MAX(1, (ch->GetMaxHP() * ch->GetMobTable().bRegenPercent) / 100));
		ch->PointChange(POINT_HP, MAX(1, ((int64_t)ch->GetMaxHP() * ch->GetMobTable().bRegenPercent) / 100));//fix
	}