Jump to content

Max Yang - compile problem

Syron
 Share

Recommended Posts

Syron Collaborator

Syron 285

Posted
Posted (edited)

Hello metin2dev, i'm having some trouble compiling my db with max gold edited. ( unsigned long long )

Let's explain this:

- i have changed everything from int to unsigned long long. ( hope so , you can "list a list" of files where i should edit , i'm pretty sure i do it all. )

- binary has Unsigned Long Long Elk Function.

 

Problem:

If i compile it with long long ( tables.h only ! ) it will compile ( it won't work because everywhere else is unsigned long long )

ziTmmhD.png

If i compile it with unsigned long long ( tables.h and everything else ) it will NOT COMPILE the DB. ( game will be compiled succesfully. ) u5yjTYy.png

 

Here is the ErrorLog generated by the DB Build. ( i already checked everything , i have really no ideea. ) 

In file included from ClientManager.cpp:6:
../../common/VnumHelper.h:59:32: warning: no newline at end of file
Cache.cpp:365:7: warning: no newline at end of file
In file included from ClientManagerBoot.cpp:8:
ProtoReader.h:36:7: warning: no newline at end of file
ItemAwardManager.cpp:129:2: warning: no newline at end of file
ClientManagerPlayer.cpp: In member function 'char* CClientManager::GetCommand(char*)':
ClientManagerPlayer.cpp:433: warning: address of local variable 'command' returned
ClientManagerPlayer.cpp: In function 'bool CreatePlayerTableFromRes(MYSQL_RES*, TPlayerTable*)':
ClientManagerPlayer.cpp:478: error: no matching function for call to 'str_to_number(long long unsigned int&, char*&)'
../../common/utils.h:2: note: candidates are: bool str_to_number(bool&, const char*)
../../common/utils.h:10: note:                 bool str_to_number(char&, const char*)
../../common/utils.h:18: note:                 bool str_to_number(unsigned char&, const char*)
../../common/utils.h:26: note:                 bool str_to_number(short int&, const char*)
../../common/utils.h:34: note:                 bool str_to_number(short unsigned int&, const char*)
../../common/utils.h:42: note:                 bool str_to_number(int&, const char*)
../../common/utils.h:50: note:                 bool str_to_number(unsigned int&, const char*)
../../common/utils.h:58: note:                 bool str_to_number(long int&, const char*)
../../common/utils.h:66: note:                 bool str_to_number(long unsigned int&, const char*)
../../common/utils.h:74: note:                 bool str_to_number(long long int&, const char*)
../../common/utils.h:82: note:                 bool str_to_number(float&, const char*)
../../common/utils.h:90: note:                 bool str_to_number(double&, const char*)
../../common/utils.h:99: note:                 bool str_to_number(long double&, const char*)
gmake: *** [.obj/ClientManagerPlayer.o] Error 1
gmake: *** Waiting for unfinished jobs....

 
Edited by Metin2 Dev
Core X - External 2 Internal
Link to comment
Share on other sites
  • Replies 10
  • Created
  • Last Reply

Top Posters In This Topic

Popular Days

Top Posters In This Topic

Popular Days

Popular Posts

Traceur3RUN
Traceur3RUN

clientmanagerplayer.cpp  line 102: "gold = %d, " change to "gold = %llu, " or "gold = %ull, "   common: uttils.cpp add inline bool str_to_number (unsigned long long& out, const char *i

Traceur3RUN Proficient

Traceur3RUN 73

Posted
Posted (edited)

 

Hello metin2dev, i'm having some trouble compiling my db with max gold edited. ( unsigned long long )

Let's explain this:

- i have changed everything from int to unsigned long long. ( hope so , you can "list a list" of files where i should edit , i'm pretty sure i do it all. )

- binary has Unsigned Long Long Elk Function.

 

Problem:

If i compile it with long long ( tables.h only ! ) it will compile ( it won't work because everywhere else is unsigned long long )

ziTmmhD.png

If i compile it with unsigned long long ( tables.h and everything else ) it will NOT COMPILE the DB. ( game will be compiled succesfully. ) u5yjTYy.png

 

Here is the ErrorLog generated by the DB Build. ( i already checked everything , i have really no ideea. ) 

In file included from ClientManager.cpp:6:
../../common/VnumHelper.h:59:32: warning: no newline at end of file
Cache.cpp:365:7: warning: no newline at end of file
In file included from ClientManagerBoot.cpp:8:
ProtoReader.h:36:7: warning: no newline at end of file
ItemAwardManager.cpp:129:2: warning: no newline at end of file
ClientManagerPlayer.cpp: In member function 'char* CClientManager::GetCommand(char*)':
ClientManagerPlayer.cpp:433: warning: address of local variable 'command' returned
ClientManagerPlayer.cpp: In function 'bool CreatePlayerTableFromRes(MYSQL_RES*, TPlayerTable*)':
ClientManagerPlayer.cpp:478: error: no matching function for call to 'str_to_number(long long unsigned int&, char*&)'
../../common/utils.h:2: note: candidates are: bool str_to_number(bool&, const char*)
../../common/utils.h:10: note:                 bool str_to_number(char&, const char*)
../../common/utils.h:18: note:                 bool str_to_number(unsigned char&, const char*)
../../common/utils.h:26: note:                 bool str_to_number(short int&, const char*)
../../common/utils.h:34: note:                 bool str_to_number(short unsigned int&, const char*)
../../common/utils.h:42: note:                 bool str_to_number(int&, const char*)
../../common/utils.h:50: note:                 bool str_to_number(unsigned int&, const char*)
../../common/utils.h:58: note:                 bool str_to_number(long int&, const char*)
../../common/utils.h:66: note:                 bool str_to_number(long unsigned int&, const char*)
../../common/utils.h:74: note:                 bool str_to_number(long long int&, const char*)
../../common/utils.h:82: note:                 bool str_to_number(float&, const char*)
../../common/utils.h:90: note:                 bool str_to_number(double&, const char*)
../../common/utils.h:99: note:                 bool str_to_number(long double&, const char*)
gmake: *** [.obj/ClientManagerPlayer.o] Error 1
gmake: *** Waiting for unfinished jobs....

 

clientmanagerplayer.cpp 

line 102:

"gold = %d, "

change to

"gold = %llu, "

or

"gold = %ull, "

 

common:

uttils.cpp

add

inline bool str_to_number (unsigned long long& out, const char *in)
{
	if (0==in || 0==in[0])	return false;

	out = (unsigned long long) strtoull(in, NULL, 10);
	return true;
}
Edited by Metin2 Dev
Core X - External 2 Internal
  • Love 1
Link to comment
Share on other sites
Syron Collaborator

Syron 285

Posted
  • Author
Posted (edited) 
add

inline bool str_to_number (unsigned long long& out, const char *in)
{
    if (0==in || 0==in[0])    return false;

    out = (unsigned long long) strtoull(in, NULL, 10);
    return true;
}

Testing right now in game , it has compiled.

iwxGW7E.png

I think it's something wrong under binary... Do i have to edit uicommon ? There are my lines:

money = 0
if text and text.isdigit():
try:
money = int(text)
except ValueError:
money = 199999999

GetElk:

PyObject * playerGetElk(PyObject* poSelf, PyObject* poArgs)
{
return PyLong_FromUnsignedLongLong(CPythonPlayer::Instance().GetStatus(POINT_GOLD));
}
Edited by Metin2 Dev
Core X - External 2 Internal
Link to comment
Share on other sites
Traceur3RUN Proficient

Traceur3RUN 73

Posted
Posted (edited) 
add

inline bool str_to_number (unsigned long long& out, const char *in)
{
    if (0==in || 0==in[0])    return false;

    out = (unsigned long long) strtoull(in, NULL, 10);
    return true;
}

Testing right now in game , it has compiled.

iwxGW7E.png

I think it's something wrong under binary... Do i have to edit uicommon ? There are my lines:

money = 0
if text and text.isdigit():
try:
money = int(text)
except ValueError:
money = 199999999

GetElk:

PyObject * playerGetElk(PyObject* poSelf, PyObject* poArgs)
{
return PyLong_FromUnsignedLongLong(CPythonPlayer::Instance().GetStatus(POINT_GOLD));
}

 

change int to int64

Edited by Metin2 Dev
Core X - External 2 Internal
Link to comment
Share on other sites
Traceur3RUN Proficient

Traceur3RUN 73

Posted
Posted

 

change int to int64

 

 

 

No effect. Same error.

 

maybe here you need more change

uipickmoney.py

 

def OnAccept(self):

		text = self.pickValueEditLine.GetText()

		if len(text) > 0 and text.isdigit():

			money = int(text)
			money = min(money, self.maxValue)

			if money > 0:
				if self.eventAccept:
					self.eventAccept(money)

		self.Close()
Link to comment
Share on other sites
Syron Collaborator

Syron 285

Posted
  • Author
Posted

 

 

change int to int64

 

 

 

No effect. Same error.

 

maybe here you need more change

uipickmoney.py

 

def OnAccept(self):

		text = self.pickValueEditLine.GetText()

		if len(text) > 0 and text.isdigit():

			money = int(text)
			money = min(money, self.maxValue)

			if money > 0:
				if self.eventAccept:
					self.eventAccept(money)

		self.Close()

 

Same error , after value exceeds 2kkk -> it transform into 912319231231231923

Link to comment
Share on other sites
Lyrex Explorer

Lyrex 6

Posted
Posted

You have to additionally edit some packets clientside.

A list of what I found now in searching for 5 Minutes: command_item_drop, command_item_drop2, packet_shop_update_price and most important: packet_points and packet_point_change. In packet_point_changeyou have to modify long amount to long long amount I think, in packet_points you have to edit long points to long long points.

Link to comment
Share on other sites

Please sign in to comment

You will be able to leave a comment after signing in



Sign In Now
 Share
Go to topic listing

Announcements



  • Similar Content

  • Activity

    1. 11

      Multi Language System

      char.cpp in void CHARACTER::ChatPacket this: #ifdef ENABLE_MULTILANGUAGE std::string sTranslateText; if (type != CHAT_TYPE_COMMAND) { if (GetLang() > MAX_LANGUAGES) sTranslateText = LC_TEXT(DEFAULT_LANGUAGE, format); else sTranslateText = LC_TEXT(GetLang(), format); } #endif and this a little under: #ifdef ENABLE_MULTILANGUAGE int len = vsnprintf(chatbuf, sizeof(chatbuf), format, args); if (type != CHAT_TYPE_COMMAND) len = vsnprintf(chatbuf, sizeof(chatbuf), sTranslateText.c_str(), args); #else Is just not needed at all and makes this problem. Every shout, party, info etc chat would go to LC_TEXT what adds a "@0949" to the message if translation not found in in locale.cpp's locale_find (it's hidden but you can see in /n for example or if you write messages to console) and that "@0949" makes accents bad plus you get a syserr each time somebody shout or party or guild chat etc. So you can delete this 2 ifdef if you already set every LC_TEXT(DEFAULT_LANGUAGE / LC_TEXT(TRANSLATE_LANGUAGE and I'm sure you did because LC_TEXT's new first attribute is mandatory so if you didn't then you couldn't compile the game. So that's why I said this is just not needed at all and can be removed. (Sorry for bumping old topic but I wanted to share the fix)
      TMP4 in Features & Metin2 Systems
    2. 0

      [FREE DESIGN] Interface + Logo + Discord Banner and Avatar

      Download Alternative download links → GG Drive Hello all, I decided to offer this package for free to someone who really needs it. The archive contains everything you need to modify this template Careful! The interface is PSD only You can contact me anytime if you want to edit something Have fun!
      unqdesign in 2D Graphics
    3. 4

      Feeding game source to LLM

      You don't need to train it on your source code. You just need to take a good model and give it more context. For example I use Github Copilot to help me with some trivial task while coding. If I need info about the whole source I just use @workspace in the chat when I ask it a question and then he has more context about the source.
      Abel(Tiger) in Metin2
    4. 0

      Quest 6/7 Problem

      Hi, sorry for my terrible English. I have a problem with system 6/7 of these server files. [Hidden Content] They do not bring the system quest. I don't know much about programming quests, I tried to adapt a quest from other server files, but I only managed to get it to open the bonus window. Does anyone have the quest or can do it? I would greatly appreciate the help I use '--' just for identify the quest_function I had and the quest I try to adapt [Hidden Content]
      Rags in Community Support - Questions & Answers
    5. 5

      Effect weapons

      I have the .mde and the .mse next to each other however this does not really work.. I have the correct EFFECT_REFINED + (the number of the enum value) in the playersettingmodule.py I applied the effect on InstanceBase.cpp (considering the item's vnum) with no luck.. Do I miss something? Does those files have a prefix path or something? Like if I put them on the wrong path (think about the granny texture) will not find them at all?
      white in Community Support - Questions & Answers
    6. 0

      [C++] Fix Core Downer Using Negative Number in GM Codes

      INTRODUCTION & PROBLEM Hello, today we will fix a few errors, especially the error that caused the core down by giving an unexpected negative (-) arg (number) in the commands (Example; /mob 101 -1), and we will also regulate the use of "ChatPacket" in this functions. WHY ? GMs are already part of the team, you may ask why we need this, you are right, but do not forget that a GM who does not have coding knowledge may accidentally trigger this, let's not leave it to chance. SOLUTION The process we will do is simple, it will be enough to make sure that the given arg value is within the range we want, let's get started. [Hidden Content]
      • 10
      • Good
      • Metin2 Dev
      • muscle
      MT2Dev in Bug Fixes
    7. 3

      Crystal Metinstone

      Awesome!! Can u make it with other colors too? Like ice fire forest lightning ?
      asdasd1234 in Metinstones
    8. 4

      Feeding game source to LLM

      ChatGPT is obsolete today honestly. I use claude-3-opus LLM daily for commercial programming and it exceeds chatgpt by a mile. When it comes to token size it's like you said, not possible straight away with chatgpt. There's however a way to go around this with some additional layers of complexity like Cursor Editor although be warned its closed source. It's basically a fork of vscode that let's you ask LLMs about your code. Also you can ask it to write anything and it has the context of your entire codebase. I tested it a few months back and it wasn't bad honestly. I told it to explain some shit-code written by ymir that I didn't understand and it did quite well.
      b6d4a82c15 in Metin2
    9. 113

      Ulthar SF V2 (TMP4 Base)

      active effect : - inventory good - panel lags
      master1988 in Binaries

  • Recently Browsing

    • No registered users viewing this page.
×
×
  • Create New...

Important Information

Terms of Use / Privacy Policy / Guidelines / We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.