Problem with double kill in quest

[ѕeмa™ 304]

Hi, i have the problem in the quest:

when kill begin

 syschat("test") -- this say x2

end

 

i saw in epvp

 

and i put like this:

 

but doesnt work, anyone know how solve it?

 

Thanks.

Edited August 18, 2022 by Metin2 Dev
Core X - External 2 Internal

[Cataclismo 86]

If I understood well the source ( I didn't tested yet ), the solution you tried is quite stupid.

if (npc != QUEST_NO_NPC)
	m_mapNPC[QUEST_NO_NPC].OnKill(*pPC);

This extra function will also do a extra call, so more triggers.

 

Try this - not tested and if it works let us know:

Find this ( SAME function you posted ):

if (m_mapNPC[QUEST_NO_NPC].OnKill(*pPC))
	return;

if (leader)
{
	m_pCurrentPartyMember = ch;
	m_mapNPC[QUEST_NO_NPC].OnPartyKill(*GetPC(leader->GetPlayerID()));
}

And comment it. Try to test if it's still bugged. This also may cause another bug: the function may not trigger at all! So test it in all ways possible. Kill a player and then a mob.

[ѕeмa™ 304]

If I understood well the source ( I didn't tested yet ), the solution you tried is quite stupid.

if (npc != QUEST_NO_NPC)
	m_mapNPC[QUEST_NO_NPC].OnKill(*pPC);

This extra function will also do a extra call, so more triggers.

 

Try this - not tested and if it works let us know:

Find this ( SAME function you posted ):

if (m_mapNPC[QUEST_NO_NPC].OnKill(*pPC))
	return;

if (leader)
{
	m_pCurrentPartyMember = ch;
	m_mapNPC[QUEST_NO_NPC].OnPartyKill(*GetPC(leader->GetPlayerID()));
}

And comment it. Try to test if it's still bugged. This also may cause another bug: the function may not trigger at all! So test it in all ways possible. Kill a player and then a mob.

ok i go to try it, thanks for reply

[Koray 1940]

Open your questmanager.cpp;
 
Search:

m_mapNPC[npc].OnKill(*pPC);

Change with this:

if (npc > MAIN_RACE_MAX_NUM)
	m_mapNPC[npc].OnKill(*pPC);
m_mapNPC[QUEST_NO_NPC].OnKill(*pPC);

----

 

Search:

m_pCurrentPartyMember = ch;

if (m_mapNPC[npc].OnPartyKill(*GetPC(leader->GetPlayerID())))
	return;

pPC = GetPC(pc);

Change with this:

m_pCurrentPartyMember = ch;

if (npc > MAIN_RACE_MAX_NUM)
	m_mapNPC[npc].OnPartyKill(*GetPC(leader->GetPlayerID()));
m_mapNPC[QUEST_NO_NPC].OnPartyKill(*GetPC(leader->GetPlayerID()));

//pPC = GetPC(pc);

[ѕeмa™ 304]

how cataclismo said, not work fine, only count 1 mob and 2 player

[ѕeмa™ 304]

now im trying how koray's said:

Edited August 18, 2022 by Metin2 Dev
Core X - External 2 Internal

[Cataclismo 86]

how cataclismo said, not work fine, only count 1 mob and 2 player

 

Edited: Wait... what? Hm..

Edited February 10, 2015 by Cataclismo

[ѕeмa™ 304]

How koray's said, mobs count 2 and player count 2 too :/ ( if i put all right )

[hachiwari 136]

In game/src/questmanager.cpp in void CQuestManager::Kill(unsigned int pc, unsigned int npc)

Change:

m_mapNPC[npc].OnKill(*pPC);

with:

if(npc > 0)
{
m_mapNPC[npc].OnKill(*pPC);
}

[ѕeмa™ 304]

In game/src/questmanager.cpp in void CQuestManager::Kill(unsigned int pc, unsigned int npc)

Change:

m_mapNPC[npc].OnKill(*pPC);

with:

if(npc > 0)
{
m_mapNPC[npc].OnKill(*pPC);
}

ok, thanks i go to try it.

[pbuzz 31]

[ѕeмa™ 304]

Solved. Thanks to all.

[Cataclismo 86]

Solved. Thanks to all.

 

You should check this:

Read what that guy said and how it will work.

[ѕeмa™ 304]

 

Solved. Thanks to all.

 

You should check this:

Read what that guy said and how it will work.

 

yes i did, thanks