MALL window item's size bug

[TMP4 10479]

Hey, currently I'm trying to help a friend with a mall window bug where every item's size is 1 somehow (check picture).
My first thought it is some fcked up source code, but after we took my serverfile's source and take all items from the window and reinserted new ones
to item_award the newly insterted items was bugged again to my biggest surprise.

So it is not source-related I believe. Any idea what can cause such bug? item_award and item table are identical with mine and now the source code too. The items have correct size in item_proto and do behave normal in inventory window.

My friend with the same source:

My with the same source:

I can't even guess what can cause such bug, again it's not source-related beleive me or not 

Edited August 25, 2021 by TMP4

[Mitachi 1318]

I'm not sure, but it seems to me that it shares the same grid as metin2's basic store.
Check the grids in your src

Edited August 18, 2022 by Metin2 Dev
Core X - External 2 Internal

[TMP4 10479]

11 hours ago, Mitachi said:

I'm not sure, but it seems to me that it shares the same grid as metin2's basic store.
Check the grids in your src

It's 5 and 9, it's a base src. As I said i believe it's not src related problem, is it possible that there are any setting at config files, conf.txt, database or even in client that could cause the grid system / item size (either it is) bug to produce this error?

Shops, Safebox, Inventory are good tho, it is only the mall. I've never seen a bug like this before.

Edited August 18, 2022 by Metin2 Dev
Core X - External 2 Internal

[Abel(Tiger) 1134]

For the mall the grid is placed on the db, check ClientManager.cpp bellow this line:

CGrid grid(5, MAX(1, pi->pSafebox->bSize) * 9);

 

 

Also try this (a common bug in metin2 source):

In ClientManagerBoot.cpp search:

sort(m_vec_itemTable.begin(), m_vec_itemTable.end(), FCompareVnum());

And move it before the iterator is initialized like this:

	m_map_itemTableByVnum.clear();
	
	// Now it's here
	sort(m_vec_itemTable.begin(), m_vec_itemTable.end(), FCompareVnum());

	itertype(m_vec_itemTable) it = m_vec_itemTable.begin();

	while (it != m_vec_itemTable.end())
	{
		TItemTable * item_table = &(*(it++));

		sys_log(1, "ITEM: #%-5lu %-24s %-24s VAL: %ld %ld %ld %ld %ld %ld WEAR %lu ANTI %lu IMMUNE %lu REFINE %lu REFINE_SET %u MAGIC_PCT %u", 
				item_table->dwVnum,
				item_table->szName,
				item_table->szLocaleName,
				item_table->alValues[0],
				item_table->alValues[1],
				item_table->alValues[2],
				item_table->alValues[3],
				item_table->alValues[4],
				item_table->alValues[5],
				item_table->dwWearFlags,
				item_table->dwAntiFlags,
				item_table->dwImmuneFlag,
				item_table->dwRefinedVnum,
				item_table->wRefineSet,
				item_table->bAlterToMagicItemPct);

      	// Also you can insert these values after the sort but because we
        // already looping through the list of items once (for the syslog), it's better to 
      	// move the sort function above (the complexity is half this way)
		m_map_itemTableByVnum.insert(std::map<DWORD, TItemTable *>::value_type(item_table->dwVnum, item_table));
	}

	// It was here
	
	return true;

 

Edited August 18, 2022 by Metin2 Dev
Core X - External 2 Internal

[TMP4 10479]

1 hour ago, Abel(Tiger) said:

For the mall the grid is placed on the db, check ClientManager.cpp bellow this line:

CGrid grid(5, MAX(1, pi->pSafebox->bSize) * 9);

 

 

Also try this (a common bug in metin2 source):

In ClientManagerBoot.cpp search:

sort(m_vec_itemTable.begin(), m_vec_itemTable.end(), FCompareVnum());

And move it before the iterator is initialized like this:

	m_map_itemTableByVnum.clear();
	
	sort(m_vec_itemTable.begin(), m_vec_itemTable.end(), FCompareVnum());

	itertype(m_vec_itemTable) it = m_vec_itemTable.begin();

	while (it != m_vec_itemTable.end())
	{
		TItemTable * item_table = &(*(it++));

		sys_log(1, "ITEM: #%-5lu %-24s %-24s VAL: %ld %ld %ld %ld %ld %ld WEAR %lu ANTI %lu IMMUNE %lu REFINE %lu REFINE_SET %u MAGIC_PCT %u", 
				item_table->dwVnum,
				item_table->szName,
				item_table->szLocaleName,
				item_table->alValues[0],
				item_table->alValues[1],
				item_table->alValues[2],
				item_table->alValues[3],
				item_table->alValues[4],
				item_table->alValues[5],
				item_table->dwWearFlags,
				item_table->dwAntiFlags,
				item_table->dwImmuneFlag,
				item_table->dwRefinedVnum,
				item_table->wRefineSet,
				item_table->bAlterToMagicItemPct);

		m_map_itemTableByVnum.insert(std::map<DWORD, TItemTable *>::value_type(item_table->dwVnum, item_table));
	}
	
	return true;

 

I have a clue now.

My reference serverfile have 1 page safebox but my firend's server have enabled 3 page safebox in account.account table (safebox_expire column, it's a default feature btw) for every account, so that's why it's good for me and bad for him with the same source files. 
"CGrid grid(5, MAX(1, pi->pSafebox->bSize) * 9);"

I can't test it right now but I'm sure that it is the problem. Thanks for pointing out to that row

Edited August 18, 2022 by Metin2 Dev
Core X - External 2 Internal

[Abel(Tiger) 1134]

That variable it's always 1 for the mall window, my advice is to compare all the code from function CClientManager::RESULT_SAFEBOX_LOAD with a clasic one and solve the bug with the addresses I told you about.

[TMP4 10479]

On 8/26/2021 at 1:36 PM, Abel(Tiger) said:

For the mall the grid is placed on the db, check ClientManager.cpp bellow this line:

CGrid grid(5, MAX(1, pi->pSafebox->bSize) * 9);

 

 

Also try this (a common bug in metin2 source):

In ClientManagerBoot.cpp search:

sort(m_vec_itemTable.begin(), m_vec_itemTable.end(), FCompareVnum());

And move it before the iterator is initialized like this:

	m_map_itemTableByVnum.clear();
	
	// Now it's here
	sort(m_vec_itemTable.begin(), m_vec_itemTable.end(), FCompareVnum());

	itertype(m_vec_itemTable) it = m_vec_itemTable.begin();

	while (it != m_vec_itemTable.end())
	{
		TItemTable * item_table = &(*(it++));

		sys_log(1, "ITEM: #%-5lu %-24s %-24s VAL: %ld %ld %ld %ld %ld %ld WEAR %lu ANTI %lu IMMUNE %lu REFINE %lu REFINE_SET %u MAGIC_PCT %u", 
				item_table->dwVnum,
				item_table->szName,
				item_table->szLocaleName,
				item_table->alValues[0],
				item_table->alValues[1],
				item_table->alValues[2],
				item_table->alValues[3],
				item_table->alValues[4],
				item_table->alValues[5],
				item_table->dwWearFlags,
				item_table->dwAntiFlags,
				item_table->dwImmuneFlag,
				item_table->dwRefinedVnum,
				item_table->wRefineSet,
				item_table->bAlterToMagicItemPct);

      	// Also you can insert these values after the sort but because we
        // already looping through the list of items once (for the syslog), it's better to 
      	// move the sort function above (the complexity is half this way)
		m_map_itemTableByVnum.insert(std::map<DWORD, TItemTable *>::value_type(item_table->dwVnum, item_table));
	}

	// It was here
	
	return true;

 

After I moved that sort to upper as you suggested, the bug disappeard. 

Still don't know why it was good in one serverfile, why it wasen't in the other one WITH THE SAME SOURCE, maybe there are some setting, option anywhere that cause this, but your trick clearly solved the bug so I ticked it as the best asnwer, thank you

(I should have try it earlier but as I said I'm helping a friend with this and we did not have time yesterday)

Edited August 18, 2022 by Metin2 Dev
Core X - External 2 Internal