game.core with party flag system

[weryoliveira 3]

well i have one problem from my server, i guess this happening, one player use buff and give-me game.core this is game.core with gdb

Spoiler

#0  CHARACTER::UseSkill ([email protected]=0x2ead4000, dwVnum=96, pkVictim=0x0,
    bUseGrandMaster=<optimized out>, [email protected]=true)
    at char_skill.cpp:2544
2544    char_skill.cpp: No such file or directory.
[Current thread is 1 (LWP 100251)]
(gdb) bt full
#0  CHARACTER::UseSkill ([email protected]=0x2ead4000, dwVnum=96, pkVictim=0x0,
    bUseGrandMaster=<optimized out>, [email protected]=true)
    at char_skill.cpp:2544
        f = {
          vecPIDs = {<std::_Vector_base<unsigned int, std::allocator<unsigned int> >> = {
              _M_impl = {<std::allocator<unsigned int>> = {<__gnu_cxx::new_allocator<unsigned int>> = {<No data fields>}, <No data fields>}, _M_start = 0x2ccdbb70,
                _M_finish = 0x2ccdbb7c,
                _M_end_of_storage = 0x2ccdbb80}}, <No data fields>}}
        bCanUseHorseSkill = <optimized out>
        k = <optimized out>
        iCooltime = <optimized out>
        lMaxHit = 1
        dwCur = <optimized out>
        iNeededSP = <optimized out>
        pkSk = 0xd0
        iSplashCount = 1
#1  0x0817a35e in CInputMain::UseSkill (this=0x29887d9c,
    [email protected]=0x2ead4000, [email protected]=0x2cb70b5e "4`")
    at input_main.cpp:2000
        p = 0x2cb70b5e
#2  0x0817f34a in CInputMain::Analyze (this=0x29887d9c, d=0x29887d00,
--Type <RET> for more, q to quit, c to continue without paging--
    bHeader=52 '4', c_pData=0x2cb70b5e "4`") at input_main.cpp:3267
        ch = <optimized out>
        __FUNCTION__ = "Analyze"
        iExtraLen = 0
#3  0x08168476 in CInputProcessor::Process (this=0x29887d9c,
    lpDesc=0x29887d00, c_pvOrig=<optimized out>,
    [email protected]: 350, iBytes=<optimized out>) at input.cpp:103
        iExtraPacketSize = <optimized out>
        bHeader = 52 '4'
        c_pszName = 0x2cc9882c "UseSkill"
        bLastHeader = 7 '\a'
        iLastPacketLen = <optimized out>
        iPacketLen = 10
        c_pData = 0x2cb70b5e "4`"
        c_pData = <optimized out>
        bLastHeader = <optimized out>
        iLastPacketLen = <optimized out>
        iPacketLen = <optimized out>
        bHeader = <optimized out>
        c_pszName = <optimized out>
        iExtraPacketSize = <optimized out>
        bSeq = <optimized out>
        bSeqReceived = <optimized out>
--Type <RET> for more, q to quit, c to continue without paging--
        ch = <optimized out>
        buf = <optimized out>
        offset = <optimized out>
        len = <optimized out>
        i = <optimized out>
 

i guess that, the player (shaman) is selected a mob, and use buff when this mob die and didn't unmark the mob, "can view hp bar yet" and at moment use skill(buff) and game don't know what supose he do, because victim os 0x0 and he need ComputeSkill with pkVictim = 0x0 and give game.core, my gdb say 2544 line char_skill.cpp and the line is here (the elseif code is here on spoiler)
 

Spoiler

    else if (IS_SET(pkSk->dwFlag, SKILL_FLAG_PARTY) && GetParty())
    {
        FPartyPIDCollector f;
        GetParty()->ForEachOnMapMember(f, GetMapIndex());
        if (!pkVictim->GetParty()) <---HERE A LINE GAME.CORE 2544
            ComputeSkill(dwVnum, pkVictim); <--- HERE IS A PROBLEM TO GAME.CORE I GUESS
        for (std::vector <DWORD>::iterator it = f.vecPIDs.begin(); it != f.vecPIDs.end(); it++)
        {
            LPCHARACTER ch = CHARACTER_MANAGER::instance().FindByPID(*it);
            ComputeSkill(dwVnum, ch);
        }
    }

but when i see ComputeSkill i see this if,

    if (!pkVictim)
    {
        if (test_server)
            sys_log(0, "ComputeSkill: %s Victim == null, skill %d", GetName(), dwVnum);

        return BATTLE_NONE;
    }
soo, if exist this if, maybe the problem not here? i have other call on pkvictim above this if, maybe i can fix moving this if to first line?

thank

[ondry 58]

try to change

if (!pkVictim->GetParty())

to

if (pkVictim && !pkVictim->GetParty())