Gcc10 Compile Warning

[Defacer35 21]

- SOLVED -

 

Update system_cmd to 512 and char name to 128 thats solve the warning.

 

- SOLVED -

 

 

 

Hello devs, i have a little trouble here.

 

name veriable has a char* but i have this warn what should i do ? Best regards..

 

void log_file_delete_old (const char* filename)
{
	struct stat sb;
	int num1, num2;
	char buf[32];
	char system_cmd[64];
	struct tm new_tm;

	if (stat(filename, &sb) == -1)
	{
		perror("log_file_delete_old: stat");
		return;
	}

	if (!S_ISDIR(sb.st_mode))
	{
		return;
	}

	new_tm = *tm_calc(NULL, -log_keep_days);
	sprintf (buf, "%04d%02d%02d", new_tm.tm_year + 1900, new_tm.tm_mon + 1, new_tm.tm_mday);
	num1 = atoi(buf);

	struct dirent** namelist;
	int n;

	n = scandir (filename, &namelist, 0, alphasort);

	if (n < 0)
	{
		perror ("scandir");
	}
	else
	{
		char name[MAXNAMLEN + 1];

		while (n-- > 0)
		{
			strncpy (name, namelist[n]->d_name, 255);
			name[255] = '\0';

			free (namelist[n]);

			if (*name == '.')
			{
				continue;
			}

			if (!isdigit (*name))
			{
				continue;
			}

			num2 = atoi (name);

			if (num2 <= num1)
			{
				sprintf (system_cmd, "rm -rf %s/%s", filename, name);
				system (system_cmd);

				sys_log (0, "%s: SYSTEM_CMD: %s", __FUNCTION__, system_cmd);
				fprintf (stderr, "%s: SYSTEM_CMD: %s %s:%d %s:%d\n", __FUNCTION__, system_cmd, buf, num1, name, num2);
			}
		}
	}

		free (namelist);
}

 

Edited August 25, 2022 by Metin2 Dev
Core X - External 2 Internal

[WeedHex 626]

char name[255 + 1];

 

The other warning there is not code ...

Edited November 22, 2020 by WeedHex

[Defacer35 21]

 

First of all thanks for the answer, does that before but i have same warn again

Edited August 25, 2022 by Metin2 Dev
Core X - External 2 Internal

[WeedHex 626]

1 hour ago, Defacer35 said:

 

First of all thanks for the answer, does that before but i have same warn again

Can you please post the whole file on pastebin so we can check lines and functions.

 

You show us void log_file_delete_old (const char* filename) but seems different in the compiler.

Need log_file_rotate() too

Edited August 25, 2022 by Metin2 Dev
Core X - External 2 Internal

[Defacer35 21]

2 minutes ago, WeedHex said:

Can you please post the whole file on pastebin so we can check lines and functions.

 

You show us void log_file_delete_old (const char* filename) but seems different in the compiler.

Need log_file_rotate() too

 

Sure, https://paste.ubuntu.com/p/wvx49ChtXZ/

[WeedHex 626]

Change:

char name[MAXNAMLEN + 1];

to

char name[512];

 

 

char dir[128];

to

char dir[256];

 

Idk why you're getting these warning, need other infos btw try to do what compiler said upgrading the sizes.

[Defacer35 21]

15 minutes ago, WeedHex said:

Change:

char name[MAXNAMLEN + 1];

to

char name[512];

 

 

char dir[128];

to

char dir[256];

 

Idk why you're getting these warning, need other infos btw try to do what compiler said upgrading the sizes.

 

Sadly i try this before this not the problem i think i'm try char name 2048 or 1024 or 512 or 256 also 64 - 128 getting same warn every time, i'm search almost every stackflow post but nothing get anything..

 

Btw thanks for your effort.