Jump to content

[Problem] ITEM_RING doesn't give bonuses


Recommended Posts

 

1. Description of the problem / Question :

When an item with type 33 (ITEM_RING) is equipped, character doesn't receive any bonuses. It equips just fine and the item equip effect goes off, but there are no stats added. Also when I changed the ITEM_RING condition in char_item.cpp to just show me some kind of a message when I equip it, it worked, so it's probably a little too deeper for me.

 

 

2. SysErr ( Client / Server ) / SysLog ( Server )

nussink

 

3. How to reproduce it ?

So I've changed the magic lollipop type to 33 - nZuZHVK.png this one xD and it doesn't give any bonuses. And it did when it was still an ITEM_UNIQUE

 

4. Screenshots ?

Nothing to show here tbh...

 

 

 

 

 

Edited by Metin2 Dev
Core X - External 2 Internal
Link to comment
Share on other sites

  • Bot
item.cpp:

int CItem::FindEquipCell(LPCHARACTER ch, int iCandidateCell)
{
	[...]
	if (GetType() == ITEM_DS || GetType() == ITEM_SPECIAL_DS)
	{
		[...]
	}
	else if (GetType() == ITEM_COSTUME)
	{
		[...]
	}
	// look if you have this
	else if (GetType() == ITEM_RING)
	{
		if (ch->GetWear(WEAR_RING1))
			return WEAR_RING2;
		else
			return WEAR_RING1;
	}
	// look if you have this
	else if (GetType() == ITEM_BELT)
		return WEAR_BELT;
	else if (GetWearFlag() & WEARABLE_BODY)
		return WEAR_BODY;
	[...]
}

Tbh i don't think it's there since that's for you to equip, but I remember that before I had that disabled and the bonuses didn't work for me either. But you lose nothing by trying.

Edited by M2Dev

english_banner.gif

Link to comment
Share on other sites

On 7/3/2020 at 12:25 PM, TMP4 said:

Maybe i'm offing maybe not but i just gave the rings item_proto bonus and that will work, also you can show them to players with uitooltip.py, so either better.

 

Yup! It did work. Seems like item_ring reads bonuses from item_proto just like weapons, armors etc, or whatever. Thank you! It works flawlessly now.

Link to comment
Share on other sites

Please sign in to comment

You will be able to leave a comment after signing in



Sign In Now

Announcements



×
×
  • Create New...

Important Information

Terms of Use / Privacy Policy / Guidelines / We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.