Jump to content

How can I restrict name length of players? (34083)

Rumor
 Share

Recommended Posts

Rumor Mentor

Rumor 2540

Posted
Posted 
quest change_name_item begin
	state start begin
		when 71055.use begin
			say_title("Change of Name List")
			if pc.is_married() then
				say("")
				say("You can't change names when you're married.")
				say("")
				return
			elseif pc.is_polymorphed() then
				say("")
				say("You can't change names when you're transformed.")
				say("")
				return
			elseif pc.has_guild() then
				say("")
				say("You can't change names when you're in a guild.")
				say("")
				return
			elseif party.is_party() then
				say("")
				say("You can't change names when you're in a party.")
				say("")
				return
			elseif pc.get_level() < 80 then
				say("")
				say("You can't change names before level 80.")
				say("")
				return
			elseif get_time() < pc.getqf("next_time") then
				say("")
				say("You've recently changed your name.")
				say("You can't change your name right now.")
				say("")
				return
			end
			say("Please enter the name you want.")
			local name = pc.name
			local str = input()
			local ret = pc.change_name(str)
			say_title("Change of Name List")
			if ret == 0 then
			say("")
				say("You have not relogged since the last time you")
				say("changed your name. Please relog now.")
				say("")
				char_log(0, "CHANGE_NAME", "HAVE NOT RE-LOGIN")
			elseif ret == 1 then
				say("")
				say("There was a problem. Please try again.")
				say("")
				char_log(0, "CHANGE_NAME", "ITEM USE PROBLEM")
			elseif ret == 2 then
				say("")
				say("This name is not available.")
				say("Please select another name.")
				say("")
				char_log(0, "CHANGE_NAME", "CAN NOT USE NAME")
			elseif ret == 3 then
				say("")
				say("This name is not available.")
				say("Please select another name.")
				say("")
				char_log(0, "CHANGE_NAME", "ALREADY USING NAME")
			elseif ret == 4 then
				say("")
				say("Successful name change!")
				say("You cannot change your name again for")
				say("another 24 hours.")
				say("")
				pc.remove_item("71055", 1)
				pc.setqf("next_time", get_time() + time_hour_to_sec(24*1))
				horse.set_name(""..str"'s Horse")
				char_log(0, "CHANGE_NAME", "SUCCESS: from "..name.." to "..str)
				wait()
				pc.warp(pc.get_x()*100, pc.get_y()*100)
			else
				say("")
				say("Unknown error.")
				say("Please notify Rumor with this number:")
				say(ret)
				say("and he will take a look at the issue.")
				say("")
				char_log(0, "CHANGE_NAME", "UNKNOWN NAME")
			end
		end
	end
end

The players are choosing very long names which can't be typed in a private message window or fully seen on their character. I need to be able to limit their name length somehow.

Link to comment
Share on other sites
  • Replies 9
  • Created
  • Last Reply

Top Posters In This Topic

Popular Days

Top Posters In This Topic

Popular Days

Popular Posts

Aveline™
Aveline™

function isLongName(name) return string.len(name) < 16 end local readMe = input() if(isLongName(tostring(readMe)) == false) then print("Your name is very long !...") else print("Your name is no

PACI
PACI

Yes you're right, it should work.

Aveline™ Rising Star

Aveline™ 541

Posted
Posted

so I would add the function and local then add the rest with an elseif statement somewhere after line 47 right?

quest change_name_item begin
    state start begin
		function isLongName(name)
			return string.len(name) < 16
		end
        when 71055.use begin
            say_title("Change of Name List")
            if pc.is_married() then
                say("")
                say("You can't change names when you're married.")
                say("")
                return
            elseif pc.is_polymorphed() then
                say("")
                say("You can't change names when you're transformed.")
                say("")
                return
            elseif pc.has_guild() then
                say("")
                say("You can't change names when you're in a guild.")
                say("")
                return
            elseif party.is_party() then
                say("")
                say("You can't change names when you're in a party.")
                say("")
                return
            elseif pc.get_level() < 80 then
                say("")
                say("You can't change names before level 80.")
                say("")
                return
            elseif get_time() < pc.getqf("next_time") then
                say("")
                say("You've recently changed your name.")
                say("You can't change your name right now.")
                say("")
                return
            end
            say("Please enter the name you want.")
            local name = pc.name
            local str = input()
			if(change_name_item.isLongName(tostring(str)) == false) then
				say_title("Error 1")
				say("")
				---
				say("I'm sorry but your name very long")
				say("and you don't do this. ")
				return
			end
            local ret = pc.change_name(str)
            say_title("Change of Name List")
            if ret == 0 then
            say("")
                say("You have not relogged since the last time you")
                say("changed your name. Please relog now.")
                say("")
                char_log(0, "CHANGE_NAME", "HAVE NOT RE-LOGIN")
            elseif ret == 1 then
                say("")
                say("There was a problem. Please try again.")
                say("")
                char_log(0, "CHANGE_NAME", "ITEM USE PROBLEM")
            elseif ret == 2 then
                say("")
                say("This name is not available.")
                say("Please select another name.")
                say("")
                char_log(0, "CHANGE_NAME", "CAN NOT USE NAME")
            elseif ret == 3 then
                say("")
                say("This name is not available.")
                say("Please select another name.")
                say("")
                char_log(0, "CHANGE_NAME", "ALREADY USING NAME")
            elseif ret == 4 then
                say("")
                say("Successful name change!")
                say("You cannot change your name again for")
                say("another 24 hours.")
                say("")
                pc.remove_item("71055", 1)
                pc.setqf("next_time", get_time() + time_hour_to_sec(24*1))
                horse.set_name(""..str"'s Horse")
                char_log(0, "CHANGE_NAME", "SUCCESS: from "..name.." to "..str)
                wait()
                pc.warp(pc.get_x()*100, pc.get_y()*100)
            else
                say("")
                say("Unknown error.")
                say("Please notify Rumor with this number:")
                say(ret)
                say("and he will take a look at the issue.")
                say("")
                char_log(0, "CHANGE_NAME", "UNKNOWN NAME")
            end
        end
    end
end

Like this?

Plain logic saves lives.

Link to comment
Share on other sites
Rumor Mentor

Rumor 2540

Posted
  • Author
Posted

oh I was going to do it this way:

quest change_name_item begin
	state start begin
		when 71055.use begin
			say_title("Change of Name List")
			if pc.is_married() then
				say("")
				say("You can't change names when you're married.")
				say("")
				return
			elseif pc.is_polymorphed() then
				say("")
				say("You can't change names when you're transformed.")
				say("")
				return
			elseif pc.has_guild() then
				say("")
				say("You can't change names when you're in a guild.")
				say("")
				return
			elseif party.is_party() then
				say("")
				say("You can't change names when you're in a party.")
				say("")
				return
			elseif pc.get_level() < 80 then
				say("")
				say("You can't change names before level 80.")
				say("")
				return
			elseif get_time() < pc.getqf("next_time") then
				say("")
				say("You've recently changed your name.")
				say("You can't change your name right now.")
				say("")
				return
			end
			say("Please enter the name you want.")
				function isLongName(name)
					return string.len(name) < 16
				end
			local name = pc.name
			local length = input()
			local str = input()
			local ret = pc.change_name(str)
			say_title("Change of Name List")
			if ret == 0 then
			say("")
				say("You have not relogged since the last time you")
				say("changed your name. Please relog now.")
				say("")
				char_log(0, "CHANGE_NAME", "HAVE NOT RE-LOGIN")
			elseif ret == 1 then
				say("")
				say("There was a problem. Please try again.")
				say("")
				char_log(0, "CHANGE_NAME", "ITEM USE PROBLEM")
			elseif ret == 2 then
				say("")
				say("This name is not available.")
				say("Please select another name.")
				say("")
				char_log(0, "CHANGE_NAME", "CAN NOT USE NAME")
			elseif ret == 3 then
				say("")
				say("This name is not available.")
				say("Please select another name.")
				say("")
				char_log(0, "CHANGE_NAME", "ALREADY USING NAME")
			elseif(isLongName(tostring(length)) == false) then
				say("")
				say("Your name is too long.")
				say("Please select another.")
				say("")
				char_log(0, "CHANGE_NAME", "NAME TOO LONG")
			elseif ret == 4 then
				say("")
				say("Successful name change!")
				say("You cannot change your name again for")
				say("another 24 hours.")
				say("")
				pc.remove_item("71055", 1)
				pc.setqf("next_time", get_time() + time_hour_to_sec(24*1))
				horse.set_name(""..str"'s Horse")
				char_log(0, "CHANGE_NAME", "SUCCESS: from "..name.." to "..str)
				wait()
				pc.warp(pc.get_x()*100, pc.get_y()*100)
			else
				say("")
				say("Unknown error.")
				say("Please notify Rumor with this number:")
				say(ret)
				say("and he will take a look at the issue.")
				say("")
				char_log(0, "CHANGE_NAME", "UNKNOWN NAME")
			end
		end
	end
end

Link to comment
Share on other sites
Rumor Mentor

Rumor 2540

Posted
  • Author
Posted

I've got this now

quest change_name_item begin
    state start begin
        function isLongName(name)
            return string.len(name) < 16
        end
        when 71055.use begin
            say_title("Change of Name List")
            if pc.is_married() then
                say("")
                say("You can't change names when you're married.")
                say("")
                return
            elseif pc.is_polymorphed() then
                say("")
                say("You can't change names when you're transformed.")
                say("")
                return
            elseif pc.has_guild() then
                say("")
                say("You can't change names when you're in a guild.")
                say("")
                return
            elseif party.is_party() then
                say("")
                say("You can't change names when you're in a party.")
                say("")
                return
            elseif pc.get_level() < 80 then
                say("")
                say("You can't change names before level 80.")
                say("")
                return
            elseif get_time() < pc.getqf("next_time") then
                say("")
                say("You've recently changed your name.")
                say("You can't change your name right now.")
                say("")
                return
            end
            say("Please enter the name you want.")
            local name = pc.name
            local str = input()
            if(change_name_item.isLongName(tostring(str)) == false) then
                say_title("Change of Name List")
                say("")
                say("The entered name is too long.")
                say("Please select another name.")
				say("")
				char_log(0, "CHANGE_NAME", "NAME TOO LONG")
                return
            end
            local ret = pc.change_name(str)
            say_title("Change of Name List")
            if ret == 0 then
            say("")
                say("You have not relogged since the last time you")
                say("changed your name. Please relog now.")
                say("")
                char_log(0, "CHANGE_NAME", "HAVE NOT RE-LOGIN")
            elseif ret == 1 then
                say("")
                say("There was a problem. Please try again.")
                say("")
                char_log(0, "CHANGE_NAME", "ITEM USE PROBLEM")
            elseif ret == 2 then
                say("")
                say("This name is not avaliable.")
                say("Please select another name.")
                say("")
                char_log(0, "CHANGE_NAME", "CAN NOT USE NAME")
            elseif ret == 3 then
                say("")
                say("This name is not avaliable.")
                say("Please select another name.")
                say("")
                char_log(0, "CHANGE_NAME", "ALREADY USING NAME")
            elseif ret == 4 then
                say("")
                say("Successful name change!")
                say("You cannot change your name again for")
                say("another 24 hours.")
                say("")
                pc.remove_item("71055", 1)
                pc.setqf("next_time", get_time() + time_hour_to_sec(24*1))
                horse.set_name(""..str"'s Horse")
                char_log(0, "CHANGE_NAME", "SUCCESS: from "..name.." to "..str)
                wait()
                pc.warp(pc.get_x()*100, pc.get_y()*100)
            else
                say("")
                say("Unknown error.")
                say("Please notify Rumor with this number:")
                say(ret)
                say("and he will take a look at the issue.")
                say("")
                char_log(0, "CHANGE_NAME", "UNKNOWN NAME")
            end
        end
    end
end

Link to comment
Share on other sites
  • Developer
PACI Proficient

PACI 911

Posted
  • Developer
Posted

When you create a function in a questfile, you always have to use it like: quest_name.function_name, otherwise the game will try to find that function, in questlib or in game core. And it'll return nil because that function doesn't exists.

All you needed was adding string.len(str) < 16.

when you return 0 and server doesn't boot:

unknown.png

Link to comment
Share on other sites
Rumor Mentor

Rumor 2540

Posted
  • Author
Posted

When you create a function in a questfile, you always have to use it like: quest_name.function_name, otherwise the game will try to find that function, in questlib or in game core.

All you needed was adding string.len(str) < 16.

Yeah I know that about functions, I just didn't know how to add this limitation to the scroll. The latest quest I posted should work fine, right?

Link to comment
Share on other sites

Please sign in to comment

You will be able to leave a comment after signing in



Sign In Now
 Share
Go to topic listing

Announcements



  • Similar Content

  • Activity

    1. 24

      Experimental Renderer

      Implemented screen space ambient occlusion. In the images below, the effect was exaggerated a little to make it more visible.
      TheEqualizer in Showcase
    2. 11

      Enable Scaling for Buttons

      asdasdasdasd
      mozgur in Programming & Scripts
    3. 11

      Multi Language System

      char.cpp in void CHARACTER::ChatPacket this: #ifdef ENABLE_MULTILANGUAGE std::string sTranslateText; if (type != CHAT_TYPE_COMMAND) { if (GetLang() > MAX_LANGUAGES) sTranslateText = LC_TEXT(DEFAULT_LANGUAGE, format); else sTranslateText = LC_TEXT(GetLang(), format); } #endif and this a little under: #ifdef ENABLE_MULTILANGUAGE int len = vsnprintf(chatbuf, sizeof(chatbuf), format, args); if (type != CHAT_TYPE_COMMAND) len = vsnprintf(chatbuf, sizeof(chatbuf), sTranslateText.c_str(), args); #else Is just not needed at all and makes this problem. Every shout, party, info etc chat would go to LC_TEXT what adds a "@0949" to the message if translation not found in in locale.cpp's locale_find (it's hidden but you can see in /n for example or if you write messages to console) and that "@0949" makes accents bad plus you get a syserr each time somebody shout or party or guild chat etc. So you can delete this 2 ifdef if you already set every LC_TEXT(DEFAULT_LANGUAGE.. / LC_TEXT(ch->GetLang().. and I'm sure you did because LC_TEXT's new first attribute is mandatory so if you didn't then you couldn't compile the game. So that's why I said this is just not needed at all and can be removed. Edit: LC_TEXT(TRANSLATE_LANGUAGE will not work. Use LC_TEXT(ch->GetLang().. (Sorry for bumping old topic but I wanted to share the fix)
      TMP4 in Features & Metin2 Systems
    4. 0

      [FREE DESIGN] Interface + Logo + Discord Banner and Avatar

      Download Alternative download links → GG Drive Hello all, I decided to offer this package for free to someone who really needs it. The archive contains everything you need to modify this template Careful! The interface is PSD only You can contact me anytime if you want to edit something Have fun!
      • 1
      • Love
      unqdesign in 2D Graphics
    5. 4

      Feeding game source to LLM

      You don't need to train it on your source code. You just need to take a good model and give it more context. For example I use Github Copilot to help me with some trivial task while coding. If I need info about the whole source I just use @workspace in the chat when I ask it a question and then he has more context about the source.
      Abel(Tiger) in Metin2
    6. 0

      Quest 6/7 Problem

      Hi, sorry for my terrible English. I have a problem with system 6/7 of these server files. [Hidden Content] They do not bring the system quest. I don't know much about programming quests, I tried to adapt a quest from other server files, but I only managed to get it to open the bonus window. Does anyone have the quest or can do it? I would greatly appreciate the help I use '--' just for identify the quest_function I had and the quest I try to adapt [Hidden Content]
      Rags in Community Support - Questions & Answers
    7. 5

      Effect weapons

      I have the .mde and the .mse next to each other however this does not really work.. I have the correct EFFECT_REFINED + (the number of the enum value) in the playersettingmodule.py I applied the effect on InstanceBase.cpp (considering the item's vnum) with no luck.. Do I miss something? Does those files have a prefix path or something? Like if I put them on the wrong path (think about the granny texture) will not find them at all?
      white in Community Support - Questions & Answers
    8. 0

      [C++] Fix Core Downer Using Negative Number in GM Codes

      INTRODUCTION & PROBLEM Hello, today we will fix a few errors, especially the error that caused the core down by giving an unexpected negative (-) arg (number) in the commands (Example; /mob 101 -1), and we will also regulate the use of "ChatPacket" in this functions. WHY ? GMs are already part of the team, you may ask why we need this, you are right, but do not forget that a GM who does not have coding knowledge may accidentally trigger this, let's not leave it to chance. SOLUTION The process we will do is simple, it will be enough to make sure that the given arg value is within the range we want, let's get started. [Hidden Content]
      • 13
      • Good
      • Metin2 Dev
      • muscle
      • Love
      MT2Dev in Bug Fixes
    9. 3

      Crystal Metinstone

      Awesome!! Can u make it with other colors too? Like ice fire forest lightning ?
      asdasd1234 in Metinstones

  • Recently Browsing

    • No registered users viewing this page.
×
×
  • Create New...

Important Information

Terms of Use / Privacy Policy / Guidelines / We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.