Jump to content

Fix Client's Height / Taskbar Collision after VsUpdate


Speachless

Recommended Posts

  • Premium

I like the titlebar we have when compiling with vs2019, but makes the client to have a bigger height.

 

In PythonSystem.cpp search for

if (m_Config.height >= screen_height)

And update with

if (m_Config.height >= screen_height)
{
  int config_height = m_Config.height;
  int difference = (config_height-screen_height)+7;
  m_Config.height = config_height - difference;
}

Without fix:

spacer.png

 

With fix:

spacer.png

 

Edited by Metin2 Dev
Core X - External 2 Internal
  • Metin2 Dev 1
  • Good 2
  • Love 11
Link to comment
Share on other sites

  • Forum Moderator
11 minutes ago, WeedHex said:

Never get these problems, I think is your python different from default.

In fact it's not and it's unrelated to python. When you compile for more recent versions of Windows the application bar will get thicker and it will hide a bit of the ingame taskbar into the Windows taskbar.

 

Thanks for your guide!

Edited by Gurgarath
  • Love 1

Gurgarath
coming soon

Link to comment
Share on other sites

  • Forum Moderator
36 minutes ago, WeedHex said:

Never had these problems and I have everything extremely updated.

Lucky or do you have to change something in your builds? 

Btw of course thx for sharing it.

I also have everything updated (VS and Libs and so on) and it happens to me, are you compilling using the latest toolset?

 

https://metin2.download/picture/q698ZgQYNEdDVCZ0XQ6iz8ra1HOJaK73/.png

https://metin2.download/picture/q698ZgQYNEdDVCZ0XQ6iz8ra1HOJaK73/.png

Edited by Metin2 Dev
Core X - External 2 Internal
  • Metin2 Dev 2
  • Confused 1
  • Good 2

Gurgarath
coming soon

Link to comment
Share on other sites

  • Premium
6 minutes ago, Gurgarath said:

I also have everything updated (VS and Libs and so on) and it happens to me, are you compilling using the latest toolset?

 

https://metin2.download/picture/q698ZgQYNEdDVCZ0XQ6iz8ra1HOJaK73/.png

https://metin2.download/picture/q698ZgQYNEdDVCZ0XQ6iz8ra1HOJaK73/.png

Of course. Btw it depends on the size of the screen above all, I don't understand why making such a forced change when the user can decide on many alternatives of size.

To me happens only if I set the "window mode" in the max size (i've a big screen). But the problem is truly "invisible".

Edited by Metin2 Dev
Core X - External 2 Internal
  • Metin2 Dev 1
  • Love 1
Link to comment
Share on other sites

  • 1 year later...

Thank you! Works perfectly!

 

Do you know by any chance where do you fix the client window position aswell?

My client always opens with margin left of around 7 pixels

Screenshot:

Spoiler

spacer.png

 

It's windowed, max size, a bit of the window shows up in my second monitor..

That thing bothers me everytime and i have to drag it everytime..

 

Thanks in advance! 

Edited by Metin2 Dev
Core X - External 2 Internal
  • Confused 1
  • Love 1

It's all lies

Link to comment
Share on other sites

  • 7 months later...
  • Forum Moderator
On 2/3/2021 at 7:07 PM, displayjokes said:

Thank you! Works perfectly!

 

Do you know by any chance where do you fix the client window position aswell?

My client always opens with margin left of around 7 pixels

Screenshot:

  Reveal hidden contents

 

It's windowed, max size, a bit of the window shows up in my second monitor..

That thing bothers me everytime and i have to drag it everytime..

 

Thanks in advance! 

 

Edited by Metin2 Dev
Core X - External 2 Internal
  • Good 1
  • Love 1

Gurgarath
coming soon

Link to comment
Share on other sites

Announcements



×
×
  • Create New...

Important Information

Terms of Use / Privacy Policy / Guidelines / We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.