Shop Ex Renewal

Resist0 · April 23, 2020

I saw you updated the whole code of the system.

I have error compiling with this part :

https://metin2.download/picture/r3F9504x09DVmF8K988YXgTtGTP6KMUj/.gif

#ifdef ENABLE_RENEWAL_SHOPEX
	{
		std::unordered_set<CShop*> v;
		// include unordered_set
		auto ExDelete = [&v](TShopMap& c) {
			for (auto it = c.begin(); !c.empty() && it != c.end();) {
				const auto shop = it->second;
				if (shop && shop->IsShopEx()) {
					it = c.erase(it);
					v.insert(shop);
				}
				else
					++it;
			}
		};
		ExDelete(m_map_pkShopByNPCVnum);
		ExDelete(m_map_pkShop);
		for (const auto& del : v)
			delete del;
	}
#endif

What do you mean with include unordered set ?
I try to #include "<boost>unordered_set.hpp" but that does not work so far.

Edited September 4, 2022 by Metin2 Dev
Core X - External 2 Internal

Owsap · April 23, 2020

@Chief you should show us the error you are having, try to change

std::unordered_set<CShop*> v;

↓

boost::unordered_set<CShop*> v;

Resist0 · April 23, 2020

57 minutes ago, Owsap said:
@Chief you should show us the error you are having, try to change
std::unordered_set<CShop*> v;
↓
boost::unordered_set<CShop*> v;

Edited post.

Don´t work.

https://metin2.download/picture/r3F9504x09DVmF8K988YXgTtGTP6KMUj/.gif

Added :

#include <boost/unordered_set.hpp> to shop_manager.cpp

Now i get :

SYSERR: Apr 23 17:28:12 :: Boot: shop table size error

Edit: didn´t recompiled whole src.

Sooo after that all , shop is empty:

https://metin2.download/picture/r3F9504x09DVmF8K988YXgTtGTP6KMUj/.gif

But thanks @Owsap

Edited September 4, 2022 by Metin2 Dev
Core X - External 2 Internal

Resist0 · April 26, 2020

Anyone?

https://metin2.download/picture/r3F9504x09DVmF8K988YXgTtGTP6KMUj/.gif

Shop is empty, but opens.

Edited September 4, 2022 by Metin2 Dev
Core X - External 2 Internal

Volvox · August 4, 2020

Have a other problem.

He use to show items:
CShopEx::AddGuest()
But when i buy something, he use:
pkShop->Buy()

This Buy is shop.cpp and not shopex.cpp

So the Buy of shop.cpp does not know the items from shopex.

So everytime m_itemVector.size() = 0

And so i cant buy items on shopex

Edited August 4, 2020 by V0lvox

[email protected] · August 18, 2020

SYSERR: Aug 18 08:48:50 :: pid_init:
Start of pid: 5058

SYSERR: Aug 18 08:48:51 :: Boot: shop table size error
SYSERR: Aug 18 08:48:51 :: SpawnEventHelper: cannot get map base position 1
SYSERR: Aug 18 08:48:51 :: SpawnEventHelper: cannot get map base position 3
SYSERR: Aug 18 08:48:51 :: SpawnEventHelper: cannot get map base position 21
SYSERR: Aug 18 08:48:51 :: SpawnEventHelper: cannot get map base position 23
SYSERR: Aug 18 08:48:51 :: SpawnEventHelper: cannot get map base position 41
SYSERR: Aug 18 08:48:51 :: SpawnEventHelper: cannot get map base position 43
SYSERR: Aug 18 08:48:51 :: pid_deinit:
End of pid

Where its the problem ? =(

Volvox · August 18, 2020

2 hours ago, [email protected] said:

SYSERR: Aug 18 08:48:50 :: pid_init:
Start of pid: 5058

SYSERR: Aug 18 08:48:51 :: Boot: shop table size error
SYSERR: Aug 18 08:48:51 :: SpawnEventHelper: cannot get map base position 1
SYSERR: Aug 18 08:48:51 :: SpawnEventHelper: cannot get map base position 3
SYSERR: Aug 18 08:48:51 :: SpawnEventHelper: cannot get map base position 21
SYSERR: Aug 18 08:48:51 :: SpawnEventHelper: cannot get map base position 23
SYSERR: Aug 18 08:48:51 :: SpawnEventHelper: cannot get map base position 41
SYSERR: Aug 18 08:48:51 :: SpawnEventHelper: cannot get map base position 43
SYSERR: Aug 18 08:48:51 :: pid_deinit:
End of pid

Where its the problem ? =(

Boot: shop table size error

there

GameHun · January 7, 2021

I dont see the icon when is hover the item in shop! What is the problem? Tooltip.py is OK with paste!

Mali · January 18, 2021

~~txt~~ -> mysql

numNum · January 18, 2021

36 minutes ago, Mali61 said:

~~txt~~ -> mysql

Thanks , you are on fire man

mysql is a way better and organized

Edited January 18, 2021 by jeddawee

TryHard · January 19, 2021

thank you so much , when I use mysql version this bug solved

https://metin2.download/picture/T6a8GpQzeIvpCV7O9q6d5qzY8s0dY2yW/.png

Edited September 4, 2022 by Metin2 Dev
Core X - External 2 Internal

DemOnJR · January 19, 2021

Working with the mysql version on martysama too.

Spoiler

Edited September 4, 2022 by Metin2 Dev
Core X - External 2 Internal

Entry · January 25, 2021

Hy.... i have this problem

https://metin2.download/picture/78B9l09Wc9kL71LCsbT567S47Jafx0i2/.jpg

only that 2 spaces ... have that problem if i add something still .... the count for that items

Edited September 4, 2022 by Metin2 Dev
Core X - External 2 Internal

Klaus · February 1, 2021

Problem with socket0 (item time)

I tried to put in 30 days, but it didn't work, so I took the full timestamp and it worked, however, time goes on, even in the store

Can anyone help me fix:

- Add in socket0 only 2592000 for 30 days, not "1615058951"
- Time does not count while the item is in the store

lucaluca · February 7, 2021

For anyone who wants to reload 'shopex' & 'shopex_item' using /reload p

(works on the db/mysql version only)

1. You must have this

2. game/src

input_db.cpp

Spoiler

In void CInputDB::ReloadProto(const char * c_pData) search for:

/*

* SHOP

*/

wSize = decode_2bytes(c_pData);

c_pData += sizeof(WORD);

sys_log(0, "RELOAD: SHOP: %d", wSize);

if (wSize)

{

CShopManager::instance().Initialize((TShopTable *)c_pData, wSize);

c_pData += wSize * sizeof(TShopTable);

}

Add below:

/*

* SHOPEX

*/

wSize = decode_2bytes(c_pData);

c_pData += sizeof(WORD);

sys_log(0, "RELOAD: SHOPEX: %d", wSize);

if (wSize)

{

CShopManager::instance().InitializeShopEX((TShopTable *)c_pData, wSize);

c_pData += wSize * sizeof(TShopTable);

}

3. db/src

ClientManager.cpp

Spoiler

In void CClientManager::QUERY_RELOAD_PROTO() search for:

sizeof(WORD) + sizeof(TShopTable) * m_iShopTableSize +

Add below:

#if defined(ENABLE_RENEWAL_SHOPEX)

sizeof(WORD) + sizeof(TShopTable) * m_iShopEXTableSize +

#endif

Search:

tmp->EncodeWORD(m_iShopTableSize);

tmp->Encode(m_pShopTable, sizeof(TShopTable) * m_iShopTableSize);

Add below:

#if defined(ENABLE_RENEWAL_SHOPEX)

tmp->EncodeWORD(m_iShopEXTableSize);

tmp->Encode(m_pShopEXTable, sizeof(TShopTable) * m_iShopEXTableSize);

#endif

And that's it

Proof

Spoiler

Edited September 4, 2022 by Metin2 Dev
Core X - External 2 Internal

Mali · February 7, 2021

On 2/1/2021 at 11:16 PM, Klaus said:

Problem with socket0 (item time)

I tried to put in 30 days, but it didn't work, so I took the full timestamp and it worked, however, time goes on, even in the store

Can anyone help me fix:

- Add in socket0 only 2592000 for 30 days, not "1615058951"
- Time does not count while the item is in the store

Hey, I made a little change.

If you want to use item with limit times, don't change sockets. Let it be 0 (it will use item_proto's time)

Doose · March 18, 2021

I did everything correctly, and i cant add the items to the shop, can you check?

Doose · March 18, 2021

Hi again, i conclude that, normal shops can be oppened,

9001 can't open but doesnt do core.crash

9002 can't open and do core.crash,

any idea??

#0 0x0060ab78 in std::__1::operator==<SShopTableEx*, SShopTableEx*> (__x=..., __y=...)
at /usr/include/c++/v1/iterator:1506
No locals.
#1 std::__1::operator!=<SShopTableEx*> (__x=..., __y=...) at /usr/include/c++/v1/iterator:1558
No locals.
#2 CShopEx::AddGuest (this=0x0, ch=<optimized out>, owner_vid=0, bOtherEmpire=<optimized out>)
at shopEx.cpp:75
it = {__i = 0x23138af8}
pack = {header = 38 '&', size = 39769, subheader = 10 '\n'}
pack2 = {owner_vid = 62200, shop_tab_count = 3 '\003'}
temp = "ARMOR\000\000\000\000\000\000\000\000\000\000>\000\000\000h\214\377\377?\252\027\001\000\000\001\000\000\000\311+\000\000\250a\000\000\000\000\000\000\001", '\000' <repeats 47 times>, "\001\000\000\000\000#,\000\000\372\000\000\000\000\000\000\000\001\000\270", '\000' <repeats 27 times>, "\001\320\a", '\000' <repeats 15 times>, "\001", '\000' <repeats 83 times>...
size = 10466
buf = 0xffffac92 "\202\"\240$\252!\345\003"
#3 0x00000000 in ?? ()
No symbol table info available.

Edited March 19, 2021 by Doose

Doose · March 19, 2021

On 4/1/2020 at 7:17 PM, TheR3LAX13 said:

@VegaS™ @Mali61 pls help me!!!

No'ne answearing ...

Psiclone · March 29, 2021

gmake: *** [Makefile:183: .obj/shopEx.o] Error 1
root@jailsrc:/source/Server/game/src # gmake -j2
compiling shopEx.cpp
shopEx.cpp: In member function 'virtual bool CShopEx::AddGuest(LPCHARACTER, DWORD, bool)':
shopEx.cpp:125:17: error: qualified-id in declaration before '(' token
125 | int CShopEx::Buy(LPCHARACTER ch, BYTE pos)
| ^
shopEx.cpp:292:34: error: expected '}' at end of input
292 | return (SHOP_SUBHEADER_GC_OK);
| ^
shopEx.cpp:47:1: note: to match this '{'
47 | {
| ^
shopEx.cpp:292:34: warning: control reaches end of non-void function [-Wreturn-type]
292 | return (SHOP_SUBHEADER_GC_OK);

Any ideea?

Pachii · April 16, 2021

How can I expand the number of tabs from 3 to 7?

Edited April 21, 2021 by Pachii
Question

Pachii · April 21, 2021

@Mali61 How can I expand the number of tabs from 3 to 7?

TysonDMG · June 14, 2021

SYSERR: Jun 14 05:26:29 :: InitializeShopEX: Shop vnum(11) already exists.
SYSERR: Jun 14 05:26:29 :: Boot: shopex table Initialize error

help, please?

DemOnJR · June 14, 2021

32 minutes ago, TysonDMG said:

SYSERR: Jun 14 05:26:29 :: InitializeShopEX: Shop vnum(11) already exists.
SYSERR: Jun 14 05:26:29 :: Boot: shopex table Initialize error

help, please?

You need use an vnum id that not exists already

Edited June 14, 2021 by DemOnJR

TysonDMG · June 14, 2021

Now instead of item, yang displays exp

the first is with yang and second with item

https://metin2.download/picture/EZivzdZ2Z4zhRCIHkldcWhfVaR9ukQtX/.gif

Edited August 28, 2022 by Metin2 Dev
Core X - External 2 Internal

Sign In

Shop Ex Renewal

Recommended Posts

Resist0 36

Link to comment

Share on other sites

Top Posters In This Topic

Popular Days

Top Posters In This Topic

Popular Days

Popular Posts

Mali

VegaS™

DemOnJR

Owsap 7700

Link to comment

Share on other sites

Resist0 36

Link to comment

Share on other sites

Resist0 36

Link to comment

Share on other sites

Volvox 1453

Link to comment

Share on other sites

[email protected] 1

Link to comment

Share on other sites

Volvox 1453

Link to comment

Share on other sites

GameHun 0

Link to comment

Share on other sites

Mali 39360

Link to comment

Share on other sites

numNum 36

Link to comment

Share on other sites

TryHard 4

Link to comment

Share on other sites

DemOnJR 511

Link to comment

Share on other sites

Entry 11

Link to comment

Share on other sites

Klaus 144

Link to comment

Share on other sites

lucaluca 14

Link to comment

Share on other sites

Mali 39360

Link to comment

Share on other sites

Doose 1447

Link to comment

Share on other sites

Doose 1447

Link to comment

Share on other sites

Doose 1447

Link to comment

Share on other sites

Psiclone 1

Link to comment

Share on other sites

Pachii 19

Link to comment

Share on other sites

Pachii 19

Link to comment

Share on other sites

TysonDMG 6

Link to comment

Share on other sites