Jump to content

Lead0b110010100

Member
  • Posts

    16
  • Joined

  • Last visited

  • Feedback

    0%

About Lead0b110010100

Recent Profile Visitors

The recent visitors block is disabled and is not being shown to other users.

Lead0b110010100's Achievements

Enthusiast

Enthusiast (6/16)

  • Collaborator
  • Conversation Starter
  • Reacting Well
  • Dedicated
  • First Post

Recent Badges

15

Reputation

  1. Oh wow, my comment got more backlash than I thought it would. I was like "Why should someone put such a crazy value there, that's stupid as hell. But someone did, so did you find a fix for it." The problem we are trying to solve here is not a new one, try entering 9000000000 as a value for the width parameter for example. It will also overflow, resulting in a 'random' value of m_Config.width or a crash. We can't really 'fix' the underlying problem here, which is that serialization of numbers can result in overflows. If you take a 8 bit data type like 'long long' instead of the 4 bit 'int' for m_Config.width, someone could still write a bigger number. What I wan't to say is: This check might result in randomly true or false, regarding the value after the overflow in the config parameter. if (m_Config.width >= screen_width_1) Sorry if my first comment sounded rude or offensive, it was definitely not meant like that.
  2. But... why should someone do that xDD And why should a server admin care hahahha
  3. Thank you very much Ikarus. Not only that you fixxed it, I love how you explain the bug and your solution. I knew one more developer in this board that did that some time ago (Vanilla) and I missed such posts. I even learned something, thank you.
  4. You ware totally right, I replaced std::map with std::unordered_map here.
  5. I tested it and got like 44% RAM usage reduction. But I had to do some changes in order to not get exceptions when running the server on windows. (Due to unintialized usage of map) + I changed way more lines of code to do that, but the idea is absolutely correct.
  6. I do have a fix for that actually. But I don't know if I want to sell / release it. Maybe in some months in my own shop.
  7. That comment is dumb af. You can't secure your self against sql injections by just disallowing people from using special characters. That's not the point of cyber defence.
  8. Very nice release, I was bothering with that since I first saw that stupidity! There is only one way we could improve the code 'style'. I think at the end, performance wise, It won't really affect the compilation or execution speed: Instead of increasing the counters before any continue; or at the end of the while loop, use "do-while" in combination with the increment operator: do { [...] } while (TextFileLoader.SetChildNode("hairdata", dwHairDataCount++));
  9. If you're done updating to llvm11 and 64 bit. Don't forget to play arounf with -fsanitizer. It works like a charm and helps me a lot!
  10. He needs to do that, but he needs to recompile / use the 64 bit equvivalent of the libs too. And he needs to recompile metin2's libs like libthecore etc etc. It's not as easy as it sounds if you ask me. Changing dependencies is always a shit ton of work / trial & error.
  11. Not possible with VS Code extensions as far as I know. But you could try SSHFS, there are tools that were developed from google to ensure a nice workflow.
  12. Hey Lead here from the other board. I don't think he has stolen it from me, maybe he got the idea from there and then coded it himself. I would recognize my own code style if he had really copied it one for one.
×
×
  • Create New...

Important Information

Terms of Use / Privacy Policy / Guidelines / We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.