Jira
Premium-
Posts
191 -
Joined
-
Days Won
2 -
Feedback
0%
Jira last won the day on July 8 2021
Jira had the most liked content!
About Jira
- Birthday 07/10/1995
Recent Profile Visitors
The recent visitors block is disabled and is not being shown to other users.
Jira's Achievements
-
Jira started following [FIX] Best fix - You cannot drop items from equipped items. , Player Block System , Quest States Core Crash Item Dupe Bug Fix and 4 others
-
[Hidden Content]. Svn/Server/game/cmd_general.cpp#L91 [Hidden Content]. Svn/Server/game/player_block.cpp#L43 [Hidden Content]. Svn/Server/game/player_block.cpp#L139C4-L139C4 ez sql inject xd
- 23 replies
-
- 45
-
item drop penalty source/server/game/char_battle.cpp | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/source/server/game/char_battle.cpp b/source/server/game/char_battle.cpp index 4b0c013..9f9fab6 100644 --- a/source/server/game/char_battle.cpp +++ b/source/server/game/char_battle.cpp @@ -1107,8 +1107,18 @@ void CHARACTER::ItemDropPenalty(LPCHARACTER pkKiller) std::vector<BYTE> vec_bSlots; for (i = 0; i < INVENTORY_MAX_NUM; ++i) - if (GetInventoryItem(i)) + { + if ((pkItem = GetInventoryItem(i))) + { + if (pkItem->GetType() == ITEM_QUEST) + { + if (quest::CQuestManager::instance().GetPCForce(GetPlayerID())->IsRunning() == true) + continue; + } + vec_bSlots.push_back(i); + } + } if (!vec_bSlots.empty()) {
-
Thanks. Observer mode has the same bug.
-
If you send the move and attack packet to target and if you have the same position as the target then this check is pointless. An extra check that you can add if (fHittingDistance == 0.0f && victim->GetX() == ch->GetX() && victim->GetY() == ch->GetY() && !victim->IsPC()) return;
-
Thanks, I'm so curious if can be exploitable with net.SendChangeNamePacket
-
fix [FIX] Best fix - You cannot drop items from equipped items.
Jira replied to Draveniou1's topic in Bug Fixes
I think you meant to do like this, with your fix you cannot drop gold. void CInputMain::ItemDrop2(LPCHARACTER ch, const char * data) { TPacketCGItemDrop2 * pinfo = (TPacketCGItemDrop2 *) data; if (!ch) return; if (pinfo->gold > 0) ch->DropGold(pinfo->gold); else { LPITEM pkItem = ch->GetItem(pinfo->Cell); if (!pkItem) return; if (pkItem->IsEquipped()) return; ch->DropItem(pinfo->Cell); } } But it's better to check inside of CHARACTER::DropItem function. Btw don't use macros it's enough to put a comment like // FIXME: can't drop equipment -
just add -Wno-invalid-source-encoding ex) CFLAGS = -m32 -g -Wall -O2 -pipe -fexceptions -std=c++17 -fno-strict-aliasing -pthread -D_THREAD_SAFE -DNDEBUG -Wno-invalid-source-encoding
-
fix Fix unknown header 100% server: 1k player online francec
Jira replied to Draveniou1's topic in Bug Fixes
Yes you're a big programmer (idiot). Give me on dm that server with 1k players I'll make that server to cry. -
fix Fix unknown header 100% server: 1k player online francec
Jira replied to Draveniou1's topic in Bug Fixes
20-30 days? Dmn pls somebody ban this idiot and delete this shit. For you're secure server really I don't recommend to remove te improved encryption (that's why is called 'IMPROVED'). -
fix Fix unknown header 100% server: 1k player online francec
Jira replied to Draveniou1's topic in Bug Fixes
I can find that key in 1min. What are you doing here is a bad practice, you can trick just the kids. -
[Hidden Content]
-
for client crash void CPythonApplication::__ResetCameraWhenMinimize() { if (m_CursorHandleMap.empty()) // FIXME return; CCameraManager& rkCmrMgr = CCameraManager::Instance(); CCamera* pkCmrCur = rkCmrMgr.GetCurrentCamera(); if (pkCmrCur) { pkCmrCur->EndDrag(); } SetCursorNum(NORMAL); if (CURSOR_MODE_HARDWARE == GetCursorMode()) { SetCursorVisible(TRUE); } } and void CPythonApplication::DestroyCursors() { for (auto itor = m_CursorHandleMap.begin(); itor != m_CursorHandleMap.end(); ++itor) DestroyCursor((HCURSOR)itor->second); m_CursorHandleMap.clear(); // FIXME }
-
# update added 1.6 lib src