Jump to content

Subtype weapon costume

DeYaN.
 Share

Recommended Posts

DeYaN. Proficient

DeYaN. 27

Posted
Posted (edited)

Hello friends , i have two problems at weapon costume with subtype .. 

( SOLVE ) When i equip the weapon at costume, i lost my weapon atack value from hand .. see the picture.The problem are VISUAL ( CLIENT ) because the damage is working fine. 

Spoiler

1213_042441.jpg

Spoiler

1213_042445.jpg

Spoiler

1213_042452.jpg

 

The subtype is 15 , i`m try to test with another subtype from hair and is working . I change in protoreader.cpp the value , but the problem still be there . 

Spoiler

static string arSub28[] = { "COSTUME_BODY", "COSTUME_HAIR", "NONE", "NONE", "NONE", "NONE", "NONE", "NONE", "NONE", "COSTUME_WEAPON_SWORD", "COSTUME_WEAPON_DAGGER", "COSTUME_WEAPON_BOW", "COSTUME_WEAPON_TWO_HANDED", "COSTUME_WEAPON_BELL", "COSTUME_WEAPON_FAN", "COSTUME_WEAPON_CLAW" };
    

 

( SOLVE ) i can`t atack with skill in mob , "i can't use this weapon" 

1213_231202.jpg

 

New problem ... 

 

The ninja with bow , don`t do damage .. and the arrows don`t use ..

Edited by Metin2 Dev
Core X - External 2 Internal
Link to comment
Share on other sites
  • Replies 10
  • Created
  • Last Reply

Top Posters In This Topic

Popular Days

Top Posters In This Topic

Popular Days

Popular Posts

DarkAng3l
DarkAng3l

PythonNetworkStreamPhaseGameActor.cpp  

DarkAng3l
DarkAng3l

I rewrite function GetWeaponType in InstanceBase.cpp, because I had same problem.  

DarkAng3l Contributor

DarkAng3l 25

Posted
Posted

PythonNetworkStreamPhaseGameActor.cpp

Spoiler

void __SetWeaponPower(IAbstractPlayer& rkPlayer, DWORD dwWeaponID)
{
    DWORD minPower=0;
    DWORD maxPower=0;
    DWORD minMagicPower=0;
    DWORD maxMagicPower=0;
    DWORD addPower=0;
#ifdef ENABLE_COSTUME_WEAPON
    //DMG RESET BUG FIX
    dwWeaponID = rkPlayer.GetItemIndex(TItemPos(INVENTORY, c_Equipment_Weapon));
#endif
    CItemData* pkWeapon;
    
    if (CItemManager::Instance().GetItemDataPointer(dwWeaponID, &pkWeapon))
    {
        if (pkWeapon->GetType()==CItemData::ITEM_TYPE_WEAPON)
        {
            minPower=pkWeapon->GetValue(3);
            maxPower=pkWeapon->GetValue(4);
            minMagicPower=pkWeapon->GetValue(1);
            maxMagicPower=pkWeapon->GetValue(2);
            addPower=pkWeapon->GetValue(5);
        }
    }
#ifdef ENABLE_COSTUME_WEAPON
    DWORD dwItemIndex = rkPlayer.GetItemIndex(TItemPos(INVENTORY, c_Costume_Slot_Weapon));

    CItemData* pkCostumeWeapon;
    if (CItemManager::Instance().GetItemDataPointer(dwItemIndex, &pkCostumeWeapon))
    {
        if (pkCostumeWeapon->GetType() == CItemData::ITEM_TYPE_COSTUME && pkCostumeWeapon->GetWeaponType() == CItemData::COSTUME_WEAPON_SWORD ||
            pkCostumeWeapon->GetWeaponType() == CItemData::COSTUME_WEAPON_DAGGER || pkCostumeWeapon->GetWeaponType() == CItemData::COSTUME_WEAPON_BOW ||
            pkCostumeWeapon->GetWeaponType() == CItemData::COSTUME_WEAPON_TWO_HANDED || pkCostumeWeapon->GetWeaponType() == CItemData::COSTUME_WEAPON_BELL ||
            pkCostumeWeapon->GetWeaponType() == CItemData::COSTUME_WEAPON_FAN || pkCostumeWeapon->GetWeaponType() == CItemData::COSTUME_WEAPON_CLAW)
        {
            minPower += pkCostumeWeapon->GetValue(3);
            maxPower += pkCostumeWeapon->GetValue(4);
            minMagicPower += pkCostumeWeapon->GetValue(1);
            maxMagicPower += pkCostumeWeapon->GetValue(2);
            addPower += pkCostumeWeapon->GetValue(5);
        }
    }
#endif

    rkPlayer.SetWeaponPower(minPower, maxPower, minMagicPower, maxMagicPower, addPower);
}
 

 

  • Love 1
Link to comment
Share on other sites
DeYaN. Proficient

DeYaN. 27

Posted
  • Author
Posted (edited)
35 minutes ago, DarkAng3l said:

PythonNetworkStreamPhaseGameActor.cpp

  Reveal hidden contents

void __SetWeaponPower(IAbstractPlayer& rkPlayer, DWORD dwWeaponID)
{
    DWORD minPower=0;
    DWORD maxPower=0;
    DWORD minMagicPower=0;
    DWORD maxMagicPower=0;
    DWORD addPower=0;
#ifdef ENABLE_COSTUME_WEAPON
    //DMG RESET BUG FIX
    dwWeaponID = rkPlayer.GetItemIndex(TItemPos(INVENTORY, c_Equipment_Weapon));
#endif
    CItemData* pkWeapon;
    
    if (CItemManager::Instance().GetItemDataPointer(dwWeaponID, &pkWeapon))
    {
        if (pkWeapon->GetType()==CItemData::ITEM_TYPE_WEAPON)
        {
            minPower=pkWeapon->GetValue(3);
            maxPower=pkWeapon->GetValue(4);
            minMagicPower=pkWeapon->GetValue(1);
            maxMagicPower=pkWeapon->GetValue(2);
            addPower=pkWeapon->GetValue(5);
        }
    }
#ifdef ENABLE_COSTUME_WEAPON
    DWORD dwItemIndex = rkPlayer.GetItemIndex(TItemPos(INVENTORY, c_Costume_Slot_Weapon));

    CItemData* pkCostumeWeapon;
    if (CItemManager::Instance().GetItemDataPointer(dwItemIndex, &pkCostumeWeapon))
    {
        if (pkCostumeWeapon->GetType() == CItemData::ITEM_TYPE_COSTUME && pkCostumeWeapon->GetWeaponType() == CItemData::COSTUME_WEAPON_SWORD ||
            pkCostumeWeapon->GetWeaponType() == CItemData::COSTUME_WEAPON_DAGGER || pkCostumeWeapon->GetWeaponType() == CItemData::COSTUME_WEAPON_BOW ||
            pkCostumeWeapon->GetWeaponType() == CItemData::COSTUME_WEAPON_TWO_HANDED || pkCostumeWeapon->GetWeaponType() == CItemData::COSTUME_WEAPON_BELL ||
            pkCostumeWeapon->GetWeaponType() == CItemData::COSTUME_WEAPON_FAN || pkCostumeWeapon->GetWeaponType() == CItemData::COSTUME_WEAPON_CLAW)
        {
            minPower += pkCostumeWeapon->GetValue(3);
            maxPower += pkCostumeWeapon->GetValue(4);
            minMagicPower += pkCostumeWeapon->GetValue(1);
            maxMagicPower += pkCostumeWeapon->GetValue(2);
            addPower += pkCostumeWeapon->GetValue(5);
        }
    }
#endif

    rkPlayer.SetWeaponPower(minPower, maxPower, minMagicPower, maxMagicPower, addPower);
}
 

 

THX MAN !! NOW THE VISUAL DAMAGE IS WORKING !!

the last problem is " i can`t atack with skill in mob , "i can't use this weapon" 

1213_231202.jpg

Edited by Metin2 Dev
Core X - External 2 Internal
Link to comment
Share on other sites
DarkAng3l Contributor

DarkAng3l 25

Posted
Posted

I rewrite function GetWeaponType in InstanceBase.cpp, because I had same problem.

Spoiler

DWORD CInstanceBase::GetWeaponType()
{
    DWORD dwWeapon = GetPart(CRaceData::PART_WEAPON);
    CItemData * pItemData;
    if (!CItemManager::Instance().GetItemDataPointer(dwWeapon, &pItemData))
        return CItemData::WEAPON_NONE;
#ifdef ENABLE_COSTUME_WEAPON
    if (pItemData->GetType() == CItemData::ITEM_TYPE_COSTUME)
    {
        if (pItemData->GetSubType() == CItemData::COSTUME_WEAPON_SWORD)
            return CItemData::WEAPON_SWORD;
        else if (pItemData->GetSubType() == CItemData::COSTUME_WEAPON_DAGGER)
            return CItemData::WEAPON_DAGGER;
        else if (pItemData->GetSubType() == CItemData::COSTUME_WEAPON_BOW)
            return CItemData::WEAPON_BOW;
        else if (pItemData->GetSubType() == CItemData::COSTUME_WEAPON_TWO_HANDED)
            return CItemData::WEAPON_TWO_HANDED;
        else if (pItemData->GetSubType() == CItemData::COSTUME_WEAPON_BELL)
            return CItemData::WEAPON_BELL;
        else if (pItemData->GetSubType() == CItemData::COSTUME_WEAPON_FAN)
            return CItemData::WEAPON_FAN;
        else if (pItemData->GetSubType() == CItemData::COSTUME_WEAPON_CLAW)
            return CItemData::WEAPON_CLAW;
        else
            return pItemData->GetWeaponType();
    }
#endif
    return pItemData->GetWeaponType();
}

 

  • Love 1
Link to comment
Share on other sites
DeYaN. Proficient

DeYaN. 27

Posted
  • Author
Posted
Just now, DarkAng3l said:

I rewrite function GetWeaponType in InstanceBase.cpp, because I had same problem.

  Hide contents

DWORD CInstanceBase::GetWeaponType()
{
    DWORD dwWeapon = GetPart(CRaceData::PART_WEAPON);
    CItemData * pItemData;
    if (!CItemManager::Instance().GetItemDataPointer(dwWeapon, &pItemData))
        return CItemData::WEAPON_NONE;
#ifdef ENABLE_COSTUME_WEAPON
    if (pItemData->GetType() == CItemData::ITEM_TYPE_COSTUME)
    {
        if (pItemData->GetSubType() == CItemData::COSTUME_WEAPON_SWORD)
            return CItemData::WEAPON_SWORD;
        else if (pItemData->GetSubType() == CItemData::COSTUME_WEAPON_DAGGER)
            return CItemData::WEAPON_DAGGER;
        else if (pItemData->GetSubType() == CItemData::COSTUME_WEAPON_BOW)
            return CItemData::WEAPON_BOW;
        else if (pItemData->GetSubType() == CItemData::COSTUME_WEAPON_TWO_HANDED)
            return CItemData::WEAPON_TWO_HANDED;
        else if (pItemData->GetSubType() == CItemData::COSTUME_WEAPON_BELL)
            return CItemData::WEAPON_BELL;
        else if (pItemData->GetSubType() == CItemData::COSTUME_WEAPON_FAN)
            return CItemData::WEAPON_FAN;
        else if (pItemData->GetSubType() == CItemData::COSTUME_WEAPON_CLAW)
            return CItemData::WEAPON_CLAW;
        else
            return pItemData->GetWeaponType();
    }
#endif
    return pItemData->GetWeaponType();
}

 

MAN !!! YOU ARE THE GOD. THX !! SOLVE ALL !! DANKEEEE xD

Link to comment
Share on other sites

Please sign in to comment

You will be able to leave a comment after signing in



Sign In Now
 Share
Go to topic listing

Announcements



  • Similar Content

  • Activity

    1. 4

      Feeding game source to LLM

      You don't need to train it on your source code. You just need to take a good model and give it more context. For example I use Github Copilot to help me with some trivial task while coding. If I need info about the whole source I just use @workspace in the chat when I ask it a question and then he has more context about the source.
      Abel(Tiger) in Metin2
    2. 0

      Quest 6/7 Problem

      Hi, sorry for my terrible English. I have a problem with system 6/7 of these server files. [Hidden Content] They do not bring the system quest. I don't know much about programming quests, I tried to adapt a quest from other server files, but I only managed to get it to open the bonus window. Does anyone have the quest or can do it? I would greatly appreciate the help I use '--' just for identify the quest_function I had and the quest I try to adapt [Hidden Content]
      Rags in Community Support - Questions & Answers
    3. 5

      Effect weapons

      I have the .mde and the .mse next to each other however this does not really work.. I have the correct EFFECT_REFINED + (the number of the enum value) in the playersettingmodule.py I applied the effect on InstanceBase.cpp (considering the item's vnum) with no luck.. Do I miss something? Does those files have a prefix path or something? Like if I put them on the wrong path (think about the granny texture) will not find them at all?
      white in Community Support - Questions & Answers
    4. 0

      [C++] Fix Core Downer Using Negative Number in GM Codes

      INTRODUCTION & PROBLEM Hello, today we will fix a few errors, especially the error that caused the core down by giving an unexpected negative (-) arg (number) in the commands (Example; /mob 101 -1), and we will also regulate the use of "ChatPacket" in this functions. WHY ? GMs are already part of the team, you may ask why we need this, you are right, but do not forget that a GM who does not have coding knowledge may accidentally trigger this, let's not leave it to chance. SOLUTION The process we will do is simple, it will be enough to make sure that the given arg value is within the range we want, let's get started. [Hidden Content]
      • 5
      • Metin2 Dev
      • muscle
      MT2Dev in Bug Fixes
    5. 3

      Crystal Metinstone

      Awesome!! Can u make it with other colors too? Like ice fire forest lightning ?
      asdasd1234 in Metinstones
    6. 4

      Feeding game source to LLM

      ChatGPT is obsolete today honestly. I use claude-3-opus LLM daily for commercial programming and it exceeds chatgpt by a mile. When it comes to token size it's like you said, not possible straight away with chatgpt. There's however a way to go around this with some additional layers of complexity like Cursor Editor although be warned its closed source. It's basically a fork of vscode that let's you ask LLMs about your code. Also you can ask it to write anything and it has the context of your entire codebase. I tested it a few months back and it wasn't bad honestly. I told it to explain some shit-code written by ymir that I didn't understand and it did quite well.
      b6d4a82c15 in Metin2
    7. 113

      Ulthar SF V2 (TMP4 Base)

      active effect : - inventory good - panel lags
      master1988 in Binaries
    8. 10

      Increase max Yang full

      thanks for this system
      • 1
      • Metin2 Dev
      palmiro91 in Programming & Scripts
    9. 4

      Feeding game source to LLM

      I had tried something similar before through custom GPT via ChatGPT, but instead of searching for bugs/exploits, I attempted to create a simple ping/pong system by providing all the details just to see what it could do for experimental purposes. However, speaking for ChatGPT, it doesn't automatically scan the entire content due to the large number of files. It only makes heuristic-based guesses based on the names or scans the files if specified. Even if it processes the entire content correctly, the whole processing takes a long time, so it starts skipping parts after a while until the main command is given. Additionally, even if you manage to achieve the desired result once, due to temperature imbalances, getting completely unrelated results in subsequent attempts is possible. Therefore, in summary, obtaining efficient results is not quite achievable. It's quite useful for conducting research on specific topics in specific parts rather than scanning the entire content. However, for now fully automating it is not very feasible, at least for ChatGPT.
      • 1
      • Metin2 Dev
      Koray in Metin2

  • Recently Browsing

    • No registered users viewing this page.
×
×
  • Create New...

Important Information

Terms of Use / Privacy Policy / Guidelines / We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.