[HowTo] QUEST_STATE_MAX_LEN

[Cunoo 209]

Hi everyone,

I need change lenght for "QUEST_STATE_MAX_LEN".. Default size is 64, but I have after changes problems.. Just after open longest quest client frozen..

My changes:

Serverside:

common/tables.h

#define QUEST_STATE_MAX_LEN	64

to

#define QUEST_STATE_MAX_LEN	128

Clientside:

eterlib/parses.cpp // 2x

if (iValueLen >= 64)
				{
					TraceError("argument value overflow: must be shorter than 64 letters");
					return false;
				}

to

if (iValueLen >= 128)
				{
					TraceError("argument value overflow: must be shorter than 128 letters");
					return false;
				}

What can I do bad?

Edit: Ok I´m idiot!.. I forgot this:

char szValue[64 + 1];

to

char szValue[128 + 1];

same files in clientside before first code..

Okey thanks, here is free guide if someone need too

[filipw1 1821]

Why would I change that?

[Flourine 102]

Buffer overflow i think. I had same and i used one fix from another forum

[Cunoo 209]

10 hours ago, Flourine said:

Buffer overflow i think. I had same and i used one fix from another forum

Yes you are right.. I create mistake in code.. Forgot change all code.. Now working fine..

10 hours ago, filipw1 said:

Why would I change that?

For example if you need more characters than 64 in your quest functions.. I want this for function "say_item"  because I need longer desc..

[arves100 1489]

You have the define for one reason, use it!

Stop hardcoding.

 

if (iValueLen >= QUEST_STATE_MAX_LEN)

char szValue[QUEST_STATE_MAX_LEN + 1];