Jump to content

Combo skill is dead


Recommended Posts

Hi DEVs ❤️ 
My combo support skill is not working (other support skills are working fine [I mean skill level]).
I can set it to 1/2 via command, support skill points or combo skill books - I just cannot turn it on/off from characterwindow (CANNOT_SKILL_NOT_YET_LEARN) - on skill icon there's no skill level (0 (empty), 1/2 [or like on leadership 0-19/m1-10/g1-10/P])

Console command [python] (setcombotype 0/1/2) is working
Other players can see my combo

https://metin2.download/picture/vB4tb7nL22fexg7oAu3j7A98YDaBJnT5/.gif
https://metin2.download/picture/WBsQBEh2fEfNzMK1I5t8pqTVzIhnWjbf/.gif

syslog from channel and DB

Sep  2 22:11:18 :: COMMAND: Nirray2: setskill
Sep  2 22:11:20 :: COMMAND: Nirray2: skillup
Sep  2 22:11:20 :: SkillUp: Nirray2 122 0 1[Before:0] type 0
Sep  2 22:11:20 :: COMMAND: Nirray2: skillup
Sep  2 22:11:20 :: SkillUp: Nirray2 122 0 2[Before:1] type 0
Sep  2 22:11:20 :: COMMAND: Nirray2: skillup
Sep  2 22:11:20 :: SAVE: Nirray2 966460x276822
Sep  2 22:11:20 :: COMMAND: Nirray2: skillup

(Which means server side is working and skill index+skill level are set correctly [I can logout character/shutdown server and the combo level is still here])
No clientside syserr.
Python part bug? Client source bug?
Any ideas? I can't  figure it out ? Thanks ?
 

Edited by Metin2 Dev
Core X - External 2 Internal

I completely abandoned working on the files for this game. I do not respond to private messages.

.png

Link to comment
Share on other sites

  • Forum Moderator

By default, you can increase the skill level of combo with books, not by point up.

Check for DISABLE_BY_POINT_UP from skill index 122:

  • skill_proto (server)
  • skilltable.txt (client)

void CPythonPlayer::SetComboSkillFlag(BOOL bFlag), you could check #1 #2, what happen. (btw, seems like your skill level of combo doesn't get update in client)

Edited by Metin2 Dev
Core X - External 2 Internal
  • Love 1
Link to comment
Share on other sites

32 minutes ago, VegaS™ said:

By default, you can increase the skill level of combo with book, not by point up.

Check for DISABLE_BY_POINT_UP from skill index 122:

  • skill_proto (server)
  • skilltable.txt (client)

void CPythonPlayer::SetComboSkillFlag(BOOL bFlag), you could check here what happen.

Neither of them work: skillup, skill book, setksk 122 1/2, pc.set_skill_level(122, 2) [quest], DISABLE_BY_POINT_UP (on/off) [skill_proto] in clientside Interface - I've already tried ? 
 

https://metin2.download/picture/HJx2t6WaeY3gPdF454fV1Hhf099fE7tc/.gif

50304 ID = The Art Of Combo skill book
LUA-> "Powodzeniem" = Successful
Result: still cannot use it (Debug: skill id: 122 is set to 1 from 0)
@VegaS™ It's more like client can't set skill level on combo icon [skill index/skill slot] -> Leadership and  Mining works fine and other support-passives too

Update: On my old RAW client combo is working like a charm
So it's a python bug/client source ? 

https://metin2.download/picture/0o93FQmh931VEZRmUL2tKoasE560ZRX1/.gif


Update2: it's not skilldesc.txt, skilltable.txt problem [checked with default Metin2 ones] and uicharacter.py (checked with original one)

Edited by Metin2 Dev
Core X - External 2 Internal

I completely abandoned working on the files for this game. I do not respond to private messages.

.png

Link to comment
Share on other sites

  • Forum Moderator

Did you check what level he sent from packet?

Spoiler

bool CPythonNetworkStream::RecvSkillLevelNew()
{
	TPacketGCSkillLevelNew packet;

	if (!Recv(sizeof(TPacketGCSkillLevelNew), &packet))
	{
		Tracen("CPythonNetworkStream::RecvSkillLevelNew - RecvError");
		return false;
	}

	const CPythonPlayer & rkPlayer = CPythonPlayer::Instance();

	rkPlayer.SetSkill(7, 0);
	rkPlayer.SetSkill(8, 0);

	for (int i = 0; i < SKILL_MAX_NUM; ++i)
	{
		const TPlayerSkill & rPlayerSkill = packet.skills[i];

		if (i >= 112 && i <= 115 && rPlayerSkill.bLevel)
			rkPlayer.SetSkill(7, i);

		if (i >= 116 && i <= 119 && rPlayerSkill.bLevel)
			rkPlayer.SetSkill(8, i);

		if (i == 122)
			TraceError("Combo skill level: %d", rPlayerSkill.bLevel);

		rkPlayer.SetSkillLevel_(i, rPlayerSkill.bMasterType, rPlayerSkill.bLevel);
	}

	__RefreshSkillWindow();
	__RefreshStatus();
	return true;
}
  • 0903 00:56:53064 :: Combo skill level: 0
  • 0903 00:56:59268 :: Combo skill level: 1
  • 0903 00:56:00242 :: Combo skill level: 2
     
  • Love 2
Link to comment
Share on other sites

22 minutes ago, VegaS™ said:

Did you check what level he sent from packet?

  Hide contents


bool CPythonNetworkStream::RecvSkillLevelNew()
{
	TPacketGCSkillLevelNew packet;

	if (!Recv(sizeof(TPacketGCSkillLevelNew), &packet))
	{
		Tracen("CPythonNetworkStream::RecvSkillLevelNew - RecvError");
		return false;
	}

	const CPythonPlayer & rkPlayer = CPythonPlayer::Instance();

	rkPlayer.SetSkill(7, 0);
	rkPlayer.SetSkill(8, 0);

	for (int i = 0; i < SKILL_MAX_NUM; ++i)
	{
		const TPlayerSkill & rPlayerSkill = packet.skills[i];

		if (i >= 112 && i <= 115 && rPlayerSkill.bLevel)
			rkPlayer.SetSkill(7, i);

		if (i >= 116 && i <= 119 && rPlayerSkill.bLevel)
			rkPlayer.SetSkill(8, i);

		if (i == 122)
			TraceError("Combo skill level: %d", rPlayerSkill.bLevel);

		rkPlayer.SetSkillLevel_(i, rPlayerSkill.bMasterType, rPlayerSkill.bLevel);
	}

	__RefreshSkillWindow();
	__RefreshStatus();
	return true;
}
  • 0903 00:56:53064 :: Combo skill level: 0
  • 0903 00:56:59268 :: Combo skill level: 1
  • 0903 00:56:00242 :: Combo skill level: 2
     

level.png

0903 00:05:25663 :: Combo level: 0
0903 00:05:26868 :: Combo level: 1
0903 00:05:27627 :: Combo level: 2
(/setsk 122 0,1,2)

Update:
combo.png

I guess the problem lies somewhere here

Edited by Metin2 Dev
Core X - External 2 Internal

I completely abandoned working on the files for this game. I do not respond to private messages.

.png

Link to comment
Share on other sites

UPDATE2:

Fixed:

https://metin2.download/picture/P9kTCV5D0Vsun2584iLcmlK1c8sx2b5V/.gif

Reason: extern const DWORD c_iSkillIndex_Combo from PythonPlayerModule.cpp was with wrong ID (my old edit - error)

@VegaS™ thank you for your time!

Edited by Metin2 Dev
Core X - External 2 Internal
  • Love 1

I completely abandoned working on the files for this game. I do not respond to private messages.

.png

Link to comment
Share on other sites

Please sign in to comment

You will be able to leave a comment after signing in



Sign In Now

Announcements



×
×
  • Create New...

Important Information

Terms of Use / Privacy Policy / Guidelines / We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.