fix Fix Shutdown Server Command

[Ken 889]

I think someone still haven't seen this error in game source file or someone fix it but not share on metin2dev.org. What's ever

 

Open your cmd_general.cpp and search this

ACMD(do_shutdown)

change with this ;

ACMD(do_shutdown)
{
	if (!ch->IsGM())
		return;

	if (NULL == ch)
	{
		sys_err("Accept shutdown command from %s.", ch->GetName());
	}
	TPacketGGShutdown p;
	p.bHeader = HEADER_GG_SHUTDOWN;
	P2P_MANAGER::instance().Send(&p, sizeof(TPacketGGShutdown));

	Shutdown(10);
}

Best Regards

Ellie

Edited February 6, 2015 by Ken

[ATAG 309]

Or change

 

{ "shutdown", do_shutdown,  0,   POS_DEAD, GM_HIGH_WIZARD },

to

{ "shutdown",	do_shutdown,		0,			POS_DEAD,	GM_IMPLEMENTOR	},

[Ken 889]

I think so two solution result same but i choose my way

 

Thanks for comment.

 

Best Regards

Ellie

[Night 363]

yes you are right but i do belive that

ATAG solution is an easy one

dont you think so

[UserForum 4]

Thanks you : )

[flygun 298]

change this

if (ch->GetGMLevel() <= GM_IMPLEMENTOR)
return;

to this

if (ch->GetGMLevel() < GM_IMPLEMENTOR)
return;

[Ken 889]

 

change this

if (ch->GetGMLevel() <= GM_IMPLEMENTOR)
return;

to this

if (ch->GetGMLevel() < GM_IMPLEMENTOR)
return;

 

Thanks for answer. But i think is enough

if (!ch->IsGM())
   return;

Kind Regards

Ken ~ TA

[flygun 298]

 

 

change this

if (ch->GetGMLevel() <= GM_IMPLEMENTOR)
return;

to this

if (ch->GetGMLevel() < GM_IMPLEMENTOR)
return;

 

Thanks for answer. But i think is enough

if (!ch->IsGM())
   return;

Kind Regards

Ken ~ TA

 

yup it is enough

[Sanchez 2403]

Maybe I'm too tired, but this will throw an exception if the character does not exist.

 

1. You're using the IsGM() function on the CHARACTER class, before the NULL check.

2. If the character does not exist you're trying to use the GetName() function on the NULL class, which will also throw an exception.

[Sober 37]

I see so many people trying to eliminate this condition e.g if(!ch)... but i don't get it.How can someone use a command without having a character???

[flygun 298]

Maybe I'm too tired, but this will throw an exception if the character does not exist.

 

1. You're using the IsGM() function on the CHARACTER class, before the NULL check.

2. If the character does not exist you're trying to use the GetName() function on the NULL class, which will also throw an exception.

how can a player be not existed ? O.o

[Ken 889]

Maybe I'm too tired, but this will throw an exception if the character does not exist.

 

1. You're using the IsGM() function on the CHARACTER class, before the NULL check.

2. If the character does not exist you're trying to use the GetName() function on the NULL class, which will also throw an exception.

void interpret_command(LPCHARACTER ch, const char * argument, size_t len)

System already sent this. cmd.cpp -> cmd_gm.cpp or cmd_general.cpp or cmd_emotion.cpp

 

Kind Regards

Ken ~ TA

[A4Tech 1]

and for the people aren't using source how can they fix the command ?

[bluedrago 28]

my server say that command no exist....how fix...????

i add 

ACMD(do_shutdown)
{
	if (!ch->IsGM())
		return;

	if (NULL == ch)
	{
		sys_err("Accept shutdown command from %s.", ch->GetName());
	}
	TPacketGGShutdown p;
	p.bHeader = HEADER_GG_SHUTDOWN;
	P2P_MANAGER::instance().Send(&p, sizeof(TPacketGGShutdown));

	Shutdown(10);
}

and nothing say that command no exist... and in cmd in CMD is shutdowm implementor...

[Deliris 391]

Show us cmd.cpp from game/src.

[WeedHex 626]

Thread 2014... Refresh:

 

ACMD(do_shutdown)

change with this ;

ACMD(do_shutdown)
{
 	if (!ch)
	    return;
	if (!ch->IsGM())
	    return;

	TPacketGGShutdown p;
	p.bHeader = HEADER_GG_SHUTDOWN;
	P2P_MANAGER::instance().Send(&p, sizeof(TPacketGGShutdown));
	sys_err("Accept shutdown command from %s.", ch->GetName());
	Shutdown(10);
}