fix Fix Dungeon Music

[Sonitex 1400]

Hey community!

When you specify which music you want to play in your dungeon map at settings.lua, it is always getting replaced with previous map's one(From which you were teleported to). This is happening because each dungeon has it's own unique map index and game cannot locate it from settings.

Here is a simple fix to get original index of that map, it should work as long as you do not have like 10000 dungeon instances of same type, which isn't possible with current Metin2 player count I believe.

In char.cpp search for:

void CHARACTER::MainCharacterPacket()

Replace this variable with the following:

const unsigned mapIndex = GetMapIndex();

const unsigned mapIndex = GetMapIndex() < 10000 ? GetMapIndex() : GetMapIndex() / 10000;

Greetings,

Sonitex

[Raylee 645]

Amazing 
Good job mate 

Best regards
Raylee

[JarajTo 40]

I believe that more than 3500 dungeon instances of same type are possible.

 

Nice one

[xP3NG3Rx 19048]

I don't have this function none of my sources what I have:

MainCharacterPacket

[M.Sorin 276]

21 minutes ago, xP3NG3Rx said:

I don't have this function none of my sources what I have:

MainCharacterPacket

void CHARACTER::MainCharacterPacket()

 

[Legend 183]

I never notice this untill now (i'm not a fun of metin2 music always is off), thanks for the fix

[xP3NG3Rx 19048]

Yeah I've got it, there is an encoding problem in the code bb code of the board, this why I didn't find it.

[M.Sorin 276]

50 minutes ago, xP3NG3Rx said:

Yeah I've got it, there is an encoding problem in the code bb code of the board, this why I didn't find it.

Yea i know, i didn`t find it either. Anyway, i never notice this bug

[hachiwari 136]

2 godziny temu, JarajTo napisał:

I believe that more than 3500 dungeon instances of same type are possible.

 

Nice one

3500? How did you calculate this number?

[Metin2 Dev 4650]

Don't fix bugs by creating new bugs.

[Sonitex 1400]

13 hours ago, hachiwari said:

3500? How did you calculate this number?

Actually I was wrong, there would have to be more than or equal to 10000 dungeons of same type because, (mapIndex * 10000 + 10000) / 10000 > mapIndex and we wouldn't get original mapIndex but mapIndex+1 or more, depends on dungeon instances. For some reason I thought it would round up the number, but it's type is integer so it is not possible  so I just said 3500 just to give an idea. I apologise for that.

 

16 hours ago, JarajTo said:

I believe that more than 3500 dungeon instances of same type are possible.

 

Nice one

Sure, I would love to see that happen. There isn't a server with more than 3000 unique players right now, but you would need more than 10000 unique players(as I corrected myself earlier), each one creating their own dungeon, good luck with that one.

1 hour ago, Chyu ^^ said:

Don't fix bugs by creating new bugs.

If you are referring to having more than 10000 dungeons, it is just not possible, if not I'd love to hear those 'new bugs' and will happily fix them.

[Metin2 Dev 4650]

1 hour ago, Sonitex said:

If you are referring to having more than 10000 dungeons, it is just not possible, if not I'd love to hear those 'new bugs' and will happily fix them.

What I'm trying to say is your method to solving the bugs is incorrect. Yeah, In THIS case it WOULD may not be problem.

[FantaSanta 1]

Good job mate