Bug in soul bind system <video>

numNum · April 4, 2018

Hi there

I've installed this soul bind system

everything work fine but there is only one problem when i stored soul binded item in Safebox , the soul bind is disappear

this video will explain ,

looking for solution please ..

cjunior2011 · May 7, 2019

up, same problem

OtherChoice · May 7, 2019

I don't have this system and files are no longer avaible, however I think the problem could be one and only, query to store item won't save the parameter which determines the binding of the item. If you can't still find it out please share how your Soulbind System is implemented in db and you'll have your answer.

cjunior2011 · May 7, 2019

8 minutes ago, OtherChoice said:

I don't have this system and files are no longer avaible, however I think the problem could be one and only, query to store item won't save the parameter which determines the binding of the item. If you can't still find it out please share how your Soulbind System is implemented in db and you'll have your answer.

I installed the same system as the creator of the post and I have the same problem.

Cache.cpp https://paste.ubuntu.com/p/p5ZspKdKcc/

ClientManager.cpp https://paste.ubuntu.com/p/GQqnVVwwz5/

ClientManagerPlayer.cpp https://paste.ubuntu.com/p/2KN9SxysjP/

cjunior2011 · May 7, 2019

UP

OtherChoice · May 7, 2019

14 hours ago, cjunior2011 said:

I installed the same system as the creator of the post and I have the same problem.

Cache.cpp https://paste.ubuntu.com/p/p5ZspKdKcc/

ClientManager.cpp https://paste.ubuntu.com/p/GQqnVVwwz5/

ClientManagerPlayer.cpp https://paste.ubuntu.com/p/2KN9SxysjP/

next time don't show full source just the implementation so who wants to help you doesn't have to search in 3000 lines of code, however i need one more information: try depositing a bind item into storage, close storage and logout from game, then go into your DB player and check inside "item" for your item. It should show window = SAFEBOX, if not DB is still not updated and shall you wait a minute. After your item displays the correct window check the column "sealbind" (or anything you chosed to use), if the value is still set then its a missing client binary part (packet with HEADER_GC_SAFEBOX_SET missing long sealbind; and it implementation). Otherwise i'll look deeper into those 3000 lines of code.

cjunior2011 · May 8, 2019

7 hours ago, OtherChoice said:

next time don't show full source just the implementation so who wants to help you doesn't have to search in 3000 lines of code, however i need one more information: try depositing a bind item into storage, close storage and logout from game, then go into your DB player and check inside "item" for your item. It should show window = SAFEBOX, if not DB is still not updated and shall you wait a minute. After your item displays the correct window check the column "sealbind" (or anything you chosed to use), if the value is still set then its a missing client binary part (packet with HEADER_GC_SAFEBOX_SET missing long sealbind; and it implementation). Otherwise i'll look deeper into those 3000 lines of code.

I'm sorry for having posted the complete source code, I will edit this post and show only the parts of the system in the codes, I did your test and the result was:
1- When I put the item linked to the warehouse, it loses the link instantly:

https://metin2.download/picture/81spJQPnH9to5Jd6tEN1b6KaGC04XZb8/.gifv

2- I believe that the number that is listed in the SAFEBOX item table is wrong:

Spoiler

ps: is there any way to prevent putting any locked item in the warehouse?

I think this would solve my problem faster. (I do not know if that's how it works in the official)

Edited August 25, 2022 by Metin2 Dev
Core X - External 2 Internal

OtherChoice · May 8, 2019

Did you tried getting back the item from the storage? does it get binding back or is it still lost?

WeedHex · May 8, 2019

It's like official.

Item block = Can't go out from the ACCOUNT -> not just from char.

Btw if you want to block there too:

File: input_main.cpp

Find for: "void CInputMain::SafeboxCheckin"

Find this if: "if (true == pkItem->isLocked())"

Add this new check after:

Spoiler

#ifdef ENABLE_SOULBIND_SYSTEM
   if (pkItem->IsBind() || pkItem->IsUntilBind())
   {
       ch->ChatPacket(CHAT_TYPE_INFO, "??????????????????????");
       return;
   }
#endif

cjunior2011 · May 8, 2019

11 hours ago, OtherChoice said:

Did you tried getting back the item from the storage? does it get binding back or is it still lost?

when I take the item out of the warehouse, it continues without the bind/lock.

2 hours ago, WeedHex said:

It's like official.

Item block = Can't go out from the ACCOUNT -> not just from char.

Btw if you want to block there too:

File: input_main.cpp

Find for: "void CInputMain::SafeboxCheckin"

Find this if: "if (true == pkItem->isLocked())"

Add this new check after:

Hide contents

#ifdef ENABLE_SOULBIND_SYSTEM
   if (pkItem->IsBind() || pkItem->IsUntilBind())
   {
       ch->ChatPacket(CHAT_TYPE_INFO, "??????????????????????");
       return;
   }
#endif

I'll test this, thx.

edit: I adapted your code to my system and it worked perfectly, thank you @OtherChoice and @WeedHex! #SOLVED

#ifdef ENABLE_SOULBIND_SYSTEM
    if (pkItem->IsSealed())
    {
        ch->ChatPacket(CHAT_TYPE_INFO, "Can't put sealed items in the warehouse");
        return;
    }
#endif

cjunior2011 · May 13, 2019

On 5/8/2019 at 11:24 AM, WeedHex said:

It's like official.

Item block = Can't go out from the ACCOUNT -> not just from char.

Btw if you want to block there too:

File: input_main.cpp

Find for: "void CInputMain::SafeboxCheckin"

Find this if: "if (true == pkItem->isLocked())"

Add this new check after:

Reveal hidden contents

#ifdef ENABLE_SOULBIND_SYSTEM
   if (pkItem->IsBind() || pkItem->IsUntilBind())
   {
       ch->ChatPacket(CHAT_TYPE_INFO, "??????????????????????");
       return;
   }
#endif

New problem

after reset server items equiped or with bind they looked like this:

equiped item:

https://metin2.download/picture/r3F9504x09DVmF8K988YXgTtGTP6KMUj/.gif

item that was bind / bound / blocked:

https://metin2.download/picture/r3F9504x09DVmF8K988YXgTtGTP6KMUj/.gif

any solution or is it normal to lose the bind after resetting the server?

Edited September 3, 2022 by Metin2 Dev
Core X - External 2 Internal

OtherChoice · May 13, 2019

please show this struct of your client binary (or the second one in case you client uses it). You can check whether is used in bool CPythonNetworkStream::RecvSafeBoxSetPacket() (PythonNetworkStreamPhaseGame.cpp)

typedef struct packet_set_item
{
	BYTE		header;
	TItemPos	Cell;
	DWORD		vnum;
	BYTE		count;
	long		alSockets[CItemData::ITEM_SOCKET_MAX_NUM];
    TPlayerItemAttribute aAttr[ITEM_ATTRIBUTE_SLOT_MAX_NUM];
} TPacketGCItemSet;
typedef struct packet_set_item2
{
	BYTE		header;
	TItemPos	Cell;
	DWORD		vnum;
	BYTE		count;
	DWORD		flags;	// ÇÃ·¡±× Ãß°¡
	DWORD		anti_flags;	// ÇÃ·¡±× Ãß°¡
	bool		highlight;
	long		alSockets[CItemData::ITEM_SOCKET_MAX_NUM];
    TPlayerItemAttribute aAttr[ITEM_ATTRIBUTE_SLOT_MAX_NUM];
} TPacketGCItemSet2;

from server/common in tables.h show

typedef struct SPlayerItem
{
	DWORD	id;
	BYTE	window;
	WORD	pos;
	DWORD	count;

	DWORD	vnum;
	long	alSockets[ITEM_SOCKET_MAX_NUM];	// 소켓번호

	TPlayerItemAttribute    aAttr[ITEM_ATTRIBUTE_MAX_NUM];

	DWORD	owner;
} TPlayerItem;

and from client binary in GameType.h show

typedef struct packet_item
{
    DWORD       vnum;
    BYTE        count;
	DWORD		flags;
	DWORD		anti_flags;
	long		alSockets[CItemData::ITEM_SOCKET_MAX_NUM];
    TPlayerItemAttribute aAttr[ITEM_ATTRIBUTE_SLOT_MAX_NUM];
} TItemData;

cjunior2011 · May 13, 2019

9 hours ago, OtherChoice said:

please show this struct of your client binary (or the second one in case you client uses it). You can check whether is used in bool CPythonNetworkStream::RecvSafeBoxSetPacket() (PythonNetworkStreamPhaseGame.cpp)


typedef struct packet_set_item
{
	BYTE		header;
	TItemPos	Cell;
	DWORD		vnum;
	BYTE		count;
	long		alSockets[CItemData::ITEM_SOCKET_MAX_NUM];
    TPlayerItemAttribute aAttr[ITEM_ATTRIBUTE_SLOT_MAX_NUM];
} TPacketGCItemSet;
typedef struct packet_set_item2
{
	BYTE		header;
	TItemPos	Cell;
	DWORD		vnum;
	BYTE		count;
	DWORD		flags;	// ÇÃ·¡±× Ãß°¡
	DWORD		anti_flags;	// ÇÃ·¡±× Ãß°¡
	bool		highlight;
	long		alSockets[CItemData::ITEM_SOCKET_MAX_NUM];
    TPlayerItemAttribute aAttr[ITEM_ATTRIBUTE_SLOT_MAX_NUM];
} TPacketGCItemSet2;

from server/common in tables.h show


typedef struct SPlayerItem
{
	DWORD	id;
	BYTE	window;
	WORD	pos;
	DWORD	count;

	DWORD	vnum;
	long	alSockets[ITEM_SOCKET_MAX_NUM];	// 소켓번호

	TPlayerItemAttribute    aAttr[ITEM_ATTRIBUTE_MAX_NUM];

	DWORD	owner;
} TPlayerItem;

and from client binary in GameType.h show


typedef struct packet_item
{
    DWORD       vnum;
    BYTE        count;
	DWORD		flags;
	DWORD		anti_flags;
	long		alSockets[CItemData::ITEM_SOCKET_MAX_NUM];
    TPlayerItemAttribute aAttr[ITEM_ATTRIBUTE_SLOT_MAX_NUM];
} TItemData;

Spoiler


typedef struct packet_set_item
{
    BYTE        header;
    BYTE        pos;
    DWORD        vnum;
    BYTE        count;
    DWORD        flags;    // 플래그 추가
    long        alSockets[ITEM_SOCKET_SLOT_MAX_NUM];
    TPlayerItemAttribute aAttr[ITEM_ATTRIBUTE_SLOT_MAX_NUM];
#ifdef ENABLE_SOULBIND_SYSTEM
    long        sealbind;
#endif
} TPacketGCItemSet;

typedef struct packet_set_item2
{
    BYTE        header;
    TItemPos    Cell;
    DWORD        vnum;
    BYTE        count;
    DWORD        flags;    // 플래그 추가
    DWORD        anti_flags;    // 플래그 추가
    bool        highlight;
    long        alSockets[ITEM_SOCKET_SLOT_MAX_NUM];
    TPlayerItemAttribute aAttr[ITEM_ATTRIBUTE_SLOT_MAX_NUM];
#ifdef ENABLE_SOULBIND_SYSTEM
    long        sealbind;
#endif
} TPacketGCItemSet2;

Spoiler


typedef struct SPlayerItem
{
	DWORD	id;
	BYTE	window;
	WORD	pos;
	DWORD	count;

	DWORD	vnum;
	long	alSockets[ITEM_SOCKET_MAX_NUM];	// 소켓번호

	TPlayerItemAttribute    aAttr[ITEM_ATTRIBUTE_MAX_NUM];

	DWORD	owner;
#ifdef ENABLE_SOULBIND_SYSTEM
	long	sealbind;
#endif
} TPlayerItem;

Spoiler


typedef struct packet_item
{
	DWORD		vnum;
	BYTE		count;
	DWORD		flags;
	DWORD		anti_flags;
	long		alSockets[ITEM_SOCKET_SLOT_MAX_NUM];
	TPlayerItemAttribute aAttr[ITEM_ATTRIBUTE_SLOT_MAX_NUM];
#ifdef ENABLE_SOULBIND_SYSTEM
	long		sealbind;
#endif
} TItemData;

CPythonNetworkStream::RecvSafeBoxSetPacket(): PythonNetworkStreamPhaseGameItem.cpp*

Spoiler


bool CPythonNetworkStream::RecvSafeBoxSetPacket()
{
	TPacketGCItemSet2 kItemSet;
	if (!Recv(sizeof(kItemSet), &kItemSet))
		return false;

	TItemData kItemData;
	kItemData.vnum	= kItemSet.vnum;
	kItemData.count = kItemSet.count;
	kItemData.flags = kItemSet.flags;
	kItemData.anti_flags = kItemSet.anti_flags;
	for (int isocket=0; isocket<ITEM_SOCKET_SLOT_MAX_NUM; ++isocket)
		kItemData.alSockets[isocket] = kItemSet.alSockets[isocket];
	for (int iattr=0; iattr<ITEM_ATTRIBUTE_SLOT_MAX_NUM; ++iattr)
		kItemData.aAttr[iattr] = kItemSet.aAttr[iattr];
#ifdef ENABLE_SOULBIND_SYSTEM
	kItemData.sealbind = kItemSet.sealbind;
#endif
	CPythonSafeBox::Instance().SetItemData(kItemSet.Cell.cell, kItemData);

	__RefreshSafeboxWindow();

	return true;
}

OtherChoice · May 13, 2019

Honestly I can't really figure out whats wrong here I'm sorry man but everything should work fine

cjunior2011 · May 13, 2019

3 hours ago, OtherChoice said:

Honestly I can't really figure out whats wrong here I'm sorry man but everything should work fine

All right, thank you anyway!

cjunior2011 · May 25, 2019

UP

numNum · May 25, 2019

@cjunior2011

there is other soulbind system with different coding , search for it

i suggest you to delete this system and install the other one

cjunior2011 · May 26, 2019

On 5/25/2019 at 12:00 AM, jeddawee said:

@cjunior2011

there is other soulbind system with different coding , search for it

i suggest you to delete this system and install the other one

this problem happens with any item after restarting the server, I think it is not because of the soulbind system, I need to do some tests without enabling the system and testing with clean files without any system, thank you anyway!

Sign In

Bug in soul bind system <video>

Recommended Posts

numNum 36

Link to comment

Share on other sites

Top Posters In This Topic

Popular Days

Top Posters In This Topic

Popular Days

Popular Posts

WeedHex

OtherChoice

OtherChoice

cjunior2011 8

Link to comment

Share on other sites

OtherChoice 77

Link to comment

Share on other sites

cjunior2011 8

Link to comment

Share on other sites

cjunior2011 8

Link to comment

Share on other sites

OtherChoice 77

Link to comment

Share on other sites

cjunior2011 8

Link to comment

Share on other sites

OtherChoice 77

Link to comment

Share on other sites

WeedHex 626

Link to comment

Share on other sites

cjunior2011 8

Link to comment

Share on other sites

cjunior2011 8

Link to comment

Share on other sites

OtherChoice 77

Link to comment

Share on other sites

cjunior2011 8

Link to comment

Share on other sites

OtherChoice 77

Link to comment

Share on other sites

cjunior2011 8

Link to comment

Share on other sites

cjunior2011 8

Link to comment

Share on other sites

numNum 36

Link to comment

Share on other sites

cjunior2011 8

Link to comment

Share on other sites

Please sign in to comment

Announcements

Similar Content

Activity

Recently Browsing

Important Information